marination
44ab131792
fix: Retain space inside Serial no string while cleaning serial nos
...
(cherry picked from commit 41035b0330 )
2021-10-18 04:56:10 +00:00
rohitwaghchaure
1b7d94d70d
Merge pull request #27961 from rohitwaghchaure/merge-13-hotfix-to-pre-release-for-13-13
...
chore: Merge branch 'version-13-hotfix' into 'version-13-pre-release'
2021-10-14 19:17:22 +05:30
Rohit Waghchaure
952c60b3f5
Merge branch 'version-13-hotfix' into 'version-13-pre-release'
2021-10-14 18:31:09 +05:30
rohitwaghchaure
8c33103838
Merge pull request #27958 from frappe/mergify/bp/version-13-hotfix/pr-27954
...
fix: value_after_depreciation calculation (backport #27954 )
2021-10-14 18:25:57 +05:30
mergify[bot]
a8c966eb25
fix: patch to enable scheduled job for reposting (backport #27957 )
...
* fix: patch to enable scheduled job for reposting
(cherry picked from commit efc60ec2b5 )
# Conflicts:
# erpnext/patches.txt
* chore: formatting
(cherry picked from commit 3f97413814 )
* Update enable_scheduler_job_for_item_reposting.py
(cherry picked from commit 230a5d4b39 )
* fix: resolve conflict
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com >
2021-10-14 17:31:51 +05:30
Saqib
88b1c1c87e
fix: value_after_depreciation calculation ( #27954 )
...
(cherry picked from commit 1f70dd6e98 )
2021-10-14 10:53:52 +00:00
Marica
771213c415
Merge pull request #27955 from frappe/mergify/bp/version-13-hotfix/pr-27947
...
fix: Improve error message for Serial No mismatch between SI and DN (backport #27947 )
2021-10-14 14:24:54 +05:30
marination
d86f5ec1ba
fix: Remove trailing space and line break in translatable string
...
(cherry picked from commit 60f35ad8a2 )
2021-10-14 08:19:54 +00:00
marination
a568fc7924
fix: Improve error message for Serial No mismatch between SI and DN
...
(cherry picked from commit 646acb6b46 )
2021-10-14 08:19:53 +00:00
mergify[bot]
c040256793
fix: cannot add deductions in internal transfer payment entry (backport #27545 ) ( #27930 )
...
* fix: cannot add deductions in internal transfer payment entry
(cherry picked from commit 1b7414e948 )
# Conflicts:
# erpnext/accounts/doctype/payment_entry/payment_entry.py
* fix: Update message string
(cherry picked from commit 3b9514d6e1 )
# Conflicts:
# erpnext/accounts/doctype/payment_entry/payment_entry.py
* fix: conflicts
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com >
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-14 12:34:03 +05:30
Chillar Anand
29996ee726
fix(hr): Update expense account after company is updated ( #27843 ) ( #27919 )
...
(cherry picked from commit f0c4ea14a9 )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-14 11:13:00 +05:30
Deepesh Garg
1120506e11
Merge pull request #27941 from frappe/mergify/bp/version-13-hotfix/pr-27783
...
fix(Subscription): reorder updation of end date (backport #27783 )
2021-10-13 16:56:07 +05:30
mergify[bot]
e64751e3a2
fix: not authorized to update entries after freezing accounts (backport #27937 )
...
* fix: not authorized to update entries after freezing accounts (#27937 )
* fix: not authorized to update entries after freezing accounts
* fix: Add test case
* fix(patch): patched to requeue failed reposts(check_freezing_date)
* chore: misc fixes
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
(cherry picked from commit 2bb383b178 )
# Conflicts:
# erpnext/patches.txt
* fix: resolve conflict
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com >
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-13 16:41:21 +05:30
Himanshu
bf47c6836e
Update subscription.py
...
(cherry picked from commit 44306bd0e5 )
2021-10-13 09:52:21 +00:00
hrwx
e80192e2da
fix: create past invoices
...
(cherry picked from commit ae657c7e4e )
2021-10-13 09:52:21 +00:00
Sagar Vora
b2f1b02e34
test: use test_dependencies instead of duplication
...
(cherry picked from commit 656015d99d )
2021-10-13 09:52:20 +00:00
Sagar Vora
ed090f2e3e
fix: remove newline
...
(cherry picked from commit fc375c5bde )
2021-10-13 09:52:20 +00:00
hrwx
d796172249
fix: reorder updation of end date
...
(cherry picked from commit 0f03b19109 )
2021-10-13 09:52:20 +00:00
Deepesh Garg
ff9f6366ad
Merge pull request #27935 from frappe/mergify/bp/version-13-hotfix/pr-27907
...
feat: HSN based tax breakup table check in GST Settings (backport #27907 )
2021-10-13 12:56:00 +05:30
Deepesh Garg
b8683d5532
Merge pull request #27925 from frappe/mergify/bp/version-13-hotfix/pr-27758
...
perf: Add indexes in stock queries and speed up bin updation (backport #27758 )
2021-10-13 12:08:38 +05:30
Subin Tom
4a156cdc2e
added new section in gst settings page
...
(cherry picked from commit fc4facc5dc )
2021-10-13 06:38:27 +00:00
Subin Tom
771b076448
feat: HSN wise tax breakup check in GST Settings
...
(cherry picked from commit 530de12b07 )
2021-10-13 06:38:26 +00:00
mergify[bot]
e6346ac982
fix: minor ux fixes in Sales & Purchase Invoice (backport #27927 ) ( #27932 )
...
* fix: keeping sections consistent across sales & purchase invoice
(cherry picked from commit 2bc1ca993a )
* fix: set collapsible & print hide
(cherry picked from commit d181cc42a1 )
Co-authored-by: Anuja Pawar <anuja.pawar20@gmail.com >
2021-10-13 11:01:21 +05:30
Ankush Menat
547e173fe0
ci: rule to fail PRs that add a new manual commit ( #27928 )
...
Manual commits are frequent source of bugs, confusions or undefined
behaviour.
All new manual commits should be explcitly ignored with explanation on
why it's added. This will only fail for new additions. Existing ones
need to be cleaned up manually.
(cherry picked from commit 06b426e9c3 )
2021-10-12 23:05:09 +05:30
mergify[bot]
37bd0ecf87
fix: force reload custom field doctype ( #27909 ) ( #27910 )
...
custom_field.json has the same modified key in both versions but not the same content. This can happen again if something is backported, safe solution is to force reload.
(cherry picked from commit ad444153cc )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-12 20:38:09 +05:30
Marica
8244980d79
Merge pull request #27924 from marination/item-configure-empty-popup
...
fix: Item Variant selection empty popup on website
2021-10-12 20:32:18 +05:30
Deepesh Garg
10b239ec50
perf: Add indexes in stock queries and speed up bin updation #27758
...
perf: Add indexes in stock queries and speed up bin updation
(cherry picked from commit 6f107da165 )
2021-10-12 14:46:26 +00:00
marination
c9c4a9995b
fix: Item Variant selection empty popup on website
...
- pass item_code instead of website item name to fetch attributes
2021-10-12 19:56:12 +05:30
Ankush Menat
b6dc71679e
fix: remove transaction commit from tests
...
(cherry picked from commit 8d69ec72a6 )
2021-10-12 16:41:48 +05:30
Ankush Menat
5bdb6041b9
refactor: rollback after full test
...
(cherry picked from commit acdb26a4bb )
2021-10-12 16:41:48 +05:30
Ankush Menat
89828defc5
test: add custom TestCase class and use in stock
...
(cherry picked from commit 06fa35a9c1 )
2021-10-12 16:41:48 +05:30
Deepesh Garg
816236b587
Merge pull request #27918 from frappe/mergify/bp/version-13-hotfix/pr-27884
...
fix: patch fails if accounts are frozen (backport #27884 )
2021-10-12 15:04:01 +05:30
Deepesh Garg
69f17721ef
Merge pull request #27917 from frappe/mergify/bp/version-13-hotfix/pr-27896
...
fix: Status check for closed loans (backport #27896 )
2021-10-12 15:03:31 +05:30
Afshan
125bb1f99a
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-27884
2021-10-12 14:32:36 +05:30
mergify[bot]
6f786b42a9
fix: add cost center in gl entry for advance payment entry ( #27840 ) ( #27915 )
...
(cherry picked from commit 569dc5f6b1 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-12 14:31:50 +05:30
Saqib Ansari
fed80177de
fix: rollback on exception
...
(cherry picked from commit c103f72fad )
2021-10-12 08:15:17 +00:00
Saqib Ansari
2ce36d1edc
feat: handle exceptions
...
(cherry picked from commit 353ad5f6ff )
2021-10-12 08:15:17 +00:00
Saqib Ansari
7e44c30404
fix: patch fails if accounts are frozen
...
(cherry picked from commit b0aa4a6e1c )
2021-10-12 08:15:16 +00:00
Deepesh Garg
47ced6810f
fix: Linting issues
...
(cherry picked from commit af14ba43de )
2021-10-12 08:11:47 +00:00
Deepesh Garg
6c3f5687f2
fix: Incorrect maximum loan amount update
...
(cherry picked from commit 8355af6dcf )
2021-10-12 08:11:47 +00:00
Deepesh Garg
1b632b683f
fix: Status check for closed loans
...
(cherry picked from commit 3337ae120c )
2021-10-12 08:11:46 +00:00
mergify[bot]
c5660e8511
Merge pull request #27906 from Anuja-pawar/accounts-settings ( #27912 )
...
fix(Accounts Settings): Update label
(cherry picked from commit e1967870a9 )
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com >
2021-10-12 12:23:53 +05:30
mergify[bot]
c4338d184e
fix(accounts): Fix issue with fetching loyalty point entries ( #27892 ) ( #27913 )
...
(cherry picked from commit 401e22fb8d )
Co-authored-by: Chillar Anand <chillar@avilpage.com >
2021-10-12 12:23:32 +05:30
Noah Jacob
d598a61556
Merge pull request #27901 from frappe/mergify/bp/version-13-hotfix/pr-27800
...
refactor: updated buying onboarding tours. (backport #27800 )
2021-10-11 16:33:59 +05:30
Noah Jacob
d262d0ac27
refactor: updated onboarding cards and tours
...
(cherry picked from commit f5e0cad6a1 )
2021-10-11 10:04:40 +00:00
mergify[bot]
7dc2f95932
fix: v12 migrate error - unknown column ‘mandatory_depends_on’ (backport #27897 ) ( #27900 )
...
* fix: v12 migrate error - unknown column ‘mandatory_depends_on’ (#27897 )
* fix: v12 doesn't have mandatory_depends_on field
* fix: move update_vehicle_no_reqd_condition to v13
* fix: move update_vehicle_no_reqd_condition to v13
* fix: file name missing .py
* refactor!: add back empty line
* fix: linters issue
(cherry picked from commit 7acdcc70ad )
# Conflicts:
# erpnext/patches.txt
* fix: resolve conflicts
Co-authored-by: Dany Robert <rtdany10@gmail.com >
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-11 10:02:31 +00:00
rohitwaghchaure
cf87c9138e
Merge pull request #27898 from frappe/mergify/bp/version-13-hotfix/pr-27863
...
fix: consolidated report not consider company currency (backport #27863 )
2021-10-11 14:07:51 +05:30
Rohit Waghchaure
1a42f82d14
fix: opening balance to calculate 'Unclosed Fiscal Years Profit / Loss (Credit)'
...
(cherry picked from commit 19d14da0d4 )
2021-10-11 08:37:27 +00:00
Rohit Waghchaure
2c5a0bff47
fix: consolidated report not consider company currency
...
(cherry picked from commit dc4206428d )
2021-10-11 08:37:26 +00:00
mergify[bot]
a831e6b552
fix: bom item query (backport #27890 ) ( #27894 )
...
* fix: bom item query #27890
fix: bom item query
(cherry picked from commit 0a3dd3e954 )
# Conflicts:
# erpnext/manufacturing/doctype/bom/test_bom.py
* fix: resolve conflict
* chore: unused imports
[skip ci]
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-11 12:45:24 +05:30