ruthra kumar
b15ec238c9
Merge pull request #42151 from frappe/mergify/bp/version-15-hotfix/pr-42073
...
fix: always post to tax account heads if LCV is booked (backport #42073 )
2024-07-03 07:23:08 +05:30
ruthra kumar
09c39face8
Merge pull request #42140 from nabinhait/provisional_entry_fix3
...
fix: provisional entry for non stock items
2024-07-03 07:20:56 +05:30
ruthra kumar
c3cc363648
refactor(test): fix flaky test
...
(cherry picked from commit 0e256b8b29 )
2024-07-03 01:35:15 +00:00
ruthra kumar
e55fd7204a
refactor(test): cleanup test data
...
(cherry picked from commit 6ba6b5aa33 )
2024-07-03 01:35:15 +00:00
ruthra kumar
b7cbafae14
test: Repost should not merge expense accounts from LCV
...
(cherry picked from commit fa56555150 )
2024-07-03 01:35:15 +00:00
ruthra kumar
706a6c1ad7
fix: always post to tax account heads if LCV is booked
...
(cherry picked from commit 0fcd5d5130 )
2024-07-03 01:35:15 +00:00
Khushi Rawat
28e8bb7085
Merge pull request #42130 from frappe/mergify/bp/version-15-hotfix/pr-42105
...
fix: add auto-update for overdue status (backport #42105 )
2024-07-02 23:17:04 +05:30
Khushi Rawat
8b3ffc9949
Merge pull request #42145 from frappe/mergify/bp/version-15-hotfix/pr-42144
...
fix: handle none type object error (backport #42144 )
2024-07-02 16:54:36 +05:30
Khushi Rawat
b0aef9e42b
fix: handle none type object error
...
(cherry picked from commit 6760c9c4e2 )
2024-07-02 11:08:42 +00:00
Nabin Hait
d61dab8569
fix: provisional entry for non stock items
2024-07-02 16:10:03 +05:30
mergify[bot]
a45f8ca5fd
fix: batch picking in pick list based on Stock Settings (backport #42021 ) ( #42134 )
...
fix: batch picking in pick list based on Stock Settings (#42021 )
(cherry picked from commit 97c9941143 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-02 10:51:06 +05:30
mergify[bot]
d9e62fef21
fix: stock qty validation in SCR (backport #42124 ) ( #42133 )
...
fix: stock qty validation in SCR (#42124 )
(cherry picked from commit 99f2735ad3 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-01 19:12:58 +05:30
mergify[bot]
3b4d39766f
fix: this.frm.events.update_cost is not a function (backport #41960 ) ( #41965 )
...
* fix: this.frm.events.update_cost is not a function (#41960 )
(cherry picked from commit d5ed4582c3 )
# Conflicts:
# erpnext/manufacturing/doctype/workstation/workstation.json
# erpnext/manufacturing/doctype/workstation/workstation.py
* chore: fix conflicts
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-01 18:18:58 +05:30
ruthra kumar
61c0ce6ca8
Merge pull request #42132 from frappe/mergify/bp/version-15-hotfix/pr-42126
...
fix: Re-open allows SO's to be over credit limit (backport #42126 )
2024-07-01 17:21:19 +05:30
ruthra kumar
bff99d89b9
chore: resolve conflict
2024-07-01 17:05:22 +05:30
ruthra kumar
b63eab8cbb
test: credit check on Sales Order re-open
...
(cherry picked from commit 60694e09c4 )
# Conflicts:
# erpnext/selling/doctype/sales_order/test_sales_order.py
2024-07-01 11:33:36 +00:00
ruthra kumar
7fcb0f578a
fix: Re-open allows SO's to be over credit limit
...
(cherry picked from commit 5eed781263 )
2024-07-01 11:33:36 +00:00
Khushi Rawat
317cc0358c
fix: add auto-update for overdue status ( #42105 )
...
* fix: auto-update for overdue status
* chore: use qb.update
(cherry picked from commit c5e474f4f5 )
2024-07-01 11:27:02 +00:00
mergify[bot]
58e18e2b1f
fix: resolve gl entries duplication in asset purchase workflow (backport #41845 ) ( #42120 )
...
* fix: resolve gl entries duplication in asset purchase workflow (#41845 )
* fix: resolve gl entries duplication in asset purchase workflow
* fix: prevent duplicate entry when creating purchase receipt from purchase invoice
* chore: test case added
* fix: fixed missing asset category issue
(cherry picked from commit 55a4bd469b )
* fix: use f-string instead of format call
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-07-01 16:54:14 +05:30
mergify[bot]
97c49b93b6
fix: refactor Asset Repair and Stock Entry linkage to resolve amendme… (backport #41919 ) ( #42058 )
...
* fix: refactor Asset Repair and Stock Entry linkage to resolve amendme… (#41919 )
* fix: refactor Asset Repair and Stock Entry linkage to resolve amendment issues
* chore: added missing patch to patches.txt
* chore: fixing previous changes
* chore: fixing minor issues
* fix: code changes to enhance efficiency
* chore: replaced frappe.qb with db.sql because of conflict
* fix: minor changes
(cherry picked from commit ba79e68190 )
# Conflicts:
# erpnext/assets/doctype/asset_repair/asset_repair.json
# erpnext/assets/doctype/asset_repair_consumed_item/asset_repair_consumed_item.json
# erpnext/patches.txt
# erpnext/stock/doctype/stock_entry/stock_entry.json
* chore: fixed conflicts
* fix: removed unmerged patches
* fix: use f-string instead of format call
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-07-01 16:53:29 +05:30
mergify[bot]
c3f5a494f3
fix: batch reset while making SABB (backport #42076 ) ( #42123 )
...
fix: batch reset while making SABB (#42076 )
(cherry picked from commit 8f424528dd )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-01 15:12:36 +05:30
mergify[bot]
a0e06a4ba5
fix: timeout error while submitting JV (backport #42040 ) ( #42099 )
...
* fix: timeout error while submitting JV (#42040 )
(cherry picked from commit 32bdcdb08f )
# Conflicts:
# erpnext/accounts/doctype/account/account.json
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
# erpnext/accounts/utils.py
# erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.json
* chore: fix conflicts
* chore: fix conflicts
* chore: fix conflicts
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-01 14:15:13 +05:30
ruthra kumar
deaeb103d5
Merge pull request #42106 from frappe/mergify/bp/version-15-hotfix/pr-42029
...
fix: incorrect ledger entries on Advance payment against Journals for customer (backport #42029 )
2024-06-30 05:55:54 +05:30
ruthra kumar
3c58e0af50
refactor: handle purchase invoice as reference
...
(cherry picked from commit 9ec6aef95d )
2024-06-30 00:08:42 +00:00
ruthra kumar
cb703ff17c
chore: better test name
...
(cherry picked from commit ad7efd5939 )
2024-06-30 00:08:41 +00:00
ruthra kumar
6a0111c7db
test: advance payment entry against journal - supplier type
...
(cherry picked from commit 1b384b9942 )
2024-06-30 00:08:41 +00:00
ruthra kumar
e00348fd52
test: advance payment against journal entry - customer type
...
(cherry picked from commit 5e84272cf9 )
2024-06-30 00:08:41 +00:00
ruthra kumar
4e74257ba9
fix: incorrect dr/cr on Adv Payment against Journals
...
(cherry picked from commit f6c1dffb35 )
2024-06-30 00:08:41 +00:00
mergify[bot]
760b2e24f2
fix: expense account from item group not fetched (backport #41957 ) ( #41962 )
...
fix: expense account from item group not fetched
(cherry picked from commit 86ebe58231 )
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com >
2024-06-29 10:59:57 +05:30
mergify[bot]
1f3374fcdf
fix: reposting file attachment permission issue (backport #42068 ) ( #42075 )
...
* fix: reposting file attachment permission issue (#42068 )
(cherry picked from commit 03e674e21d )
# Conflicts:
# erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.json
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-29 07:32:45 +05:30
mergify[bot]
d396c18689
perf: Performance optmization for Purchase Invoice submission (backport #40263 ) ( #41946 )
...
* perf: Optimization for providional gl entries
(cherry picked from commit d7b738ff61 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
* perf: Performance optimization for validating budget
(cherry picked from commit f204d810bb )
# Conflicts:
# erpnext/accounts/doctype/budget/budget.py
* perf: Cached accounting dimensions details
(cherry picked from commit 8cd8b8f885 )
* perf: Optimzed code for merging similar gl entries
(cherry picked from commit aa75a60142 )
* fix: linter issues
(cherry picked from commit acc0b2faf8 )
* perf: Cache accounting dimension filter map
(cherry picked from commit e4bd173875 )
# Conflicts:
# erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.py
* fix: minor fixes
(cherry picked from commit 5cd9bf3bda )
* perf: skip unnecessary validation while transaction cancellation
(cherry picked from commit 05385e4acb )
* perf: refactored handling provisional gl entries for non-stock items
(cherry picked from commit 49c74369a5 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
* perf: validate expense against budget only if budget exists
(cherry picked from commit c15b2d5490 )
* perf: Get bin details only for stock items
(cherry picked from commit 6ff9e6ee84 )
# Conflicts:
# erpnext/stock/get_item_details.py
* fix: added index for price_list column in Item Price
(cherry picked from commit d279e23623 )
# Conflicts:
# erpnext/stock/doctype/item_price/item_price.json
* perf: Caching in checking allowance for qty and amount
(cherry picked from commit 8d682fa884 )
* perf: Caching in gl entry
(cherry picked from commit b07769d8d7 )
# Conflicts:
# erpnext/accounts/doctype/gl_entry/gl_entry.py
* chore: resolve conflicts
* chore: resolve conflict in purchase_invoice.py
---------
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2024-06-27 17:32:43 +05:30
mergify[bot]
8a91bf3154
fix: not able to make purchase return (backport #42053 ) ( #42055 )
...
fix: not able to make purchase return (#42053 )
(cherry picked from commit 9738c04ef0 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-27 16:31:06 +05:30
mergify[bot]
482832f3c2
fix: unhide serial no field (backport #42045 ) ( #42047 )
...
* fix: unhide serial no field (#42045 )
(cherry picked from commit 80c6981cfa )
# Conflicts:
# erpnext/assets/doctype/asset_capitalization_stock_item/asset_capitalization_stock_item.json
* fix: resolved conflicts
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 18:01:33 +05:30
mergify[bot]
3536a754ff
fix: lead status filter (backport #41816 ) ( #42046 )
...
fix: lead status filter (#41816 )
(cherry picked from commit 8ae2b8ff8c )
Co-authored-by: Nihantra C. Patel <141945075+Nihantra-Patel@users.noreply.github.com >
2024-06-26 17:47:30 +05:30
mergify[bot]
b29435744f
chore: patch to enable total number of booked depreciations field (backport #41940 ) ( #42042 )
...
* chore: patch to enable total number of booked depreciations field (#41940 )
* chore: patch to enable total number of booked depreciations field
* fix: conflict resolved
* refactor: replaced fb_row.db_set with set_value
(cherry picked from commit 5fdd1d3278 )
# Conflicts:
# erpnext/patches.txt
* fix: resolved conflicts
* fix: removed unmerged patches
---------
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 17:43:57 +05:30
mergify[bot]
cf4d4ba3e9
fix: incorrect time period in asset depreciation schedule (backport #41805 ) ( #42043 )
...
fix: incorrect time period in asset depreciation schedule (#41805 )
* fix(wip): depreciation calculation for existing asset
* fix(wip): added validation for incorrect depreciation period
* fix: depreciation schedule time period issue for existing asset
* chore: run pre-commit checks and apply fixes
* style: apply formatting changes
* style: made some necessary changes
* chore: modified test
(cherry picked from commit 625f16dee0 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 16:51:16 +05:30
mergify[bot]
c27f272f06
perf: code optimization to handle large asset creation (backport #42018 ) ( #42025 )
...
perf: code optimization to handle large asset creation (#42018 )
(cherry picked from commit 5738d93f95 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 16:51:07 +05:30
mergify[bot]
63b26e679b
feat: Turkish Chart Of Accounts (backport #41756 ) ( #42028 )
...
* feat: Create Turkish Chart Of Accounts
(cherry picked from commit 5c8ea86a3f )
* feat: Create Turkish Chart Of Accounts
(cherry picked from commit b401ba2c26 )
---------
Co-authored-by: fzozyurt <fzozyurt@outlook.com >
2024-06-26 16:50:41 +05:30
mergify[bot]
f2feeaf264
fix: fixed asset value in Fixed Asset Register (backport #41930 ) ( #42027 )
...
fix: fixed asset value in Fixed Asset Register (#41930 )
(cherry picked from commit 1c643a0ead )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 16:49:55 +05:30
mergify[bot]
a981633d94
fix: manufacturing date issue in the batch (backport #42034 ) ( #42037 )
...
* fix: manufacturing date issue in the batch (#42034 )
(cherry picked from commit eca3e02f8d )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-26 13:00:36 +05:30
mergify[bot]
e278fc683f
fix: Stock Reservation Entry was not getting created (backport #42033 ) ( #42035 )
...
fix: Stock Reservation Entry was not getting created (#42033 )
(cherry picked from commit 1a9899b32b )
Co-authored-by: Poorvi-R-Bhat <poorvi.r.bhat@gmail.com >
2024-06-26 09:11:01 +05:30
mergify[bot]
068de08bbb
fix: timeout while cancelling LCV (backport #42030 ) (backport #42031 ) ( #42032 )
...
fix: timeout while cancelling LCV (backport #42030 ) (#42031 )
fix: timeout while cancelling LCV (#42030 )
fix: timeout while canelling LCV
(cherry picked from commit 21bf7fd1f8 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
(cherry picked from commit 2e76b9f9db )
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2024-06-25 18:42:43 +05:30
mergify[bot]
f6be19cb7c
fix: valuation rate for the legacy batches (backport #42011 ) ( #42020 )
...
fix: valuation rate for the legacy batches (#42011 )
(cherry picked from commit 9ab333d105 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-25 13:07:03 +05:30
mergify[bot]
838cc5b72a
fix: incorrect Difference Amount (backport #42008 ) ( #42013 )
...
fix: incorrect Difference Amount (#42008 )
(cherry picked from commit 7d91c6cbd5 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-24 17:04:24 +05:30
mergify[bot]
68b318a94b
fix: Wrong Delete Batch on Purchase Receipt (backport #42007 ) ( #42012 )
...
fix: Wrong Delete Batch on Purchase Receipt (#42007 )
(cherry picked from commit d50487ce53 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-24 17:04:13 +05:30
Deepesh Garg
6a0ab23c87
Merge pull request #42006 from frappe/mergify/bp/version-15-hotfix/pr-41751
...
feat: accounting dimension filters in gp report (#41751 )
2024-06-24 11:24:24 +05:30
Dany Robert
068ae87b8d
feat(gp): group by cost center
...
(cherry picked from commit e26bc17c75 )
2024-06-24 05:22:39 +00:00
Dany Robert
fe9dffb271
feat: accounting dimension filters in gp report
...
(cherry picked from commit d165638bbb )
2024-06-24 05:22:39 +00:00
ruthra kumar
521cfb3d4e
Merge pull request #41998 from frappe/mergify/bp/version-15-hotfix/pr-41976
...
fix: pricing rule with and without 'apply multiple' and priority (backport #41976 )
2024-06-23 05:49:07 +05:30
ruthra kumar
bc6cbb2656
Merge pull request #41997 from frappe/mergify/bp/version-15-hotfix/pr-41844
...
refactor: allow foreign currency advance accounts (backport #41844 )
2024-06-23 05:43:10 +05:30