CalvinBackup/facefusion
1
0
Fork 0
mirror of https://github.com/facefusion/facefusion.git synced 2026-07-27 12:30:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

remove todos that were never needed

Browse Source
This commit is contained in:
henryruhs
2026-07-24 07:53:00 +02:00
parent be77bd6572
commit 3602f69207
4 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
facefusion/choices.py
-1
View File
@@ -83,7 +83,6 @@ audio_formats : List[AudioFormat] = list(get_args(AudioFormat))
image_formats : List[ImageFormat] = list(get_args(ImageFormat))
video_formats : List[VideoFormat] = list(get_args(VideoFormat))
temp_frame_formats : List[TempFrameFormat] = list(get_args(TempFrameFormat))
#todo: needs review - [config] [critical: low] temp pixel format choices for the stream pipe
temp_pixel_formats : List[TempPixelFormat] = list(get_args(TempPixelFormat))
output_audio_encoders : List[AudioEncoder] = list(get_args(AudioEncoder))
facefusion/program.py
-1
View File
@@ -178,7 +178,6 @@ def create_frame_extraction_program() -> ArgumentParser:
group_frame_extraction.add_argument('--trim-frame-start', help = translator.get('help.trim_frame_start'), type = int, default = facefusion.config.get_int_value('frame_extraction', 'trim_frame_start'))
group_frame_extraction.add_argument('--trim-frame-end', help = translator.get('help.trim_frame_end'), type = int, default = facefusion.config.get_int_value('frame_extraction', 'trim_frame_end'))
group_frame_extraction.add_argument('--temp-frame-format', help = translator.get('help.temp_frame_format'), default = config.get_str_value('frame_extraction', 'temp_frame_format', 'png'), choices = facefusion.choices.temp_frame_formats)
#todo: needs review - [streaming] [critical: low] new temp pixel format option, bgra enables alpha through the stream pipe
group_frame_extraction.add_argument('--temp-pixel-format', help = translator.get('help.temp_pixel_format'), default = config.get_str_value('frame_extraction', 'temp_pixel_format', 'bgr24'), choices = facefusion.choices.temp_pixel_formats)
job_store.register_step_keys([ 'trim_frame_start', 'trim_frame_end', 'temp_frame_format', 'temp_pixel_format' ])
return program
facefusion/workflows/image_to_video.py
-1
View File
@@ -34,7 +34,6 @@ def process(start_time : float) -> ErrorCode:
merge_frames
])
#todo: needs review - [workflow] [critical: medium] stream appends its single task, disk keeps extract process merge
if state_manager.get_item('workflow_strategy') == 'stream':
tasks.append(process_stream_frames)
tests/test_ffmpeg_builder.py
+1 -5
View File
@@ -41,15 +41,11 @@ def test_set_stream_mode() -> None:
assert set_stream_mode('v4l2') == [ '-f', 'v4l2' ]
#todo: needs review - [testing] question if the assertions are good
#todo: run mutation testing, strip down to the minimum, test with real data
def test_set_input_seek() -> None:
assert set_input_seek(0.0) == [ '-ss', '0.0' ]
assert set_input_seek(4.2) == [ '-ss', '4.2' ]
assert set_input_seek(1.5) == [ '-ss', '1.5' ]
#todo: needs review - [testing] question if the assertions are good
#todo: run mutation testing, strip down to the minimum, test with real data
def test_set_output_format() -> None:
assert set_output_format('rawvideo') == [ '-f', 'rawvideo' ]