mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-02 11:45:20 +02:00
feat: anti-skip rule for all review skills
Review skills sometimes skip sections when reviewing strategy or spec plans. This adds an explicit anti-skip rule to CEO (1-11), eng (1-4), design (1-7), and DX (1-8) review skills. Also fixes CEO header from "10 sections" to "11 sections" to match actual count.
This commit is contained in:
@@ -1042,7 +1042,9 @@ After mode is selected, confirm which implementation approach (from 0C-bis) appl
|
||||
Once selected, commit fully. Do not silently drift.
|
||||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY. If no issues or fix is obvious, state what you'll do and move on — don't waste a question. Do NOT proceed until user responds.
|
||||
|
||||
## Review Sections (10 sections, after scope and mode are agreed)
|
||||
## Review Sections (11 sections, after scope and mode are agreed)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review section (1-11) regardless of plan type (strategy, spec, code, infra). Every section in this skill exists for a reason. "This is a strategy doc so implementation sections don't apply" is always wrong — implementation details are where strategy breaks down. If a section genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
### Section 1: Architecture Review
|
||||
Evaluate and diagram:
|
||||
|
||||
@@ -353,7 +353,9 @@ After mode is selected, confirm which implementation approach (from 0C-bis) appl
|
||||
Once selected, commit fully. Do not silently drift.
|
||||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY. If no issues or fix is obvious, state what you'll do and move on — don't waste a question. Do NOT proceed until user responds.
|
||||
|
||||
## Review Sections (10 sections, after scope and mode are agreed)
|
||||
## Review Sections (11 sections, after scope and mode are agreed)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review section (1-11) regardless of plan type (strategy, spec, code, infra). Every section in this skill exists for a reason. "This is a strategy doc so implementation sections don't apply" is always wrong — implementation details are where strategy breaks down. If a section genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
### Section 1: Architecture Review
|
||||
Evaluate and diagram:
|
||||
|
||||
@@ -1023,6 +1023,8 @@ descriptions of what 10/10 looks like.
|
||||
|
||||
## Review Sections (7 passes, after scope is agreed)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review pass (1-7) regardless of plan type (strategy, spec, code, infra). Every pass in this skill exists for a reason. "This is a strategy doc so design passes don't apply" is always wrong — design gaps are where implementation breaks down. If a pass genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
## Prior Learnings
|
||||
|
||||
Search for relevant learnings from previous sessions:
|
||||
|
||||
@@ -256,6 +256,8 @@ descriptions of what 10/10 looks like.
|
||||
|
||||
## Review Sections (7 passes, after scope is agreed)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review pass (1-7) regardless of plan type (strategy, spec, code, infra). Every pass in this skill exists for a reason. "This is a strategy doc so design passes don't apply" is always wrong — design gaps are where implementation breaks down. If a pass genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
{{LEARNINGS_SEARCH}}
|
||||
|
||||
### Pass 1: Information Architecture
|
||||
|
||||
@@ -1079,6 +1079,8 @@ Pattern:
|
||||
|
||||
## Review Sections (8 passes, after Step 0 is complete)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review pass (1-8) regardless of plan type (strategy, spec, code, infra). Every pass in this skill exists for a reason. "This is a strategy doc so DX passes don't apply" is always wrong — DX gaps are where adoption breaks down. If a pass genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
## Prior Learnings
|
||||
|
||||
Search for relevant learnings from previous sessions:
|
||||
|
||||
@@ -442,6 +442,8 @@ Pattern:
|
||||
|
||||
## Review Sections (8 passes, after Step 0 is complete)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review pass (1-8) regardless of plan type (strategy, spec, code, infra). Every pass in this skill exists for a reason. "This is a strategy doc so DX passes don't apply" is always wrong — DX gaps are where adoption breaks down. If a pass genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
{{LEARNINGS_SEARCH}}
|
||||
|
||||
### DX Trend Check
|
||||
|
||||
@@ -649,6 +649,8 @@ Always work through the full interactive review: one section at a time (Architec
|
||||
|
||||
## Review Sections (after scope is agreed)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review section (1-4) regardless of plan type (strategy, spec, code, infra). Every section in this skill exists for a reason. "This is a strategy doc so implementation sections don't apply" is always wrong — implementation details are where strategy breaks down. If a section genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
## Prior Learnings
|
||||
|
||||
Search for relevant learnings from previous sessions:
|
||||
|
||||
@@ -114,6 +114,8 @@ Always work through the full interactive review: one section at a time (Architec
|
||||
|
||||
## Review Sections (after scope is agreed)
|
||||
|
||||
**Anti-skip rule:** Never condense, abbreviate, or skip any review section (1-4) regardless of plan type (strategy, spec, code, infra). Every section in this skill exists for a reason. "This is a strategy doc so implementation sections don't apply" is always wrong — implementation details are where strategy breaks down. If a section genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||||
|
||||
{{LEARNINGS_SEARCH}}
|
||||
|
||||
### 1. Architecture review
|
||||
|
||||
Reference in New Issue
Block a user