mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-01 14:34:42 +01:00
plan-design-review: mockup default and retrospective at normal volume (s05 M1, s05 M3, s05 M4)
- M1: 'YOUR PRIMARY TOOL' / 'The rule is simple ... Don't ask permission ... Mockups ARE the plan' -> generate mockups without asking when the plan has UI and the designer is available, with the reason; skip only under the Step 0.5 conditions (which include the user's opt-out). - M3: 'be MORE aggressive' on previously flagged areas -> check whether the earlier issue recurs or was only partly fixed and say so. - M4: drop the unverifiable 'Tier 2+ (15+ RPM)' rate-tier aside; keep the one-at-a-time rule and the /design-shotgun pointer. (s05 M2 landed with s04 F1.) No test pins the removed text; the remaining failing case is the plan-scope-selection PTY case that fails under Bun 1.3.14 and passes under Bun 1.4.0. expected red until the regeneration commit
This commit is contained in:
1 parent
8e9641c65f
commit
0efb06d24f
1 file changed
+8
-13
@@ -74,17 +74,14 @@ or raise their scores before their individual approvals.
|
||||
Do NOT make any code changes. Do NOT start implementation. Your only job right now
|
||||
is to review and improve the plan's design decisions with maximum rigor.
|
||||
|
||||
### The gstack designer — YOUR PRIMARY TOOL
|
||||
### The gstack designer
|
||||
|
||||
Use the **gstack designer** by default to turn design briefs into real visual mockups.
|
||||
|
||||
**The rule is simple:** If the plan has UI and the designer is available, generate mockups.
|
||||
Don't ask permission. Don't write text descriptions of what a homepage "could look like."
|
||||
Show it. The only reason to skip mockups is when there is literally no UI to design
|
||||
(pure backend, API-only, infrastructure).
|
||||
|
||||
Design reviews without visuals are just opinion. Mockups ARE the plan for design work.
|
||||
You need to see the design before you code it.
|
||||
When the plan has UI and the designer is available, generate mockups without asking
|
||||
first: the user and implementer need to see the design before it is coded, and a text
|
||||
description of what a screen "could look like" doesn't settle the decision. Skip them
|
||||
only under the Step 0.5 conditions (no UI scope, designer unavailable, or the user asks).
|
||||
|
||||
Commands: `generate` (single mockup), `variants` (multiple directions), `compare`
|
||||
(side-by-side review board), `iterate` (refine with feedback), `check` (cross-model
|
||||
@@ -159,7 +156,7 @@ Map:
|
||||
* What prior design reviews exist? (check reviews.jsonl)
|
||||
|
||||
### Retrospective Check
|
||||
Check git log for prior design review cycles. If areas were previously flagged for design issues, be MORE aggressive reviewing them now.
|
||||
Check git log for prior design review cycles. For areas flagged before, check whether the earlier issue recurs or was only partly fixed, and say so in that pass.
|
||||
|
||||
### UI Scope Detection
|
||||
Analyze the plan. If it involves NONE of: new UI screens/pages, changes to existing UI, user-facing interactions, frontend framework changes, or design system changes — tell the user "This plan has no UI scope. A design review isn't applicable." and exit early. Don't force design review on a backend change.
|
||||
@@ -236,10 +233,8 @@ echo "DESIGN_DIR: $_DESIGN_DIR"
|
||||
|
||||
Replace `<screen-name>` with a descriptive kebab-case name (e.g., `homepage-variants`, `settings-page`, `onboarding-flow`).
|
||||
|
||||
**Generate mockups ONE AT A TIME in this skill.** The inline review flow generates
|
||||
fewer variants and benefits from sequential control. Note: /design-shotgun uses
|
||||
parallel Agent subagents for variant generation, which works at Tier 2+ (15+ RPM).
|
||||
The sequential constraint here is specific to plan-design-review's inline pattern.
|
||||
**Generate mockups one screen at a time in this skill.** The inline review flow generates
|
||||
fewer variants and benefits from sequential control; /design-shotgun is the parallel flow.
|
||||
|
||||
For each UI screen/section in scope, construct a design brief from the plan's description (and DESIGN.md if present) and generate variants:
|
||||
|
||||
|
||||
Reference in new issue
Block a user