mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-02 17:40:02 +02:00
test(design): revert the three-Edit plan-mode flow
A focused paid run still timed out at 300 s: the first three passes alone took 150 s of thinking. The case stays a named timeout red rather than cutting review depth.
This commit is contained in:
1 parent
a111225e78
commit
12ab3b3c54
2 files changed
+5
-6
No files matched your search
@@ -89,7 +89,7 @@ async function exercise(mode: 'success' | 'max-turns' | 'first-timeout' | 'secon
|
||||
expect(opts.signal.aborted).toBe(false);
|
||||
// Bind the complete actual compact-delivery prompt, not selected snippets.
|
||||
expect(new Bun.CryptoHasher('sha256').update(opts.prompt).digest('hex'))
|
||||
.toBe('7f2dbb6b2671588e7fbc83cfecc2869c59c388b45b627ac9d481c4d917d1e76f');
|
||||
.toBe('2fa957ab9d56850a1629a845d6fe0ee5a1cb7c0843ab6555b621971d270604cb');
|
||||
expect(opts.testName).toBe(id); expect(opts.maxTurns).toBe(15); expect(opts.timeout).toBe(CAPTURE_MS);
|
||||
for (const key of ['model', 'tools', 'allowedTools', 'appendSystemPrompt', 'env']) expect(opts).not.toHaveProperty(key);
|
||||
expect(opts.prompt).toContain('Review the plan in ./plan.md');
|
||||
@@ -98,8 +98,7 @@ async function exercise(mode: 'success' | 'max-turns' | 'first-timeout' | 'secon
|
||||
expect(opts.prompt).toContain('preserve the unresolved-decisions pass');
|
||||
expect(opts.prompt).toContain('interaction state table, empty states, responsive behavior');
|
||||
expect(opts.prompt).toContain('full required review report');
|
||||
expect(opts.prompt).toContain('(or one Write) before publishing a completed walkthrough');
|
||||
expect(opts.prompt).toContain('Save as you go in three Edits: after passes 1-3, apply their decisions to plan.md');
|
||||
expect(opts.prompt).toContain('Write before publishing a completed walkthrough');
|
||||
expect(opts.prompt).toContain('Read plan.md back to verify the saved changes');
|
||||
expect(opts.prompt).toContain('Then return a brief, concrete summary');
|
||||
expect(opts.prompt).toContain('execute every required pass and lazy-section Read');
|
||||
@@ -110,7 +109,7 @@ async function exercise(mode: 'success' | 'max-turns' | 'first-timeout' | 'secon
|
||||
expect(opts.prompt).toContain('concise score rationales and 10/10 explanations');
|
||||
const ordered = ['Read every lazy section', 'Review all 7 design passes',
|
||||
'EDIT plan.md', 'Keep the saved review compact',
|
||||
'Persist that complete plan and review with those Edits', 'Read plan.md back',
|
||||
'Persist that complete plan and review with Write', 'Read plan.md back',
|
||||
'Then return a brief, concrete summary'].map(text => opts.prompt.indexOf(text));
|
||||
expect(ordered.every(index => index >= 0)).toBe(true);
|
||||
expect(ordered).toEqual([...ordered].sort((a, b) => a - b));
|
||||
|
||||
@@ -462,8 +462,8 @@ Review the plan in ./plan.md. Its design gaps are vague "clean, modern UI" and "
|
||||
|
||||
Use this non-interactive delivery sequence:
|
||||
1. Skip the preamble bash block and any AskUserQuestion calls. Read every lazy section the workflow requires. Review all 7 design passes. Rate each scored design dimension 0-10 and explain what would make it a 10; preserve the unresolved-decisions pass and every required design decision.
|
||||
2. EDIT plan.md with the missing design decisions (interaction state table, empty states, responsive behavior, etc.) and the full required review report. Save as you go in three Edits: after passes 1-3, apply their decisions to plan.md; after passes 4-7, apply theirs; then add the review report. Keep the saved review compact: use the canonical tables and decision IDs. Specify each design requirement once; refer to its section or decision ID from other pass rationales, tasks, and report cells instead of repeating that specification. Give concise score rationales and 10/10 explanations. Retain all required report fields, design decisions, diagrams, ratings, and explanations.
|
||||
3. Persist that complete plan and review with those Edits (or one Write) before publishing a completed walkthrough or saying a fix is applied. Read plan.md back to verify the saved changes.
|
||||
2. EDIT plan.md with the missing design decisions (interaction state table, empty states, responsive behavior, etc.) and the full required review report. Keep the saved review compact: use the canonical tables and decision IDs. Specify each design requirement once; refer to its section or decision ID from other pass rationales, tasks, and report cells instead of repeating that specification. Give concise score rationales and 10/10 explanations. Retain all required report fields, design decisions, diagrams, ratings, and explanations.
|
||||
3. Persist that complete plan and review with Write before publishing a completed walkthrough or saying a fix is applied. Read plan.md back to verify the saved changes.
|
||||
4. Then return a brief, concrete summary of the design changes; do not repeat the full review in the response. This changes presentation only: execute every required pass and lazy-section Read.
|
||||
|
||||
IMPORTANT: Do NOT try to browse any URLs or use a browse binary. This is a plan review, not a live site audit.`,
|
||||
|
||||
Reference in new issue
Block a user