CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-06-17 15:20:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: drop GSTACK REVIEW REPORT contract from --disallowedTools migrations

Browse Source 
The plan-ceo / plan-design --disallowedTools migrated tests called
assertReportAtBottomIfPlanWritten as the final assertion, but that
contract is for full multi-section review completions. Under
--disallowedTools AskUserQuestion the model can't run the full
review (no AUQ tools to ask findings questions through), so it exits
at Step 0 with either prose-AUQ rendering or the legacy decisions
fallback. A plan file written in that mode WON'T have a GSTACK
REVIEW REPORT section — the workflow never reached the report-writing
step.

The contract is still enforced by the periodic finding-count tests
(skill-e2e-plan-{ceo,eng,design,devex}-finding-count.test.ts), which
DO run the full review end-to-end and assert report-at-bottom there.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-05-08 22:21:08 -07:00
parent af5f066186
commit 1993e0ea0c
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/skill-e2e-plan-ceo-plan-mode.test.ts
+7 -1
View File
@@ -152,6 +152,12 @@ describeE2E('plan-ceo-review plan-mode smoke (gate)', () => {
}
}
expect(['asked', 'plan_ready', 'exited']).toContain(obs.outcome);
assertReportAtBottomIfPlanWritten(obs);
// NOTE: assertReportAtBottomIfPlanWritten is intentionally NOT called
// here. This test runs --disallowedTools AskUserQuestion and only
// checks "did the question surface" — the model can't run the full
// multi-section review without AUQ tools, so no review report exists
// to enforce the at-bottom contract against. The contract is
// exercised by the periodic finding-count tests, which DO run the
// full review.
}, 360_000);
});
test/skill-e2e-plan-design-plan-mode.test.ts
+4 -1
View File
@@ -85,6 +85,9 @@ describeE2E('plan-design-review plan-mode smoke (gate)', () => {
);
}
expect(['asked', 'plan_ready', 'exited']).toContain(obs.outcome);
assertReportAtBottomIfPlanWritten(obs);
// NOTE: assertReportAtBottomIfPlanWritten intentionally not called —
// see skill-e2e-plan-ceo-plan-mode test 2 for the full rationale. Under
// --disallowedTools the model can't run a full review, so the
// report-at-bottom contract doesn't apply.
}, 360_000);
});