CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-09 06:28:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(browse): pin cli.ts profile-dir wiring to the canonical resolver

Browse Source 
Wave-added coverage for the #2732 absorption: a 6-line fix with zero tests is
how the hardcoded path shipped in the first place. resolveChromiumProfile's
env behavior is already pinned in config.test.ts; this pins cli.ts's
delegation and forbids the hardcoded path from returning.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-31 20:59:12 +00:00
co-authored by Claude Fable 5
parent 5852da35ad
commit 21bd661e7d
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browse/test/cli-lock.test.ts
+19
View File
@@ -99,3 +99,22 @@ describe('browse CLI server lock diagnostics (#1084)', () => {
});
});
});
// #2732 absorption (wave-added test): cli.ts's profile-lock cleanup and orphan
// kill must resolve the profile dir through the canonical resolver — a
// hardcoded ~/.gstack/chromium-profile here silently ignored $CHROMIUM_PROFILE
// and $GSTACK_HOME, so `browse stop` unlinked locks and SIGKILLed a PID
// belonging to an UNRELATED browser whenever a custom profile was active.
// resolveChromiumProfile's env behavior is pinned in browse/test/config.test.ts;
// this pins the cli.ts wiring to it.
describe('chromiumProfileDir wiring (#2732)', () => {
const cliSrc = fs.readFileSync(path.join(import.meta.dir, '..', 'src', 'cli.ts'), 'utf-8');
test('cli.ts delegates to resolveChromiumProfile', () => {
expect(cliSrc).toMatch(/function chromiumProfileDir\(\): string \{\s*return resolveChromiumProfile\(\);/);
});
test('no hardcoded chromium-profile path remains in cli.ts', () => {
expect(cliSrc).not.toMatch(/['"]\.gstack['"],\s*['"]chromium-profile['"]/);
});
});