mirror of
https://github.com/garrytan/gstack.git
synced 2026-08-31 18:30:39 +02:00
fix(ci): free-tests lane actually runs the make-pdf e2e gates
The 9 make-pdf/test/e2e gate tests probe make-pdf/dist/pdf, browse/dist/browse, and the diagram-render bundle, then self-skip when absent. The required free-tests lane never built any of them, so the gates silently skipped on Linux for their entire life (verified: 9 of 14 skip, exit 0). make-pdf-gate.yml's justification for deleting its Linux leg claimed the free lane covered this — it didn't. - new build:gates script: exactly the three artifacts the gates probe (full bun run build compiles five binaries; ~60-90s tax on the only required check is not warranted) - free-tests.yml: build:gates step + poppler-utils + fonts-noto-color-emoji (fonts must precede the first browse daemon launch — Chromium snapshots fontconfig at startup; verified live: a warm daemon renders tofu, a fresh one embeds NotoColorEmoji) - make-pdf/test/e2e/ci-prereqs.test.ts: GSTACK_EXPECT_BINARIES=1 (set by the workflow) inverts the skip polarity in CI — dropping the build step or poppler fails the lane instead of re-opening the silent-skip hole Pre-flight: all 9 gates green on Linux locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
394db326f2
commit
29d94a505d
@@ -24,10 +24,12 @@ jobs:
|
||||
strategy:
|
||||
fail-fast: false
|
||||
matrix:
|
||||
# macOS only: the Linux leg became redundant when the free-tests lane
|
||||
# started running make-pdf/test (incl. e2e/) on every PR via the
|
||||
# canonical runner — this gate's remaining value is macOS rendering
|
||||
# coverage on make-pdf-scoped changes.
|
||||
# macOS only: the Linux leg is covered by the free-tests lane, which
|
||||
# builds the gate binaries (build:gates) and runs make-pdf/test
|
||||
# (incl. e2e/) on every PR via the canonical runner, with
|
||||
# GSTACK_EXPECT_BINARIES=1 arming ci-prereqs.test.ts so the gates
|
||||
# can never silently self-skip there again. This gate's remaining
|
||||
# value is macOS rendering coverage on make-pdf-scoped changes.
|
||||
os: [macos-latest]
|
||||
# Windows is tolerant-mode — Xpdf / Poppler-Windows extraction
|
||||
# differs enough from the Linux/macOS baseline that the strict
|
||||
|
||||
Reference in New Issue
Block a user