fix(test): decouple slop:diff from bun run test; quality-gate runs it per PR

'bun run test' silently appended up to two 120s npx slop-scan runs plus
a git worktree add/remove after the suite (2>/dev/null || true) —
invisible in the documented '~90-100s' timing and pure friction in the
pre-commit loop. Decoupling is not coverage removal: quality-gate.yml
now runs slop:diff on every PR (advisory, matching its in-repo 'never
blocking' contract), and /review already invokes it explicitly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

.github/workflows/quality-gate.yml

@@ -43,6 +43,14 @@ jobs:
       - name: Install frozen dependencies
         run: bun install --frozen-lockfile --ignore-scripts
 
+      # Advisory slop scan of branch-changed files. Lived inside `bun run
+      # test` before (silently appended, up to 240s invisible in the "~90s
+      # suite" claim); decoupling it from the pre-commit loop is only honest
+      # if a per-PR path still runs it — this is that path. || true: quality
+      # signal, never a gate (/review runs it interactively too).
+      - name: Slop scan (changed files, advisory)
+        run: bun run slop:diff || true
+
       - name: Scan changed text for credentials (added lines, own redact engine)
         env:
           BASE_SHA: ${{ github.event.pull_request.base.sha || github.event.before }}

package.json

@@ -19,7 +19,7 @@
     "gen:skill-docs:user": "bun run scripts/gen-skill-docs.ts --respect-detection",
     "dev": "bun run browse/src/cli.ts",
     "server": "bun run browse/src/server.ts",
-    "test": "bun run scripts/test-free-shards.ts && (bun run slop:diff 2>/dev/null || true)",
+    "test": "bun run scripts/test-free-shards.ts",
     "test:free": "bun run scripts/test-free-shards.ts",
     "test:windows": "bun run scripts/test-free-shards.ts --windows-only",
     "test:evals": "EVALS=1 bun test --retry 1 --concurrent --max-concurrency ${EVALS_CONCURRENCY:-15} test/skill-llm-eval*.test.ts test/skill-e2e-*.test.ts test/skill-routing-e2e.test.ts test/codex-e2e*.test.ts test/gemini-e2e.test.ts test/llm-judge-recommendation.test.ts test/carve-section-loading.test.ts",