fix(test): decouple slop:diff from bun run test; quality-gate runs it per PR

'bun run test' silently appended up to two 120s npx slop-scan runs plus
a git worktree add/remove after the suite (2>/dev/null || true) —
invisible in the documented '~90-100s' timing and pure friction in the
pre-commit loop. Decoupling is not coverage removal: quality-gate.yml
now runs slop:diff on every PR (advisory, matching its in-repo 'never
blocking' contract), and /review already invokes it explicitly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-29 05:08:47 +00:00
co-authored by Claude Fable 5
parent b4cc808ba1
commit 2e693a5918
2 changed files with 9 additions and 1 deletions
+8
View File
@@ -43,6 +43,14 @@ jobs:
- name: Install frozen dependencies
run: bun install --frozen-lockfile --ignore-scripts
# Advisory slop scan of branch-changed files. Lived inside `bun run
# test` before (silently appended, up to 240s invisible in the "~90s
# suite" claim); decoupling it from the pre-commit loop is only honest
# if a per-PR path still runs it — this is that path. || true: quality
# signal, never a gate (/review runs it interactively too).
- name: Slop scan (changed files, advisory)
run: bun run slop:diff || true
- name: Scan changed text for credentials (added lines, own redact engine)
env:
BASE_SHA: ${{ github.event.pull_request.base.sha || github.event.before }}