mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-05 05:05:08 +02:00
feat: integrate mockups into review passes and outputs
Thread Step 0.5 mockups through the review workflow: Pass 4 (AI Slop) evaluates generated mockups visually, Pass 7 uses mockups as evidence for unresolved decisions, post-pass offers one-shot regeneration after design changes, and Approved Mockups section records chosen variants with paths for the implementer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -801,6 +801,7 @@ Source: [OpenAI "Designing Delightful Frontends with GPT-5.4"](https://developer
|
||||
- "Hero section" → what makes this hero feel like THIS product?
|
||||
- "Clean, modern UI" → meaningless. Replace with actual design decisions.
|
||||
- "Dashboard with widgets" → what makes this NOT every other dashboard?
|
||||
If visual mockups were generated in Step 0.5, evaluate them against the AI slop blacklist above. Read each mockup image using the Read tool. Does the mockup fall into generic patterns (3-column grid, centered hero, stock-photo feel)? If so, flag it and offer to regenerate with more specific direction via `$D iterate --feedback "..."`.
|
||||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||||
|
||||
### Pass 5: Design System Alignment
|
||||
@@ -823,8 +824,17 @@ Surface ambiguities that will haunt implementation:
|
||||
Mobile nav pattern? | Desktop nav hides behind hamburger
|
||||
...
|
||||
```
|
||||
If visual mockups were generated in Step 0.5, reference them as evidence when surfacing unresolved decisions. A mockup makes decisions concrete — e.g., "Your approved mockup shows a sidebar nav, but the plan doesn't specify mobile behavior. What happens to this sidebar on 375px?"
|
||||
Each decision = one AskUserQuestion with recommendation + WHY + alternatives. Edit the plan with each decision as it's made.
|
||||
|
||||
### Post-Pass: Update Mockups (if generated)
|
||||
|
||||
If mockups were generated in Step 0.5 and review passes changed significant design decisions (information architecture restructure, new states, layout changes), offer to regenerate (one-shot, not a loop):
|
||||
|
||||
AskUserQuestion: "The review passes changed [list major design changes]. Want me to regenerate mockups to reflect the updated plan? This ensures the visual reference matches what we're actually building."
|
||||
|
||||
If yes, use `$D iterate` with feedback summarizing the changes, or `$D variants` with an updated brief. Save to `.context/mockups/`.
|
||||
|
||||
## CRITICAL RULE — How to ask questions
|
||||
Follow the AskUserQuestion format from the Preamble above. Additional rules for plan design reviews:
|
||||
* **One issue = one AskUserQuestion call.** Never combine multiple issues into one question.
|
||||
@@ -873,6 +883,7 @@ Then present options: **A)** Add to TODOS.md **B)** Skip — not valuable enough
|
||||
| NOT in scope | written (___ items) |
|
||||
| What already exists | written |
|
||||
| TODOS.md updates | ___ items proposed |
|
||||
| Approved Mockups | ___ generated, ___ approved |
|
||||
| Decisions made | ___ added to plan |
|
||||
| Decisions deferred | ___ (listed below) |
|
||||
| Overall design score | ___/10 → ___/10 |
|
||||
@@ -885,6 +896,20 @@ If any below 8: note what's unresolved and why (user chose to defer).
|
||||
### Unresolved Decisions
|
||||
If any AskUserQuestion goes unanswered, note it here. Never silently default to an option.
|
||||
|
||||
### Approved Mockups
|
||||
|
||||
If visual mockups were generated during this review, add to the plan file:
|
||||
|
||||
```
|
||||
## Approved Mockups
|
||||
|
||||
| Screen/Section | Mockup Path | Direction | Notes |
|
||||
|----------------|-------------|-----------|-------|
|
||||
| [screen name] | .context/mockups/[filename].png | [brief description] | [constraints from review] |
|
||||
```
|
||||
|
||||
Include the file path to each approved mockup (the variant the user chose), a one-line description of the direction, and any constraints. The implementer reads this to know exactly which visual to build from. If no mockups were generated, omit this section.
|
||||
|
||||
## Review Log
|
||||
|
||||
After producing the Completion Summary above, persist the review result.
|
||||
|
||||
@@ -265,6 +265,7 @@ FIX TO 10: Rewrite vague UI descriptions with specific alternatives.
|
||||
- "Hero section" → what makes this hero feel like THIS product?
|
||||
- "Clean, modern UI" → meaningless. Replace with actual design decisions.
|
||||
- "Dashboard with widgets" → what makes this NOT every other dashboard?
|
||||
If visual mockups were generated in Step 0.5, evaluate them against the AI slop blacklist above. Read each mockup image using the Read tool. Does the mockup fall into generic patterns (3-column grid, centered hero, stock-photo feel)? If so, flag it and offer to regenerate with more specific direction via `$D iterate --feedback "..."`.
|
||||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||||
|
||||
### Pass 5: Design System Alignment
|
||||
@@ -287,8 +288,17 @@ Surface ambiguities that will haunt implementation:
|
||||
Mobile nav pattern? | Desktop nav hides behind hamburger
|
||||
...
|
||||
```
|
||||
If visual mockups were generated in Step 0.5, reference them as evidence when surfacing unresolved decisions. A mockup makes decisions concrete — e.g., "Your approved mockup shows a sidebar nav, but the plan doesn't specify mobile behavior. What happens to this sidebar on 375px?"
|
||||
Each decision = one AskUserQuestion with recommendation + WHY + alternatives. Edit the plan with each decision as it's made.
|
||||
|
||||
### Post-Pass: Update Mockups (if generated)
|
||||
|
||||
If mockups were generated in Step 0.5 and review passes changed significant design decisions (information architecture restructure, new states, layout changes), offer to regenerate (one-shot, not a loop):
|
||||
|
||||
AskUserQuestion: "The review passes changed [list major design changes]. Want me to regenerate mockups to reflect the updated plan? This ensures the visual reference matches what we're actually building."
|
||||
|
||||
If yes, use `$D iterate` with feedback summarizing the changes, or `$D variants` with an updated brief. Save to `.context/mockups/`.
|
||||
|
||||
## CRITICAL RULE — How to ask questions
|
||||
Follow the AskUserQuestion format from the Preamble above. Additional rules for plan design reviews:
|
||||
* **One issue = one AskUserQuestion call.** Never combine multiple issues into one question.
|
||||
@@ -337,6 +347,7 @@ Then present options: **A)** Add to TODOS.md **B)** Skip — not valuable enough
|
||||
| NOT in scope | written (___ items) |
|
||||
| What already exists | written |
|
||||
| TODOS.md updates | ___ items proposed |
|
||||
| Approved Mockups | ___ generated, ___ approved |
|
||||
| Decisions made | ___ added to plan |
|
||||
| Decisions deferred | ___ (listed below) |
|
||||
| Overall design score | ___/10 → ___/10 |
|
||||
@@ -349,6 +360,20 @@ If any below 8: note what's unresolved and why (user chose to defer).
|
||||
### Unresolved Decisions
|
||||
If any AskUserQuestion goes unanswered, note it here. Never silently default to an option.
|
||||
|
||||
### Approved Mockups
|
||||
|
||||
If visual mockups were generated during this review, add to the plan file:
|
||||
|
||||
```
|
||||
## Approved Mockups
|
||||
|
||||
| Screen/Section | Mockup Path | Direction | Notes |
|
||||
|----------------|-------------|-----------|-------|
|
||||
| [screen name] | .context/mockups/[filename].png | [brief description] | [constraints from review] |
|
||||
```
|
||||
|
||||
Include the file path to each approved mockup (the variant the user chose), a one-line description of the direction, and any constraints. The implementer reads this to know exactly which visual to build from. If no mockups were generated, omit this section.
|
||||
|
||||
## Review Log
|
||||
|
||||
After producing the Completion Summary above, persist the review result.
|
||||
|
||||
Reference in New Issue
Block a user