fix(review,ship): state plan-check timing after smoke expiry and test_stub Skip semantics (review workflow judge clarity)

This commit is contained in:
garrytan committed 2026-09-30 07:44:29 +00:00
1 parent d361f9a8b8
commit 47655660e2
8 files changed
+12 -6

No files matched your search

+2 -1
View File
@@ -18,6 +18,7 @@ gstack now looks up its state folder one way everywhere, and the five most copy-
- **Privacy opt-outs never get looser.** `telemetry`, `memorable_recall`, `codex_reviews`, `update_check` and trust-policy denies take the most restrictive value across the active folder and `~/.gstack`. `gstack-config set` says when another folder still overrides you and prints the command that fixes it, and `gstack-config list` shows which folder each merged key came from.
- **Uninstall deletes state only at `~/.gstack`.** `gstack-uninstall` refuses (exit 2) when that path resolves to `/`, your home, the gstack checkout or the current repository. For a relocated folder it leaves the folder in place and prints the exact removal command.
- **Outside-voice fallbacks read the same in every skill.** `/plan-devex-review` now also treats an "API key" error as an authentication failure, `/office-hours` names its fallback subagent like the other skills, and the `/review` and `/ship` adversarial pass says "timed out after 9 minutes" (a timed-out pass is still missing coverage).
- `/review` and `/ship` exploratory QA now say how required plan checks behave once the 5-minute smoke clock expires: they and their revalidation keep running on a per-command `--timeout-ms` and still publish checkpoints, while a smoke recheck after expiry is reported not-run. In `/review`, skipping a finding that carries a proposed test skips both the test and the fix, and the defect stays unresolved.
- After a revert of this release, state written to a non-default folder while it was live stays in that folder.
### Fixed
@@ -32,7 +33,7 @@ gstack now looks up its state folder one way everywhere, and the five most copy-
- **PTY harness:** `test/helpers/claude-pty-runner.ts` is a barrel over `test/helpers/pty/*` (screen, launch, classify, auq, plan-native, boundaries, judge). One `runPtySession` loop drives the observation, counting and floor runners. A scripted fake PTY driver (`pty/fake-session.ts`) with an injectable clock runs each runner deterministically, and the unit test is split along the same modules. Tests keep importing the barrel.
- **Review resolvers:** `scripts/resolvers/review.ts` is split into `review-dashboard.ts`, `plan-gates.ts`, `spec-review.ts`, `outside-voice-steps.ts` and `review-scope.ts`. Generated output is byte-identical except the fallback wording above, which now comes from `outsideVoiceFailurePolicy()` in `outside-voice.ts`; `test/outside-voice-failure-policy.test.ts` rejects hand-written copies.
- **Ratchets:** `test/module-size-ratchet.test.ts` keeps the new owner modules at or under 800 lines and 150 lines per function, and stops the residual files (`server.ts`, both runners) from growing. `test/touchfiles.test.ts` checks that every moved module still selects the paid evals its source file selected (goldens in `test/fixtures/touchfile-moved-code/`, recorded before the move).
- **Budgets:** the guarded `gstack-paths` line in always-loaded preambles moved a few budgets to their measured values, each with its derivation recorded: carve-guards for ship (1.397 → 1.402), plan-ceo-review skeleton (80,150 → 80,850 bytes), plan-eng-review (1.169 → 1.174), design-consultation (1.08 → 1.085) and qa (1.095 → 1.102), and the `unfreeze` eager ceiling (393 → 448 tokens).
- **Budgets:** the guarded `gstack-paths` line in always-loaded preambles moved a few budgets to their measured values, each with its derivation recorded: carve-guards for ship (1.397 → 1.404), plan-ceo-review skeleton (80,150 → 80,850 bytes), plan-eng-review (1.169 → 1.174), design-consultation (1.08 → 1.085) and qa (1.095 → 1.102), and the `unfreeze` eager ceiling (393 → 448 tokens).
- **Deferred:** `TODOS.md` "P3: next refactor wave" lists the hotspots this wave did not touch and the behavior bugs it found and left alone.
## [1.91.9.0] - 2026-09-29
+3 -2
View File
@@ -827,6 +827,7 @@ Never install, import cookies or bootstrap tests. Functional-only skips browser
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
@@ -952,8 +953,8 @@ toward AUTO-FIX.
**Test stub override:** Any finding that has a `test_stub` field, from a specialist or exploratory QA,
is reclassified as ASK regardless of its original classification. When presenting the ASK
item, show the proposed test file path and the test code. The user approves or skips the
test creation. If approved, follow Step 5d's regression-before-repair order. Derive the test file path from
item, show the proposed test file path and the test code. Step 5c's A) Fix writes the test and
repair in Step 5d's regression-before-repair order; B) Skip skips both; the defect stays unresolved. Derive the test file path from
the finding's `path` using project conventions (`spec/` for RSpec, `__tests__/` for
Jest/Vitest, `test_` prefix for pytest, `_test.go` suffix for Go). If the test file
already exists, append the new test.
+2 -2
View File
@@ -270,8 +270,8 @@ toward AUTO-FIX.
**Test stub override:** Any finding that has a `test_stub` field, from a specialist or exploratory QA,
is reclassified as ASK regardless of its original classification. When presenting the ASK
item, show the proposed test file path and the test code. The user approves or skips the
test creation. If approved, follow Step 5d's regression-before-repair order. Derive the test file path from
item, show the proposed test file path and the test code. Step 5c's A) Fix writes the test and
repair in Step 5d's regression-before-repair order; B) Skip skips both; the defect stays unresolved. Derive the test file path from
the finding's `path` using project conventions (`spec/` for RSpec, `__tests__/` for
Jest/Vitest, `test_` prefix for pytest, `_test.go` suffix for Go). If the test file
already exists, append the new test.
+1
View File
@@ -257,6 +257,7 @@ Never install, import cookies or bootstrap tests. Functional-only skips browser
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the \`G status D\` expiry stop and use \`--timeout-ms\`, not \`--deadline D\`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1
View File
@@ -504,6 +504,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1
View File
@@ -2109,6 +2109,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1
View File
@@ -2368,6 +2368,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F
**3. Run smoke and plan checks.**
Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit.
Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock.
Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run.
Use finite command timeouts, capped at the caller's remaining time if it has a deadline.
Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.
+1 -1
View File
@@ -166,7 +166,7 @@ export const CARVE_GUARDS: Record<string, CarveGuard> = {
// wave's headline capability) grows the union to 1.195x. Deliberate:
// the section is on-demand (loads only for Apple store targets), so
// per-invocation cost for non-iOS ships is one manifest line.
maxSizeRatio: 1.402, // Shared advisory identity/dedup + critical-severity validation: 248,065 union bytes / 187,706 baseline = 1.3216 (2026-09-17). + test value bar in the lazy Step 7 section (value cards, weak paths, gate table, base control, machine checks; ~13.6KB): measured 1.396 (2026-09-29). + W1 guarded state-root resolution (`eval gstack-paths; : "${GSTACK_STATE_ROOT:?…}"`) in the Context Recovery preamble, the eureka log and each state-writing bash block; measured 1.401 (2026-09-30).
maxSizeRatio: 1.404, // Shared advisory identity/dedup + critical-severity validation: 248,065 union bytes / 187,706 baseline = 1.3216 (2026-09-17). + test value bar in the lazy Step 7 section (value cards, weak paths, gate table, base control, machine checks; ~13.6KB): measured 1.396 (2026-09-29). + W1 guarded state-root resolution (`eval gstack-paths; : "${GSTACK_STATE_ROOT:?…}"`) in the Context Recovery preamble, the eureka log and each state-writing bash block; measured 1.401 (2026-09-30). + the shared QA review step's plan-check timing rule (plan checks and their revalidation run on --timeout-ms after smoke expiry); measured 1.4022 (2026-09-30).
},
'plan-ceo-review': {
skill: 'plan-ceo-review',