CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-11-06 00:44:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(office-hours): the reviewer receipt must match the receipt grammar before the check runs

Browse Source 
Co-authored-by: dgrant <dgrant@users.noreply.github.com>
This commit is contained in:
garrytananddgrant committed 2026-10-06 21:03:23 +00:00
1 parent 1eea880431
commit 57ccafd933
3 files changed
+7 -5
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

office-hours/sections/design-and-handoff.md
+3 -2
View File
@@ -214,10 +214,11 @@ customer facts from committed behavior, and requires evidence for every prior st
After each verdict, BEFORE fixing any findings or dispatching again, validate the
saved files with the helper. Pass the reviewer's entire response unchanged as the
receipt and list every completed round in order:
receipt (a lone `OFFICE_HOURS_VERDICT` line; with a quote, backtick, `$` or `\` it is
malformed) and list every completed round in order:
```bash
~/.claude/skills/gstack/bin/gstack-office-hours-review check --receipt "<reviewer response>" "<round-1.json>" "<round-2.json if present>" "<round-3.json if present>"
~/.claude/skills/gstack/bin/gstack-office-hours-review check --receipt "<receipt line>" "<round-1.json>" "<round-2.json if present>" "<round-3.json if present>"
```
A missing, malformed, or mismatched receipt fails the check: that attempt is a failed review.
scripts/resolvers/spec-review.ts
+3 -2
View File
@@ -72,10 +72,11 @@ customer facts from committed behavior, and requires evidence for every prior st
After each verdict, BEFORE fixing any findings or dispatching again, validate the
saved files with the helper. Pass the reviewer's entire response unchanged as the
receipt and list every completed round in order:
receipt (a lone \`OFFICE_HOURS_VERDICT\` line; with a quote, backtick, \`$\` or \`\\\` it is
malformed) and list every completed round in order:
\`\`\`bash
~/.claude/skills/gstack/bin/gstack-office-hours-review check --receipt "<reviewer response>" "<round-1.json>" "<round-2.json if present>" "<round-3.json if present>"
~/.claude/skills/gstack/bin/gstack-office-hours-review check --receipt "<receipt line>" "<round-1.json>" "<round-2.json if present>" "<round-3.json if present>"
\`\`\`
A missing, malformed, or mismatched receipt fails the check: that attempt is a failed review.
test/gen-skill-docs.test.ts
+1 -1
View File
@@ -1558,7 +1558,7 @@ describe('SPEC_REVIEW_LOOP resolver', () => {
const output = render('office-hours');
const step2 = output.slice(output.indexOf('**Step 2:'), output.indexOf('**Step 3:'));
expectMentions(step2, [['before','dispatching','findings']], 'step2');
ordered(step2, ['gstack-office-hours-review check --receipt "<reviewer response>"', 'mismatched receipt fails the check', '- PASS:', '- CONVERGENCE:', '- MAX_ITERATIONS: round 3', '- CONTINUE:', 'gstack-office-hours-review finalize --design']);
ordered(step2, ['gstack-office-hours-review check --receipt "<receipt line>"', 'mismatched receipt fails the check', '- PASS:', '- CONVERGENCE:', '- MAX_ITERATIONS: round 3', '- CONTINUE:', 'gstack-office-hours-review finalize --design']);
expectMentions(step2, [['fix only the blocking findings'], ['do not edit for minor findings']], 'step2');
expectMentions(step2, [['do not','re-dispatch','again']], 'step2');
expectMentions(step2, [['do not','generated','section']], 'step2');