mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-14 20:37:14 +01:00
fix(office-hours): the reviewer receipt must match the receipt grammar before the check runs
Co-authored-by: dgrant <dgrant@users.noreply.github.com>
This commit is contained in:
1 parent
1eea880431
commit
57ccafd933
3 files changed
+7
-5
No files matched your search
@@ -1558,7 +1558,7 @@ describe('SPEC_REVIEW_LOOP resolver', () => {
|
||||
const output = render('office-hours');
|
||||
const step2 = output.slice(output.indexOf('**Step 2:'), output.indexOf('**Step 3:'));
|
||||
expectMentions(step2, [['before','dispatching','findings']], 'step2');
|
||||
ordered(step2, ['gstack-office-hours-review check --receipt "<reviewer response>"', 'mismatched receipt fails the check', '- PASS:', '- CONVERGENCE:', '- MAX_ITERATIONS: round 3', '- CONTINUE:', 'gstack-office-hours-review finalize --design']);
|
||||
ordered(step2, ['gstack-office-hours-review check --receipt "<receipt line>"', 'mismatched receipt fails the check', '- PASS:', '- CONVERGENCE:', '- MAX_ITERATIONS: round 3', '- CONTINUE:', 'gstack-office-hours-review finalize --design']);
|
||||
expectMentions(step2, [['fix only the blocking findings'], ['do not edit for minor findings']], 'step2');
|
||||
expectMentions(step2, [['do not','re-dispatch','again']], 'step2');
|
||||
expectMentions(step2, [['do not','generated','section']], 'step2');
|
||||
|
||||
Reference in new issue
Block a user