CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-11-06 17:04:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(plan-eng-review): keep final navigation consistent with approved tasks

Browse Source
This commit is contained in:
Garry Tan committed 2026-09-11 03:57:47 +00:00
1 parent d00590f2ec
commit 5ab30bfbda
2 files changed
+8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

plan-eng-review/sections/review-sections.md
+4
View File
@@ -1019,6 +1019,10 @@ After displaying the Review Readiness Dashboard, check if additional reviews wou
**If no additional reviews are needed** (or `skip_eng_review` is `true` in the dashboard config, meaning this eng review was optional): state "All relevant reviews complete. Run /ship when ready."
**Navigation only.** Match task prerequisites, dependencies and execution order to the written plan; do not add or strengthen them in this question or its option descriptions. A test required before editing one function does not make every independent lane wait for it.
If a substantive late change is needed, return to the individual issue-approval loop. After the answer, update the plan's tasks and dependency/parallelization sections, refresh the review report and log, then Read the updated plan and rerun the exit gate before ExitPlanMode. A next-step answer alone approves no implementation change.
Use AskUserQuestion with only the applicable options:
- **A)** Run /plan-design-review (only if UI scope detected and no design review exists)
- **B)** Run /plan-ceo-review (only if significant product change and no CEO review exists)
plan-eng-review/sections/review-sections.md.tmpl
+4
View File
@@ -225,6 +225,10 @@ After displaying the Review Readiness Dashboard, check if additional reviews wou
**If no additional reviews are needed** (or `skip_eng_review` is `true` in the dashboard config, meaning this eng review was optional): state "All relevant reviews complete. Run /ship when ready."
**Navigation only.** Match task prerequisites, dependencies and execution order to the written plan; do not add or strengthen them in this question or its option descriptions. A test required before editing one function does not make every independent lane wait for it.
If a substantive late change is needed, return to the individual issue-approval loop. After the answer, update the plan's tasks and dependency/parallelization sections, refresh the review report and log, then Read the updated plan and rerun the exit gate before ExitPlanMode. A next-step answer alone approves no implementation change.
Use AskUserQuestion with only the applicable options:
- **A)** Run /plan-design-review (only if UI scope detected and no design review exists)
- **B)** Run /plan-ceo-review (only if significant product change and no CEO review exists)