mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-12 03:30:28 +01:00
fix: pre-landing review fixes (proof is a repro on current main or a failing test written first)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
caa17fccc0
commit
5ecc503b42
4 files changed
+5
-5
No files matched your search
+1
-1
@@ -375,7 +375,7 @@ New scope taken on part-way gets its own plan. Read-only lanes, the flaky pass's
|
||||
slot stamps, CHANGELOG resolves, cap re-pins under a grant, S1 emergencies (broken install
|
||||
or upgrade, red main, a security bug) and fixes from an already-diagnosed, audited problem
|
||||
list are exempt. Other bug fixes skip plan review (`--kind fix`, R65) but carry a repro
|
||||
or failing test; features get the lean run (`--kind feature`). The brief a
|
||||
on current main or a failing test written first; features get the lean run (`--kind feature`). The brief a
|
||||
controller hands a lane, with its `Plan: required | approved | exempt` line, is
|
||||
`captain/templates/brief.md`; the rule is `docs/captain.md` (Plan before build).
|
||||
|
||||
|
||||
@@ -303,7 +303,7 @@ New scope taken on part-way gets its own plan. Read-only lanes, the flaky pass's
|
||||
slot stamps, CHANGELOG resolves, cap re-pins under a grant, S1 emergencies (broken install
|
||||
or upgrade, red main, a security bug) and fixes from an already-diagnosed, audited problem
|
||||
list are exempt. Other bug fixes skip plan review (`--kind fix`, R65) but carry a repro
|
||||
or failing test; features get the lean run (`--kind feature`). The brief a
|
||||
on current main or a failing test written first; features get the lean run (`--kind feature`). The brief a
|
||||
controller hands a lane, with its `Plan: required | approved | exempt` line, is
|
||||
`captain/templates/brief.md`; the rule is `docs/captain.md` (Plan before build).
|
||||
|
||||
|
||||
@@ -136,8 +136,8 @@ Homes are paths in the gstack checkout the lane checked at session start.
|
||||
lanes, the daily flaky pass's repairs, slot stamps, CHANGELOG-only resolves, cap
|
||||
re-pins under a written grant, S1 emergencies (broken install or upgrade, red main,
|
||||
a security bug) and fixes from an already-diagnosed, audited problem list. Any other
|
||||
bug fix is exempt too (`gstack-autoplan next --kind fix`, R65) and carries a repro or
|
||||
failing test in the PR; a feature gets the lean run (`--kind feature`). Home: `docs/captain.md` (Plan before build),
|
||||
bug fix is exempt too (`gstack-autoplan next --kind fix`, R65) and carries a repro on
|
||||
current main or a failing test written first in the PR; a feature gets the lean run (`--kind feature`). Home: `docs/captain.md` (Plan before build),
|
||||
`captain/templates/brief.md`.
|
||||
|
||||
## Crew-specific rules
|
||||
|
||||
@@ -58,7 +58,7 @@ Every Capy thread that uses gstack follows these for new work, under a Captain o
|
||||
- **Stop a finished /ship subagent.** When a /ship subagent opens its PR, the parent subscribes to that PR with Capy's subscribe tool and keeps that one subscription until the PR merges or closes, re-subscribing if the watch expires, then cancels it. Once the subscription is in place and READY arrives, the parent stops the subagent and owns the PR from then on, slot stamp, re-READY and receipt carry included. A stopped /ship subagent woken by a check, review or merge notice, not by its parent, reports one line naming what woke it, its pin and the PR head (`gh pr view <n> --json headRefOid --jq .headRefOid`) and ends the turn without acting, whether or not the head moved. A message from its parent is an instruction it carries out.
|
||||
- **No merge without the owner's word.** A thread never merges on its own; under a Captain the controller merges on a recorded standing approval, and a thread with no Captain asks the person.
|
||||
|
||||
Exempt from the plan step: read-only work, the daily flaky pass's repairs, slot stamps, CHANGELOG-only resolves, cap re-pins under a written grant, S1 emergencies (a broken install or upgrade, a red main, a security bug) and fixes from an already-diagnosed, audited problem list. Other bug fixes skip plan review (`--kind fix`, R65) but carry a repro or failing test; features get the lean run (`--kind feature`).
|
||||
Exempt from the plan step: read-only work, the daily flaky pass's repairs, slot stamps, CHANGELOG-only resolves, cap re-pins under a written grant, S1 emergencies (a broken install or upgrade, a red main, a security bug) and fixes from an already-diagnosed, audited problem list. Other bug fixes skip plan review (`--kind fix`, R65) but carry a repro on current main or a failing test written first; features get the lean run (`--kind feature`).
|
||||
|
||||
## Working under a Captain
|
||||
|
||||
|
||||
Reference in new issue
Block a user