CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-11-12 03:30:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: pre-landing review fixes

Browse Source 
Assert the killed child's signal-and-elapsed log line; pin hookChildBudgetMs to literal values and stop exporting HOOK_EXIT_RESERVE_MS.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
garrytanandcapy-ai[bot] committed 2026-11-03 15:04:37 +00:00
1 parent bce82811da
commit 77b47c05bd
2 files changed
+8 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

hosts/claude/hooks/spawn-bin.ts
+1 -1
View File
@@ -44,7 +44,7 @@ export function runBin(name: string, args: string[], opts: SpawnSyncOptions) {
/** Claude Code's timeout for a gstack hook, as setup registers it (`--timeout 5`). */
export const HOOK_TIMEOUT_MS = 5000;
/** Kept back from HOOK_TIMEOUT_MS so a hook logs and exits before Claude Code kills it. */
export const HOOK_EXIT_RESERVE_MS = 500;
const HOOK_EXIT_RESERVE_MS = 500;
/**
* What is left of a hook's registered budget for its next child. Every child
test/question-log-hook.test.ts
+7 -5
View File
@@ -19,7 +19,7 @@ import * as fs from 'fs';
import * as path from 'path';
import * as os from 'os';
import { spawnSync } from 'child_process';
import { HOOK_EXIT_RESERVE_MS, HOOK_TIMEOUT_MS, hookChildBudgetMs } from '../hosts/claude/hooks/spawn-bin';
import { hookChildBudgetMs } from '../hosts/claude/hooks/spawn-bin';
const ROOT = path.resolve(import.meta.dir, '..');
const HOOK = path.join(ROOT, 'hosts', 'claude', 'hooks', 'question-log-hook');
@@ -402,9 +402,9 @@ describe('PostToolUse hook (crash safety)', () => {
describe('PostToolUse hook (budget)', () => {
test('every child shares the registered 5 s budget, less the exit reserve', () => {
expect(hookChildBudgetMs(1_000, 1_000)).toBe(HOOK_TIMEOUT_MS - HOOK_EXIT_RESERVE_MS);
expect(hookChildBudgetMs(1_000, 3_000)).toBe(HOOK_TIMEOUT_MS - HOOK_EXIT_RESERVE_MS - 2_000);
expect(hookChildBudgetMs(1_000, 1_000 + HOOK_TIMEOUT_MS)).toBeLessThan(0);
expect(hookChildBudgetMs(1_000, 1_000)).toBe(4_500);
expect(hookChildBudgetMs(1_000, 3_000)).toBe(2_500);
expect(hookChildBudgetMs(1_000, 6_000)).toBeLessThan(0);
});
test('slow children stop at the hook budget and the skipped questions are logged', () => {
@@ -436,7 +436,9 @@ describe('PostToolUse hook (budget)', () => {
});
expect(res.status).toBe(0);
expect(readLog().length).toBeLessThan(questions.length);
expect(fs.readFileSync(path.join(stateRoot, 'hook-errors.log'), 'utf-8')).toContain('budget is spent');
const errors = fs.readFileSync(path.join(stateRoot, 'hook-errors.log'), 'utf-8');
expect(errors).toMatch(/exited null \(SIG\w+ after \d+ of \d+ ms\)/);
expect(errors).toContain('budget is spent');
} finally {
fs.rmSync(fakeBin, { recursive: true, force: true });
}