CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-09 22:48:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): host-config goldens self-provision .agents/.factory artifacts

Browse Source 
Fixes #2532. The codex/factory golden tests read gitignored artifacts that
only gen-skill-docs.test.ts (serial tree-mutating phase) produces, so the
file failed in isolation and on clean clones (the #2536 "3 failures then 0"
symptom). beforeAll now generates a host's artifacts iff its ship SKILL.md
is missing — never overwriting existing ones, so stale artifacts still fail
the golden. The file is also classified TREE_MUTATING so its provisioning
runs in the serial window, not racing parallel readers.

Verified: full pass with .agents/ and .factory/ deleted (74/74 in isolation).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-16 08:33:04 -07:00
co-authored by Claude Fable 5
parent 410b4928e7
commit 7ab271318b
2 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/test-free-shards.ts
+2
View File
@@ -355,6 +355,8 @@ export const TREE_MUTATING: Record<string, string> = {
'test/skill-validation.test.ts': 'regenerates .agents/ (codex host) artifacts in place (3 sites)',
'test/gbrain-detection-override.test.ts':
'regenerates SKILL.md in place with --respect-detection (gbrain variant), then git-restores — readers see inflated skeletons mid-window',
'test/host-config.test.ts':
'golden tests read .agents/.factory artifacts produced by gen-skill-docs.test.ts, and its beforeAll generates them when missing (#2532) — must not race the parallel readers or run before the mutators window',
// Ratchet readers (measure the tree; need it quiet):
'test/parity-suite.test.ts': 'RATCHET READER — parity caps measure live SKILL.md/section bytes',
'test/skill-size-budget.test.ts': 'RATCHET READER — per-skill and corpus size budgets measure the live tree',
test/host-config.test.ts
+28 -1
View File
@@ -3,7 +3,7 @@
* host-config-export.ts, and golden-file regression checks.
*/
import { describe, test, expect } from 'bun:test';
import { describe, test, expect, beforeAll } from 'bun:test';
import * as fs from 'fs';
import * as path from 'path';
import { validateHostConfig, validateAllConfigs, type HostConfig } from '../scripts/host-config';
@@ -421,6 +421,33 @@ describe('host-config-export.ts CLI', () => {
describe('golden-file regression', () => {
const GOLDEN_DIR = path.join(ROOT, 'test', 'fixtures', 'golden');
// #2532: the codex/factory goldens read gitignored .agents/ and .factory/
// artifacts that only gen-skill-docs.test.ts (a serial tree-mutating file)
// produces. On a clean clone — or when this file runs in isolation — those
// dirs don't exist and the goldens fail with ENOENT, an order dependency,
// not a regression. Self-provision: generate a host's artifacts iff its
// ship SKILL.md is missing. Existing artifacts are never overwritten here,
// so a genuinely stale artifact still fails the golden (that is the test's
// job; freshness enforcement lives in gen-skill-docs.test.ts).
beforeAll(() => {
const hostArtifacts: Array<[string, string]> = [
['codex', path.join(ROOT, '.agents', 'skills', 'gstack-ship', 'SKILL.md')],
['factory', path.join(ROOT, '.factory', 'skills', 'gstack-ship', 'SKILL.md')],
];
for (const [host, artifact] of hostArtifacts) {
if (fs.existsSync(artifact)) continue;
const result = Bun.spawnSync(['bun', 'run', 'scripts/gen-skill-docs.ts', '--host', host], {
cwd: ROOT,
});
if (result.exitCode !== 0) {
throw new Error(
`golden-file beforeAll: gen-skill-docs --host ${host} failed (exit ${result.exitCode}):\n`
+ result.stderr.toString(),
);
}
}
});
test('Claude ship skill matches golden baseline', () => {
const golden = fs.readFileSync(path.join(GOLDEN_DIR, 'claude-ship-SKILL.md'), 'utf-8');
const current = fs.readFileSync(path.join(ROOT, 'ship', 'SKILL.md'), 'utf-8');