test(design): plan-mode length is a drafting target, not a check to measure and trim

This commit is contained in:
garrytan committed 2026-10-01 17:08:34 +00:00
1 parent 4fb98806a5
commit 8697cf13bd
2 files changed
+3 -3

No files matched your search

+2 -2
View File
@@ -89,7 +89,7 @@ async function exercise(mode: 'success' | 'max-turns' | 'first-timeout' | 'secon
expect(opts.signal.aborted).toBe(false);
// Bind the complete actual compact-delivery prompt, not selected snippets.
expect(new Bun.CryptoHasher('sha256').update(opts.prompt).digest('hex'))
.toBe('56468e8f520719957c612ced2da1f5f2f3698bc4551075a429bee4816e157cdb');
.toBe('021c9f2b0522fc55bc265a976356678a048f3c17d27b63669674c805a485b28e');
expect(opts.testName).toBe(id); expect(opts.maxTurns).toBe(15); expect(opts.timeout).toBe(CAPTURE_MS);
for (const key of ['model', 'tools', 'allowedTools', 'appendSystemPrompt', 'env']) expect(opts).not.toHaveProperty(key);
expect(opts.prompt).toContain('Review the plan in ./plan.md');
@@ -103,7 +103,7 @@ async function exercise(mode: 'success' | 'max-turns' | 'first-timeout' | 'secon
expect(opts.prompt).toContain('Then return a brief, concrete summary');
expect(opts.prompt).toContain('natively Read plan-design-review/SKILL.md');
expect(opts.prompt).toContain('plan-design-review/sections/review-sections.md (the one lazy section this review requires)');
expect(opts.prompt).toContain('including the report, under 14,000 characters');
expect(opts.prompt).toContain('including the report, to about 10,000 characters; this is a drafting target, not a check, so do not count characters or trim after saving');
expect(opts.prompt).toContain('in at most ten lines');
expect(opts.prompt).toContain('execute every required pass and lazy-section Read');
expect(opts.prompt).toContain('Retain all required report fields, design decisions, diagrams, ratings, and explanations');
+1 -1
View File
@@ -462,7 +462,7 @@ Review the plan in ./plan.md. Its design gaps are vague "clean, modern UI" and "
Use this non-interactive delivery sequence:
1. Skip the preamble bash block and any AskUserQuestion calls. Read every lazy section the workflow requires: in one response, natively Read plan-design-review/SKILL.md (Read the remainder with offset if the first Read stops early), plan-design-review/sections/review-sections.md (the one lazy section this review requires) and plan.md. No cat, sed, ls, manifest or git exploration is needed. Review all 7 design passes. Rate each scored design dimension 0-10 and explain what would make it a 10; preserve the unresolved-decisions pass and every required design decision.
2. EDIT plan.md with the missing design decisions (interaction state table, empty states, responsive behavior, etc.) and the full required review report. Keep the saved review compact: use the canonical tables and decision IDs. Specify each design requirement once; refer to its section or decision ID from other pass rationales, tasks, and report cells instead of repeating that specification. Give concise score rationales and 10/10 explanations. Retain all required report fields, design decisions, diagrams, ratings, and explanations. Keep everything you add to plan.md, including the report, under 14,000 characters.
2. EDIT plan.md with the missing design decisions (interaction state table, empty states, responsive behavior, etc.) and the full required review report. Keep the saved review compact: use the canonical tables and decision IDs. Specify each design requirement once; refer to its section or decision ID from other pass rationales, tasks, and report cells instead of repeating that specification. Give concise score rationales and 10/10 explanations. Retain all required report fields, design decisions, diagrams, ratings, and explanations. Draft your plan.md additions, including the report, to about 10,000 characters; this is a drafting target, not a check, so do not count characters or trim after saving.
3. Persist that complete plan and review with Write before publishing a completed walkthrough or saying a fix is applied. Read plan.md back to verify the saved changes.
4. Then return a brief, concrete summary of the design changes in at most ten lines; do not repeat the full review in the response. This changes presentation only: execute every required pass and lazy-section Read.