CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-11-01 06:24:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: derive the too-old review_scope minimum from the constant

Browse Source 
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
garrytanandcapy-ai[bot] committed 2026-10-26 21:49:32 +00:00
1 parent 55ef03dbe8
commit 9ea5bfded5
1 file changed
+3 -2
Download Patch File Download Diff File Expand all files Collapse all files
test/gstack-ship-policy.test.ts
+3 -2
View File
@@ -34,8 +34,9 @@ describe('validatePolicy (schema + containment, pure)', () => {
expect(codes({ review_scope: 'all' })).toEqual(['POLICY_INVALID:review_scope']);
expect(codes({ review_scope: 'all', min_gstack_version: REVIEW_SCOPE_KEY_VERSION })).toEqual([]);
expect(codes({ review_scope: 'diff-plus-blocking', min_gstack_version: REVIEW_SCOPE_KEY_VERSION })).toEqual([]);
// The constant is the release that first read the key (1.91.256.0, #3481); an earlier minimum would admit a gstack that fails on the unknown key.
expect(codes({ review_scope: 'all', min_gstack_version: '1.91.249.0' })).toEqual(['POLICY_INVALID:review_scope']);
// The constant is the release that first read the key; any earlier minimum would admit a gstack that fails on the unknown key.
const earlier = REVIEW_SCOPE_KEY_VERSION.replace(/(\d+)\.0$/, (_, p) => `${Number(p) - 7}.0`);
expect(codes({ review_scope: 'all', min_gstack_version: earlier })).toEqual(['POLICY_INVALID:review_scope']);
expect(codes({ review_scope: 'frozen' })).toEqual([]);
expect(codes([])).toEqual(['POLICY_INVALID:']);
});