CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-07 22:16:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove remaining Rails-isms from retro and review templates

Browse Source 
- retro: app/services/ → src/services/ in examples and JSON schema
- review: app/models/post.rb → src/models/post.ts in example output

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-17 22:15:17 -07:00
parent 37b9badf4b
commit b8790f0e09
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
retro/SKILL.md
+3 -3
View File
@@ -240,7 +240,7 @@ Then show a **per-author leaderboard** immediately below:
``` ```
Contributor Commits +/- Top area Contributor Commits +/- Top area
You (garry) 32 +2400/-300 browse/ You (garry) 32 +2400/-300 browse/
alice 12 +800/-150 app/services/ alice 12 +800/-150 src/services/
bob 3 +120/-40 tests/ bob 3 +120/-40 tests/
``` ```
@@ -325,7 +325,7 @@ From commit diffs, estimate PR sizes and bucket them:
### Step 8: Focus Score + Ship of the Week ### Step 8: Focus Score + Ship of the Week
**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `app/services/`, `app/views/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (app/services/)" **Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `src/`, `lib/`, `components/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (src/services/)"
**Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it: **Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it:
- PR number and title - PR number and title
@@ -443,7 +443,7 @@ Use the Write tool to save the JSON file with this schema:
}, },
"authors": { "authors": {
"Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" }, "Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" },
"Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "app/services/" } "Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "src/services/" }
}, },
"version_range": ["1.16.0.0", "1.16.1.0"], "version_range": ["1.16.0.0", "1.16.1.0"],
"streak_days": 47, "streak_days": 47,
retro/SKILL.md.tmpl
+3 -3
View File
@@ -136,7 +136,7 @@ Then show a **per-author leaderboard** immediately below:
``` ```
Contributor Commits +/- Top area Contributor Commits +/- Top area
You (garry) 32 +2400/-300 browse/ You (garry) 32 +2400/-300 browse/
alice 12 +800/-150 app/services/ alice 12 +800/-150 src/services/
bob 3 +120/-40 tests/ bob 3 +120/-40 tests/
``` ```
@@ -221,7 +221,7 @@ From commit diffs, estimate PR sizes and bucket them:
### Step 8: Focus Score + Ship of the Week ### Step 8: Focus Score + Ship of the Week
**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `app/services/`, `app/views/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (app/services/)" **Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `src/`, `lib/`, `components/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (src/services/)"
**Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it: **Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it:
- PR number and title - PR number and title
@@ -339,7 +339,7 @@ Use the Write tool to save the JSON file with this schema:
}, },
"authors": { "authors": {
"Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" }, "Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" },
"Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "app/services/" } "Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "src/services/" }
}, },
"version_range": ["1.16.0.0", "1.16.1.0"], "version_range": ["1.16.0.0", "1.16.1.0"],
"streak_days": 47, "streak_days": 47,
review/SKILL.md
+2 -2
View File
@@ -264,11 +264,11 @@ Example format:
``` ```
I auto-fixed 5 issues. 2 need your input: I auto-fixed 5 issues. 2 need your input:
1. [CRITICAL] app/models/post.rb:42 — Race condition in status transition 1. [CRITICAL] src/models/post.ts:42 — Race condition in status transition
Fix: Add `WHERE status = 'draft'` to the UPDATE Fix: Add `WHERE status = 'draft'` to the UPDATE
→ A) Fix B) Skip → A) Fix B) Skip
2. [INFORMATIONAL] app/services/generator.rb:88 — LLM output not type-checked before DB write 2. [INFORMATIONAL] src/services/generator.py:88 — LLM output not type-checked before DB write
Fix: Add JSON schema validation Fix: Add JSON schema validation
→ A) Fix B) Skip → A) Fix B) Skip
review/SKILL.md.tmpl
+2 -2
View File
@@ -112,11 +112,11 @@ Example format:
``` ```
I auto-fixed 5 issues. 2 need your input: I auto-fixed 5 issues. 2 need your input:
1. [CRITICAL] app/models/post.rb:42 — Race condition in status transition 1. [CRITICAL] src/models/post.ts:42 — Race condition in status transition
Fix: Add `WHERE status = 'draft'` to the UPDATE Fix: Add `WHERE status = 'draft'` to the UPDATE
→ A) Fix B) Skip → A) Fix B) Skip
2. [INFORMATIONAL] app/services/generator.rb:88 — LLM output not type-checked before DB write 2. [INFORMATIONAL] src/services/generator.py:88 — LLM output not type-checked before DB write
Fix: Add JSON schema validation Fix: Add JSON schema validation
→ A) Fix B) Skip → A) Fix B) Skip