CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-20 20:00:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

plan-eng-review: verify server-gated UI outcomes

Browse Source 
Reconstructs PR #1874 from its source template and generated section.
This commit is contained in:
t
2026-07-14 11:10:59 -07:00
parent 2e3695339e
commit bb57306d98
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plan-eng-review/sections/review-sections.md
+1
View File
@@ -126,6 +126,7 @@ Evaluate:
* Code organization and module structure.
* DRY violations—be aggressive here.
* Error handling patterns and missing edge cases (call these out explicitly).
* Server-gated or actuated actions with optimistic UI—does the client await and surface the real result, or assume success? A swallowed rejection (auth/permission/validation) renders as false success; verify the effect landed, not the toast.
* Technical debt hotspots.
* Areas that are over-engineered or under-engineered relative to my preferences.
* Existing ASCII diagrams in touched files — are they still accurate after this change?
plan-eng-review/sections/review-sections.md.tmpl
+1
View File
@@ -28,6 +28,7 @@ Evaluate:
* Code organization and module structure.
* DRY violations—be aggressive here.
* Error handling patterns and missing edge cases (call these out explicitly).
* Server-gated or actuated actions with optimistic UI—does the client await and surface the real result, or assume success? A swallowed rejection (auth/permission/validation) renders as false success; verify the effect landed, not the toast.
* Technical debt hotspots.
* Areas that are over-engineered or under-engineered relative to my preferences.
* Existing ASCII diagrams in touched files — are they still accurate after this change?