mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-01 06:24:41 +01:00
docs: note the constant and @-filename redact exemptions; CHANGELOG under Unreleased
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
566641d44f
commit
bb5b6c665d
2 files changed
+28
No files matched your search
@@ -1,5 +1,16 @@
|
||||
# Changelog
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
**The PII scanner stops flagging two kinds of ordinary text: a bare power-of-two or hash constant in code, and a package@version-style filename.** Eval artifacts and PR bodies that print a PRNG range or name a versioned results file no longer raise a MEDIUM phone or email finding, and real phone numbers and addresses next to them still report.
|
||||
|
||||
### Fixed
|
||||
- **`lib/redact-patterns.ts`**: `pii.phone.e164` skips a bare number that is exactly a power of two from 2^30 through 2^49, one less than one, or one of eleven well-known 32-bit hash and PRNG constants. The same digits written with a `+`, spaces, dashes, dots or parentheses still report (#3577).
|
||||
- **`lib/redact-patterns.ts`**: `pii.email` skips a filename whose part after the `@` is a version or tag followed by file extensions no top-level domain uses, or a dotted version followed by an extension that doubles as one. A file named after a real address, an address at a numeric domain such as 163.com, and an address under a top-level domain that doubles as an extension (`.sh`, `.md`) still report (#3576).
|
||||
|
||||
### Tests
|
||||
- `test/redact-constant-and-at-filename.test.ts`: pins both exemptions in both directions, including files named after a real address.
|
||||
|
||||
## [1.91.304.0] - 2026-10-29
|
||||
|
||||
**Running the Capy installer for a second workflow on the same machine no longer takes away the first one's admission.** /ship's docs step runs `scripts/install.sh --for document-release`, and that run replaced the `--for ship` install verdict with its narrower one, so the rest of /ship refused with "the install verdict certified for=document-release, which does not cover codex that ship needs" until someone reran `--for ship` (#3561, seen on gstack-evals#13).
|
||||
|
||||
@@ -2388,6 +2388,14 @@ and an E.164 `+14155551234` still report, so the finding means the id stands
|
||||
without a run word (`the id is 40269992077`, `40269992077 failed`) or follows
|
||||
a word that is not one (`see 40323989742`).
|
||||
|
||||
Separately, the scanner skips a bare number that is exactly a power of two
|
||||
from 2^30 through 2^49, one less than such a power, or one of eleven 32-bit
|
||||
hash and PRNG constants (Knuth's multiplicative hash, the golden-ratio
|
||||
constant, the glibc and Numerical Recipes LCGs, FNV-1a, MurmurHash2 and 3, the
|
||||
MT19937 seeder and the largest 32-bit prime; `isNumericConstant` in
|
||||
`lib/redact-patterns.ts`). Only the exact digits with no separator are exempt:
|
||||
the same digits with a `+`, spaces, dashes, dots or parentheses still report.
|
||||
|
||||
**Fix.** Write the id next to a run word (`run 40269992077`) or as an
|
||||
`/actions/runs/` link. For anything else, rerun with `--confirm <token>`
|
||||
using the `TOKEN:` line the refusal printed; MEDIUM findings do not block
|
||||
@@ -2428,6 +2436,15 @@ An address only another remote knows still reports. If the hook also printed
|
||||
`existing-email suppression was limited for this push`, it could not read the
|
||||
history in 5 seconds, so known authors may be listed too.
|
||||
|
||||
A filename with an `@` in the package@version style is not an address and
|
||||
never reports: the part after the `@` is a version or tag (one dotless label
|
||||
or a dotted version, never a domain name) followed by file extensions no
|
||||
top-level domain uses, or a dotted all-digit version followed by
|
||||
an extension that doubles as a top-level domain (`looksLikeAtFilename` in
|
||||
`lib/redact-patterns.ts`). A file named after a real address, an address at an
|
||||
all-digit domain and an address whose top-level domain doubles as a file
|
||||
extension still report.
|
||||
|
||||
**Fix.** Remove the address, or allow it for this repo:
|
||||
`git config --add gstack.redact.allowEmail <address>`. If it is your own
|
||||
address, check `git config user.email`. The allowlist only covers `pii.email`;
|
||||
|
||||
Reference in new issue
Block a user