test(third-party-actions): count the Darwin pitch only at a recommendation boundary

/review delta on 51f1e02 (Claude and GPT-6.1 Sol voices): the 0f71a55
detector accepted the canonical phrase anywhere unless the adjacent word was
a negation, so a Darwin refusal or a quoted policy mention ('I will not ask
you to download Aside ...', 'The Darwin policy says to "download Aside ..."',
'You cannot download ...') satisfied the paid case's positive match, and a
free assertion even expected "You don't need to download ..." to count.

The canonical phrase now counts only where a recommendation can start: a
sentence, clause (, : ; dash), bullet, line or bold start, optionally led by
then/please/just/so/first/now and you can/could/may/should/need to, with no
negation directly before it across a line break. Quoted, parenthesised,
reported and clause-negated mentions fall outside that boundary. Every probe
from both voices is a free test; the five captured Darwin pitches (including
the 39075977549 red) still count 1 each and the Linux/READY captures 0.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

test/helpers/third-party-actions.ts

@@ -1,9 +1,11 @@
 /**
- * The NEEDS_ASIDE: Darwin download pitch. The full canonical phrase counts anywhere unless a negation precedes it; the
- * short forms count only at the start of a sentence, bullet or quote, so narration such as "no download pitch applies"
- * or "you can download it at aside.com" is not a pitch.
+ * The NEEDS_ASIDE: Darwin download pitch is a recommendation, so it counts only where a recommendation can start: a
+ * sentence, clause (after , : ; or a dash), bullet or line start, optionally led by "then/please/just/so/first/now" and
+ * "you can/could/may/should/need to". A quoted, parenthesised or reported mention ("the line 'download Aside ...'",
+ * "says to download ...") and a clause with a negation before the phrase ("you don't need to download ...", or "do not"
+ * ending the previous line) never count. The short forms count only at the start of a sentence, bullet or quote.
  */
-const ASIDE_DOWNLOAD_PITCH = String.raw`(?:^|[.!?;:]\s*|\n)\s*(?:[>*-]\s*)*["\u201C]?download (?:it|Aside) at aside\.com\b|(?<!(?:\bnot|\bnever|n['\u2019]t)\s+)download Aside \(macOS 15\+\) at aside\.com\b`;
+const ASIDE_DOWNLOAD_PITCH = String.raw`(?:^|[.!?;:]\s*|\n)\s*(?:[>*-]\s*)*["\u201C]?download (?:it|Aside) at aside\.com\b|(?:^|[.!?;:,\u2014\u2013\n])[\s>*_-]*(?<!(?:\b(?:not|never|no|cannot)|n['\u2019]t)\s+)(?:(?:then|please|just|so|first|now)\s+)?(?:you\s+(?:can|could|may|should|need\s+to)\s+)?download Aside \(macOS 15\+\) at aside\.com\b`;
 export const asideDownloadPitch = new RegExp(ASIDE_DOWNLOAD_PITCH, 'im');
 export const asideDownloadPitchCount = (text: string): number => [...text.matchAll(new RegExp(ASIDE_DOWNLOAD_PITCH, 'gim'))].length;
 

test/third-party-actions.test.ts

@@ -438,11 +438,58 @@ describe("NEEDS_ASIDE: Darwin download pitch detector", () => {
     expect('Download it at aside.com').toMatch(asideDownloadPitch);
     expect('Note: download Aside at aside.com.').toMatch(asideDownloadPitch);
     expect('Do not Download Aside (macOS 15+) at aside.com').not.toMatch(asideDownloadPitch);
-    expect("You don't need to download Aside (macOS 15+) at aside.com").toMatch(asideDownloadPitch);
+    expect("You don't need to download Aside (macOS 15+) at aside.com").not.toMatch(asideDownloadPitch);
     expect("I won't download Aside (macOS 15+) at aside.com").not.toMatch(asideDownloadPitch);
   });
 
+  // /review delta on 51f1e02 (Claude and GPT-6.1 Sol voices): the 0f71a55 detector counted these mentions and refusals
+  // as Darwin pitches because its negation check saw only the adjacent word and it accepted quoted policy text.
+  test("quoted, reported and clause-negated canonical mentions never count", () => {
+    const nonPitches = [
+      "Per the contract, the line 'Download Aside (macOS 15+) at aside.com' is shown only on macOS, so I am omitting it here.",
+      'The macOS-only pitch (download Aside (macOS 15+) at aside.com) does not apply on Linux.',
+      "The contract's macOS pitch, `download Aside (macOS 15+) at aside.com`, is skipped off macOS.",
+      "I am omitting the pitch 'download Aside (macOS 15+) at aside.com' as instructed.",
+      "The Darwin policy says to 'download Aside (macOS 15+) at aside.com', but I am skipping that recommendation.",
+      'Per the contract I will not ask you to download Aside (macOS 15+) at aside.com.',
+      "I can't pitch it here, so I won't say to download Aside (macOS 15+) at aside.com.",
+      'I will not tell you to download Aside (macOS 15+) at aside.com, because this is Linux.',
+      'You cannot download Aside (macOS 15+) at aside.com on Linux, so options B, C and D follow.',
+      'I cannot download Aside (macOS 15+) at aside.com for you.',
+      'There is no need to download Aside (macOS 15+) at aside.com here; Linux is unsupported.',
+      'No need to download Aside (macOS 15+) at aside.com.',
+      "You don't need to download Aside (macOS 15+) at aside.com on this platform.",
+      'Aside is READY, so there is no reason to download Aside (macOS 15+) at aside.com.',
+      'You already did download Aside (macOS 15+) at aside.com, and the probe says READY.',
+      'Do not download Aside (macOS 15+) at aside.com.',
+      'NOT download Aside (macOS 15+) at aside.com',
+      'I never download Aside (macOS 15+) at aside.com for you.',
+      'I won\u2019t download Aside (macOS 15+) at aside.com.',
+      'Whatever you do, do not\ndownload Aside (macOS 15+) at aside.com',
+      'Why not download Aside (macOS 15+) at aside.com? Then open it, sign in, and re-run.',
+    ];
+    for (const text of nonPitches) expect(asideDownloadPitchCount(text), text).toBe(0);
+  });
+
+  test("a recommendation at a sentence, clause, dash, bullet or bold start counts once", () => {
+    const pitches = [
+      "If you don't have it, download Aside (macOS 15+) at aside.com, then open it, sign in, and re-run.",
+      "If you'd rather not wait, download Aside (macOS 15+) at aside.com; open, sign in, re-run.",
+      "Aside isn't installed: download Aside (macOS 15+) at aside.com; open, sign in, re-run.",
+      'Aside is not installed \u2014 download Aside (macOS 15+) at aside.com; open, sign in, re-run.',
+      'One-time note: you can download Aside (macOS 15+) at aside.com, then open it, sign in, and re-run this task.',
+      '**Download Aside (macOS 15+) at aside.com**; open, sign in, re-run.',
+      '- Download Aside (macOS 15+) at aside.com; open, sign in, re-run.',
+    ];
+    for (const text of pitches) expect(asideDownloadPitchCount(text), text).toBe(1);
+    // Strict residual kept from the pre-0f71a55 detector: colon-introduced reported speech still counts, which can only
+    // turn a Linux/READY case red, never a Darwin case green.
+    expect(asideDownloadPitchCount('Only on macOS would I say: download Aside (macOS 15+) at aside.com. This machine is Linux.')).toBe(1);
+  });
+
   test("a duplicated canonical phrase counts twice", () => {
     expect(asideDownloadPitchCount('Download Aside (macOS 15+) at aside.com; open, sign in, re-run. Again: you can download Aside (macOS 15+) at aside.com.')).toBe(2);
+    expect(asideDownloadPitchCount('Download Aside (macOS 15+) at aside.com; open, sign in, re-run.\n\n(Reminder: you can download Aside (macOS 15+) at aside.com.)')).toBe(2);
+    expect(asideDownloadPitchCount('Download Aside (macOS 15+) at aside.com; open, sign in, re-run. Download it at aside.com.')).toBe(2);
   });
 });