mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-06 17:04:27 +01:00
test(placeholders): allow the craft audit page path placeholder (GSTA-92)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
d0fde6a6e7
commit
db6eab82fb
2 files changed
+2
No files matched your search
@@ -22,6 +22,7 @@
|
||||
### Tests
|
||||
- `test/design-craft.test.ts`: every tell with its count; a finished page, inlined Pretext, a `100vh` line with its `100dvh` fallback, discount copy and in-page anchors stay clean; look-alike attributes, encoded markers, `!important` and reversed fallbacks; skip links judged by position and target in any language; the craft section's banned words and names all flagged; CLI exit codes.
|
||||
- `design-html-slop-gate` also requires the craft check to run once or twice; the design-html carve guard requires the craft section read.
|
||||
- `test/helpers/placeholder-allowlist.ts` lists `<path-to-page.html>` (path grammar), the saved page the craft audit passes to the check.
|
||||
- The design-review and plan-design-review paid cases and judges that read a design resolver now also select on `scripts/resolvers/design-craft.ts`, and `design-html-slop-gate` on `lib/design-catalog.ts`, where the craft check's ids and fixes now live.
|
||||
- `design-html-slop-gate` is now selected by changes to `lib/design-craft.ts` and `bin/gstack-design-craft` (`test/helpers/touchfiles-data.ts`), which it already exercised but did not list.
|
||||
- `test/design-craft.test.ts` also covers accepted exceptions: count coverage and overflow, the finalized.json block in design-html/SKILL.md parsed by the same reader the CLI uses, rejected malformed lists, CLI exit codes with `--accepted`, and the archetype handoff contract (the same four ids in /design-shotgun and the craft section, the approved.json step, Case A and the craft section's no-re-ask rule).
|
||||
|
||||
@@ -139,6 +139,7 @@ export const IDENTIFIER_PLACEHOLDERS: Record<string, IdentifierGrammar> = {
|
||||
'<plan-path>': { grammar: PATH, what: 'bound plan file path' },
|
||||
'<sketch-dir>': { grammar: PATH, what: 'sketch directory printed by an earlier block' },
|
||||
'<path-to-finalized.html>': { grammar: PATH, what: 'finalized HTML path' },
|
||||
'<path-to-page.html>': { grammar: PATH, what: 'saved page HTML path' },
|
||||
'<finalized.html>': { grammar: PATH, what: 'finalized HTML path' },
|
||||
'<approved-variant.png>': { grammar: PATH, what: 'approved variant image path' },
|
||||
'<failing-test-file>': { grammar: PATH, what: 'test file path' },
|
||||
|
||||
Reference in new issue
Block a user