CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-10-31 22:14:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: the batched reviewer reads its checklists by path, as the render CLI is given them (PR #3665 review)

Browse Source 
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
garrytanandcapy-ai[bot] committed 2026-10-31 04:07:59 +00:00
1 parent 2cd4facaad
commit e745ee9aea
2 files changed
+5 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

lib/review-pass.ts
+2 -1
View File
@@ -130,7 +130,8 @@ export function renderStage(m: Manifest, stage: Stage, t: SectionTexts, diffFor:
continue;
}
const role = r.role!;
const slots: Slots = { name: r.name, diff_base: m.diff_base, exclude: r.exclude, stack: m.stack, test_fw: m.test_fw, learnings: m.learnings ?? undefined, checklists: r.checklists?.join(',') };
const slots: Slots = { name: r.name, diff_base: m.diff_base, exclude: r.exclude, stack: m.stack, test_fw: m.test_fw, learnings: m.learnings ?? undefined,
checklists: r.checklists?.map(n => path.join(m.checklist_root, 'review/specialists', `${n}.md`)).join(',') };
if (role === 'specialist') slots.checklist = path.join(m.checklist_root, 'review/specialists', `${r.name}.md`);
let findingsSha: string | undefined;
if (role === 'red-team') {
test/review-pass.test.ts
+3
View File
@@ -37,6 +37,9 @@ describe('pass manifest', () => {
const light = manifest([{ role: 'specialist', name: 'batched', effort: 'full', exclude: [':(exclude)docs/a.md'], checklists: ['testing', 'red-team'] }]);
expect(light.readers[0]).toMatchObject({ reader: 'specialist-batched', role: 'specialist-batched', exclude: "-- . ':(exclude)docs/a.md'", checklists: ['testing', 'red-team'] });
expect(() => manifest([{ role: 'fix-check', name: 'fix-check', effort: 'full', exclude: [] }])).toThrow(/fix-check runs on its own/);
// PR #3665 review: the batched reviewer reads each checklist by path, as the render CLI is given them, never by bare name.
renderStage(light, 'specialists', texts, () => '');
expect(fs.readFileSync(light.readers[0]!.file!, 'utf8')).toContain(`Read each checklist at ${path.join(ROOT, 'review/specialists/testing.md')}, ${path.join(ROOT, 'review/specialists/red-team.md')} (tag each finding`);
});
test('a manifest render is byte for byte the render CLI\'s brief for the same slots', () => {