Files
Garry Tanandcapy-ai[bot] 9c7b4c81ca v1.91.183.0 fix(evals): a rejected API key is INFRA, never 131 assertion reds and reruns (#3361)
* fix(evals): a rejected API key is INFRA, never 131 assertion reds and reruns

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test: register the credential-rejection fixture as free

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test: keep the credential-rejection CLI replay off the Windows subset, like paid-rerun

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test: name the Windows run in the curation reason

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* v1.91.183.0 fix(evals): a rejected API key is INFRA, never 131 assertion reds and reruns (#3361)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-10-23 18:05:39 +00:00

111 lines
4.8 KiB
TypeScript

/**
* The one PTY session loop (runPtySession) and its launch seam (PtyDriver).
* Owns launch, the poll/deadline loop, failure capture and close/cleanup
* ordering; each runner in pty/runners/ supplies its policy as a PtySessionPlan
* (start, poll, tick, timeout, capture hooks). New runner: build a plan and
* `return runPtySession(plan)`; tests pass the fake driver from fake-session.ts.
* Size ratchet (c) binds this module. Moved from the three runner loops of the
* former claude-pty-runner.ts. Tests import through claude-pty-runner.ts.
*/
import { launchClaudePty, type ClaudePtyOptions, type ClaudePtySession } from './launch';
import { screenPanelEnd } from './screen';
import { appendSessionLedger, sessionKey, type SessionEnd } from '../session-ledger';
/**
* The runners' launch seam: how a session starts, and the clock the runner
* loop reads. Omitted in production (real launcher, Date.now,
* performance.now, Bun.sleep); tests pass the fake driver from
* test/helpers/pty/fake-session.ts.
*/
export interface PtyDriver {
launch(opts: ClaudePtyOptions): Promise<ClaudePtySession>;
/** Wall clock, Date.now() semantics. */
now(): number;
/** Monotonic clock, performance.now() semantics. */
monotonic(): number;
sleep(ms: number): Promise<void>;
}
export const realPtyDriver: PtyDriver = {
launch: opts => launchClaudePty(opts),
now: () => Date.now(),
monotonic: () => performance.now(),
sleep: ms => Bun.sleep(ms),
};
/** The session's end panel (screenPanelEnd), if the session can show its text; diagnostics never throw. */
export function safePanelEnd(session: Pick<ClaudePtySession, 'visibleText'>): ReturnType<typeof screenPanelEnd> {
try { return screenPanelEnd(session.visibleText()); } catch { return null; }
}
/** One poll step: finish with a result, keep polling, or end the loop as a timeout. */
export type PtyStep<R> = { done: R } | 'continue' | 'break';
export interface PtySessionPlan<R> {
driver: PtyDriver;
launch: ClaudePtyOptions;
/** The observation budget the runner armed (session ledger); defaults to the launch wall. */
budgetMs?: number;
/** Owned fixture cleanup; runs after close, and when launch itself fails. */
cleanup?: () => void;
/** Boot and command submission. A returned result ends the run before polling. */
start(session: ClaudePtySession): Promise<R | undefined>;
/** Wait for the next poll. False means the deadline passed: the run times out. */
poll(session: ClaudePtySession): Promise<boolean>;
tick(session: ClaudePtySession): Promise<PtyStep<R>>;
timeout(session: ClaudePtySession): R;
/** Snapshot a thrown run before close; the original error is rethrown. */
onError?(session: ClaudePtySession, error: unknown): void;
/** Always runs before close. A throw here fails an otherwise successful run. */
beforeClose?(session: ClaudePtySession, failure: { error: unknown } | undefined): void;
/** Close failed after a successful run; the close error is rethrown. */
onCloseError?(session: ClaudePtySession, error: unknown): void;
}
/**
* launch → start → (poll → tick)* → timeout, with one failure contract: a
* run's own error wins over capture and close errors, close always runs, and
* owned cleanup runs last.
*/
export async function runPtySession<R>(plan: PtySessionPlan<R>): Promise<R> {
const started = plan.driver.monotonic();
const startedAt = new Date(plan.driver.now()).toISOString();
let end: SessionEnd = 'error';
let session: ClaudePtySession;
try {
session = await plan.driver.launch({ ...plan.launch, sessionLedger: false });
} catch (error) {
plan.cleanup?.();
throw error;
}
let failure: { error: unknown } | undefined;
try {
const ended = (result: R) => { end = (result as { outcome?: unknown })?.outcome === 'timeout' ? 'observer_timeout' : 'completed'; return result; };
const early = await plan.start(session);
if (early !== undefined) return ended(early);
while (await plan.poll(session)) {
const step = await plan.tick(session);
if (step === 'break') break;
if (step !== 'continue') return ended(step.done);
}
end = 'observer_timeout';
return plan.timeout(session);
} catch (error) {
failure = { error };
plan.onError?.(session, error);
throw error;
} finally {
appendSessionLedger({ key: sessionKey('pty', undefined), runner: 'pty', started_at: startedAt,
budget_ms: plan.budgetMs ?? plan.launch.timeoutMs ?? 240_000, elapsed_ms: plan.driver.monotonic() - started,
end, ...safePanelEnd(session), billed: false });
try {
try { plan.beforeClose?.(session, failure); }
catch (error) { if (!failure) { failure = { error }; throw error; } }
finally {
try { await session.close(); }
catch (error) { if (!failure) { plan.onCloseError?.(session, error); throw error; } }
}
} finally { plan.cleanup?.(); }
}
}