mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-26 22:51:47 +02:00
Garry TanandOpenAI Codex
06ed920a97
* feat: bind shared-code review advice to source and branch * feat: add shared-code extraction audit and scoped review checks * test: recognize complete source reads and explicit coverage legends * chore: bump version and changelog (v1.88.0.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: capture native review questions and retain public evidence Capture the actual first public native question with strict ownership and display matching. Preserve terminal failures and raw evidence, and retain SDK completion checks. * test: recognize verified review evidence and complete fixtures Recognize complete source and diagram evidence, concrete design and developer-experience decisions, and the complete planted scenario contracts. Preserve negative controls and grading thresholds. * fix: preserve decision brief structure in native questions Keep the required pros-and-cons heading and final Net field in native question text. Regenerate host outputs and document the release and evaluation repairs. Co-Authored-By: OpenAI Codex <noreply@openai.com> * docs: update project documentation for v1.88.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: correct eval retry accounting and ship workflow gates * fix: capture native eval evidence and stabilize CI fixtures * fix: keep shared-code eval skips read-only Choose explicit no-change answers instead of mixed fix/preservation options. Reuse the bounded revalidation prompt for path fixtures so required review metadata is available without repeated discovery. Preserve source checks, retry limits, and failed native terminal outcomes. Add captured-question and callback regressions, plus evaluation selection coverage for the affected fixtures. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
46 lines
2.4 KiB
Markdown
46 lines
2.4 KiB
Markdown
# Maintainability Specialist Review Checklist
|
|
|
|
Scope: Always-on (every review)
|
|
Output: JSON objects, one finding per line. Schema:
|
|
{"severity":"INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"maintainability","summary":"...","fix":"...","fingerprint":"path:line:maintainability","specialist":"maintainability"}
|
|
Optional: line, fix, fingerprint, evidence, test_stub.
|
|
If no findings: output `NO FINDINGS` and nothing else.
|
|
|
|
---
|
|
|
|
## Categories
|
|
|
|
### Dead Code & Unused Imports
|
|
- Variables assigned but never read in the changed files
|
|
- Functions/methods defined but never called (check with Grep across the repo)
|
|
- Imports/requires that are no longer referenced after the change
|
|
- Commented-out code blocks (either remove or explain why they exist)
|
|
|
|
### Magic Numbers & String Coupling
|
|
- Bare numeric literals used in logic (thresholds, limits, retry counts) — should be named constants
|
|
- Error message strings used as query filters or conditionals elsewhere
|
|
- Hardcoded URLs, ports, or hostnames that should be config
|
|
- Duplicated literal values across multiple files
|
|
|
|
### Stale Comments & Docstrings
|
|
- Comments that describe old behavior after the code was changed in this diff
|
|
- TODO/FIXME comments that reference completed work
|
|
- Docstrings with parameter lists that don't match the current function signature
|
|
- ASCII diagrams in comments that no longer match the code flow
|
|
|
|
### Duplicated Behavior with Defects
|
|
- Divergent copies that produce a demonstrated incorrect result, miss required error handling, or violate the same contract
|
|
- Report the concrete defect and its evidence through normal Fix-First handling; matching syntax or repeated line counts alone are not findings
|
|
- Optional shared-helper extractions belong to the core shared-code check. Do not duplicate its proposals or turn structural preferences into defects
|
|
|
|
### Conditional Side Effects
|
|
- Code paths that branch on a condition but forget a side effect on one branch
|
|
- Log messages that claim an action happened but the action was conditionally skipped
|
|
- State transitions where one branch updates related records but the other doesn't
|
|
- Event emissions that only fire on the happy path, missing error/edge paths
|
|
|
|
### Module Boundary Violations
|
|
- Reaching into another module's internal implementation (accessing private-by-convention methods)
|
|
- Direct database queries in controllers/views that should go through a service/model
|
|
- Tight coupling between components that should communicate through interfaces
|