Files
gstack/test/fixtures/shared-libs-index-flags-skip-question.json
T
Garry TanandOpenAI Codex 06ed920a97 v1.89.0.0 feat: add shared-code extraction audit (#2925)
* feat: bind shared-code review advice to source and branch

* feat: add shared-code extraction audit and scoped review checks

* test: recognize complete source reads and explicit coverage legends

* chore: bump version and changelog (v1.88.0.0)

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: capture native review questions and retain public evidence

Capture the actual first public native question with strict ownership and display matching. Preserve terminal failures and raw evidence, and retain SDK completion checks.

* test: recognize verified review evidence and complete fixtures

Recognize complete source and diagram evidence, concrete design and developer-experience decisions, and the complete planted scenario contracts. Preserve negative controls and grading thresholds.

* fix: preserve decision brief structure in native questions

Keep the required pros-and-cons heading and final Net field in native question text. Regenerate host outputs and document the release and evaluation repairs.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* docs: update project documentation for v1.88.0.0

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: correct eval retry accounting and ship workflow gates

* fix: capture native eval evidence and stabilize CI fixtures

* fix: keep shared-code eval skips read-only

Choose explicit no-change answers instead of mixed fix/preservation options.
Reuse the bounded revalidation prompt for path fixtures so required review
metadata is available without repeated discovery. Preserve source checks,
retry limits, and failed native terminal outcomes.

Add captured-question and callback regressions, plus evaluation selection
coverage for the affected fixtures.

---------

Co-authored-by: OpenAI Codex <noreply@openai.com>
2026-09-24 01:53:58 -04:00

66 lines
4.3 KiB
JSON

{
"sourceHead": "b9f6893e027ea128a92cf3cdb18dabfab2f227e2",
"ciMerge": "116ba1cc528e6bc6c6b31f65aa9f106a229bfb1a",
"qualification": "Failed fixture actor selected an affirmative fix instead of Skip. These are exact public native question/result blocks; subsequent source-preservation failure remains a failure.",
"events": [
{
"type": "assistant",
"message": {
"content": [
{
"type": "tool_use",
"id": "toolu_01PB3pA1sTW4DbQW68y53Mrx",
"name": "AskUserQuestion",
"input": {
"questions": [
{
"question": "[ADVISORY] src/retry-worker.ts:2 duplicates lib/retry-after.ts#retrySeconds verbatim (as does src/retry-route.ts at HEAD). Reuse the tested shared helper? RECOMMENDATION: Fix both — the copies are byte-identical, the helper is already tested and used by scheduler.ts, and there are no caller differences to preserve. Note: src/retry-route.ts has the skip-worktree flag set, so an edit to it will not appear in git status/diff until you run `git update-index --no-skip-worktree src/retry-route.ts`; I will not change index flags without your say-so.",
"header": "Shared helper",
"multiSelect": false,
"options": [
{
"label": "Fix both (Recommended)",
"description": "Replace src/retry-worker.ts and src/retry-route.ts bodies with `export { retrySeconds } from '../lib/retry-after';` (~-28 lines). Also clear the skip-worktree flag on retry-route.ts so the change is committable.",
"preview": "// src/retry-worker.ts\nexport { retrySeconds } from '../lib/retry-after';\n\n// src/retry-route.ts\nexport { retrySeconds } from '../lib/retry-after';\n\n// then: git update-index --no-skip-worktree src/retry-route.ts"
},
{
"label": "Fix both, leave index flag",
"description": "Same two edits, but do not touch the skip-worktree flag; retry-route.ts change stays local/hidden from git until you clear it yourself.",
"preview": "// src/retry-worker.ts\nexport { retrySeconds } from '../lib/retry-after';\n\n// src/retry-route.ts\nexport { retrySeconds } from '../lib/retry-after';\n\n// skip-worktree flag left as-is (change hidden from git)"
},
{
"label": "Fix worker only",
"description": "Restore the one-line re-export in src/retry-worker.ts (the file in this diff) only; leave src/retry-route.ts as a standalone copy.",
"preview": "// src/retry-worker.ts\nexport { retrySeconds } from '../lib/retry-after';\n\n// src/retry-route.ts unchanged (still a full copy)"
},
{
"label": "Skip",
"description": "Keep the inlined copy in the worker. Recorded as an explicit skipped advisory (excluded from score/defect counts).",
"preview": "// no edits; advisory persisted as action: \"skipped\"\n// coverage will exclude src/retry-route.ts (skip-worktree, raw bytes differ)"
}
]
}
]
},
"caller": {
"type": "direct"
}
}
]
}
},
{
"type": "user",
"message": {
"content": [
{
"type": "tool_result",
"content": "Your questions have been answered: \"[ADVISORY] src/retry-worker.ts:2 duplicates lib/retry-after.ts#retrySeconds verbatim (as does src/retry-route.ts at HEAD). Reuse the tested shared helper? RECOMMENDATION: Fix both — the copies are byte-identical, the helper is already tested and used by scheduler.ts, and there are no caller differences to preserve. Note: src/retry-route.ts has the skip-worktree flag set, so an edit to it will not appear in git status/diff until you run `git update-index --no-skip-worktree src/retry-route.ts`; I will not change index flags without your say-so.\"=\"Fix both, leave index flag\". You can now continue with these answers in mind.",
"tool_use_id": "toolu_01PB3pA1sTW4DbQW68y53Mrx"
}
]
}
}
]
}