Files
gstack/test/egress-lib.test.ts
T
Garry TanandClaude Fable 5 b5a951e623 v1.72.0.0 feat: Aside recommended driver for third-party web actions (#2710)
* fix(browse): never chmod shared, symlinked, or foreign-owned dirs to 0700

restrictDirectoryPermissions unconditionally chmodded its target. On hosts
where the process holds CAP_FOWNER (Docker as root, CI sandboxes) that
chmod SUCCEEDS on root-owned /tmp whenever a state file is configured
there (BROWSE_STATE_FILE=/tmp/x.json derives stateDir=/tmp), and a 0700
/tmp breaks access(2)-based checks machine-wide for every other process.

The POSIX branch now refuses shared sticky dirs, world-writable mounts
under root, foreign-owned dirs, and symlinked state dirs; refusals warn
once per process instead of failing silent; owned-but-unreadable dirs
keep their chmod self-repair; and the check-then-act race is closed with
fd-anchored O_NOFOLLOW + fstat/fchmod on a single inode.

Regression tests cover the sticky-dir, foreign-uid, mkdirSecure-reapply,
and symlinked-dir shapes.

* fix: hash with sha256sum before shasum on Linux (config slugs + setup verify)

shasum is perl/macOS; coreutils-only Linux ships sha256sum. Two call
sites hard-coded shasum: gstack-config's sha8_of/sha16 (so
resolve-user-slug exited 127 for any Linux user with a git email, the
Layer-3 fallback) and the generated bun-installer checksum snippet in
the browse/qa NEEDS_SETUP flow (spurious "checksum mismatch" on the
same distros). Both now resolve sha256sum first and fall back to
shasum -a 256.

New shim-PATH tests pin BOTH hasher branches of sha8_of to a known
vector and cover the sha8->sha16 collision escalation end to end.

* feat(contract): Aside is the recommended driver for third-party web actions

The Third-Party Web Actions contract (ship, spec, office-hours,
land-and-deploy, setup-deploy) now names the Aside AI browser as the
recommended driver: it acts across the user's real logged-in sessions,
which is what vendor-dashboard moments need. Supersedes the v1.65.0.0
de-Aside stance by explicit user directive (2026-08-27).

Detection is a runtime probe (command -v + aside --version under a
portable gtimeout/timeout/bare guard; nonzero exit = not detected).
Consent options render per detection state with Aside recommended and
the first-party stack ($B headed + handoff, GStack Browser) as the
universal fallback. Absent on macOS, the contract mentions the
aside.com download (macOS 15+) once per task; gstack never runs an
installer and binary presence is never consent. Drive discipline:
step-wise over whole-task delegation, vendor confirm mode on, vendor
skill/--help text scoped to operational syntax only, secrets minimized
(autofill / human-used copy buttons), Apple credential creation never a
drive target in any skill, failure path quotes redacted errors and
falls back only with fresh consent.

test/third-party-actions.test.ts pins every load-bearing sentence (21
tests) plus repo-wide tripwires: an aside command allowlist
(--version/--help only, code spans AND prose) and a ban on Aside
installer invocations across all generated docs. Budget ratchet
fixture and carve skeleton ceilings refreshed in this commit per the
ratchet protocol.

* chore: regenerate remaining browse-setup snippet consumers

The sha256sum-first checksum fallback in the generated NEEDS_SETUP
snippet renders into every browse-consuming skill, not just browse/qa.
Mechanical regen of the other ten consumers; no template changes here.

* test: consent-gate E2E suite + functional fs-capability probes

Five hermetic gate-tier E2E cases (tpa-present / absent-linux / broken /
absent-darwin / apple-ban) drive the real contract section through
claude -p with PATH shims for aside and uname; the absent cases filter
any REAL aside binary out of the child PATH and assert absence with
Bun.which before spawning, so dev machines cannot leak into detection.
Registered per-case in E2E_TOUCHFILES/E2E_TIERS with template-level
deps (ship/SKILL.md.tmpl, gen-skill-docs.ts) and added to the evals.yml
matrix with tier: gate. eval:bg:periodic's detach timeout rises to
36000s for the grown periodic shard census (floor-enforced by
test/eval-detach-timeout-floor.test.ts); CLAUDE.md doc updated to match.

test/helpers/fs-caps.ts adds canRevokeWrites/canRevokeReads functional
probes; 13 chmod-based tests swap their uid-0-only guards for the
probes so suites skip honestly on CAP_DAC_OVERRIDE containers (this
sandbox: uid 1000 with full caps) instead of asserting revocations the
kernel ignores. path-validation's symlink test targets /etc/passwd
(exists everywhere; /etc/crontab is absent on Amazon Linux).

* docs: file the Aside follow-ups in TODOS

Phase-2 QA logged-in-evidence path (P3), a hostile-vendor-skill E2E for
the contract's override sentence (P2), and fd-anchoring the file-level
permission writes to match the directory hardening (P3).

* chore: bump version and changelog (v1.72.0.0)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: update project documentation for v1.72.0.0

docs/skills.md: Third-Party Web Actions subsection under /ship (Aside
recommended driver, consent rules, credential boundaries). BROWSER.md:
"Aside and third-party drives" subsection under Real-browser mode + ToC
entry, including the no-gstack-side-audit-trail caveat (ship adversarial
finding 12). TODOS.md: mark the finding-12 doc note done.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: apply cross-model doc review fixes for v1.72.0.0

docs/skills.md: restore the /ship closing line above the new subsection.
BROWSER.md: ToC label matches the heading; BROWSE_STATE_FILE env row
documents the new dir-hardening refusal + one-time warning. CHANGELOG:
correct the hasher precedence wording (sha256sum first, shasum fallback)
and the fs-caps count (14 test files, verified against the diff).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: close cross-model doc-review gaps for v1.72.0.0

setup's manual bun-verify instruction gets the same sha256sum-first
fallback the automated snippet got (coreutils-only Linux); BROWSER.md's
BROWSE_STATE_FILE row now lists the under-root world-writable refusal;
test-cost ceilings in CLAUDE.md/CONTRIBUTING.md updated for the five
new gate E2E cases (~$4.20 E2E / ~$4.35 evals).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(test): gate the symlink-refusal test to POSIX and drop the umask assumption

The symlink regression test exercised the POSIX O_NOFOLLOW branch but ran
on Windows, where restrictDirectoryPermissions takes the icacls branch and
stat has no POSIX modes (0o666 always) — windows-free-tests failed on
mode 493 vs 438. Early-return on win32 like every sibling test in the
file, and assert the target's mode is UNCHANGED (captured post-mkdir)
instead of hardcoding 0o755, which a strict umask would also break.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-28 11:43:13 -07:00

187 lines
7.3 KiB
TypeScript

/**
* gstack-egress-lib.sh — shared shell receipt helpers, tested end-to-end
* against a local listener. Free tier, loopback only.
*
* Pins the shell-sink contract:
* - receipt sha256 == sha256 of the exact bytes the listener received
* (same file is hashed and handed to curl via --data-binary @file)
* - fail-closed refusal never touches the network and its stderr carries
* problem + cause + fix in plain language
* - fail-open warns on stderr and proceeds unrecorded
* - payload temp files are consumed immediately (no EXIT traps)
*/
import { describe, test, expect, beforeEach, afterEach, afterAll } from 'bun:test';
import { canRevokeWrites } from './helpers/fs-caps';
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';
import { listReceipts, sha256Hex } from '../lib/egress-receipt';
const ROOT = path.resolve(import.meta.path, '..', '..');
const LIB = path.join(ROOT, 'bin', 'gstack-egress-lib.sh');
const received: string[] = [];
const server = Bun.serve({
port: 0,
fetch: async (req) => {
received.push(await req.text());
return new Response('ok');
},
});
const URL_BASE = `http://127.0.0.1:${server.port}`;
afterAll(() => {
server.stop(true);
});
let home: string;
beforeEach(() => {
home = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-egress-lib-'));
received.length = 0;
});
afterEach(() => {
try { fs.chmodSync(path.join(home, 'security'), 0o700); } catch {}
fs.rmSync(home, { recursive: true, force: true });
});
// Async spawn: spawnSync would block Bun's event loop, deadlocking the
// in-process listener the script curls against.
async function runBash(script: string) {
const proc = Bun.spawn(['bash', '-c', script], {
env: { ...process.env, GSTACK_HOME: home },
stdout: 'pipe',
stderr: 'pipe',
});
const [stdout, stderr, status] = await Promise.all([
new Response(proc.stdout).text(),
new Response(proc.stderr).text(),
proc.exited,
]);
return { status, stdout, stderr };
}
describe('_receipted_curl', () => {
test('receipt sha256 equals sha256 of the body the listener received; payload file consumed', async () => {
const body = '[{"event":"lib-test","v":1}]';
const result = await runBash(`
set -uo pipefail
. "${LIB}"
payload="$(mktemp)"
printf '%s' '${body}' > "$payload"
echo "PAYLOAD_PATH=$payload"
_receipted_curl closed lib-test 127.0.0.1:${server.port} test-events "telemetry=community" "$payload" \\
curl -s --max-time 5 -X POST "${URL_BASE}/ingest"
echo "CURL_EXIT=$?"
[ -e "$payload" ] && echo "PAYLOAD_STILL_EXISTS" || echo "PAYLOAD_GONE"
`);
expect(result.status).toBe(0);
expect(result.stdout).toContain('CURL_EXIT=0');
expect(result.stdout).toContain('PAYLOAD_GONE');
expect(received.length).toBe(1);
expect(received[0]).toBe(body);
const receipts = listReceipts(home);
expect(receipts.length).toBe(1);
expect(receipts[0].sha256).toBe(sha256Hex(received[0]));
expect(receipts[0].bytes).toBe(Buffer.byteLength(body));
expect(receipts[0].sink).toBe('lib-test');
expect(receipts[0].status).toBe('exit:0'); // best-effort outcome joined
});
test('fail-closed refusal never hits the network; stderr is problem + cause + fix', async () => {
if (!canRevokeWrites()) return; // chmod is advisory here (win32, root, DAC-override containers)
fs.mkdirSync(path.join(home, 'security'), { recursive: true, mode: 0o500 });
const result = await runBash(`
set -uo pipefail
. "${LIB}"
payload="$(mktemp)"
printf '%s' 'secret payload' > "$payload"
_receipted_curl closed lib-test 127.0.0.1:${server.port} test-events "telemetry=community" "$payload" \\
curl -s --max-time 5 -X POST "${URL_BASE}/ingest"
status=$?
[ -e "$payload" ] && echo "PAYLOAD_STILL_EXISTS" || echo "PAYLOAD_GONE"
exit $status
`);
expect(result.status).toBe(3);
expect(received.length).toBe(0); // the send was refused, not attempted
expect(result.stdout).toContain('PAYLOAD_GONE'); // cleaned up on refusal too
// Problem: what did not happen.
expect(result.stderr).toContain('lib-test NOT sent');
// Cause: the bridge's typed error is quoted.
expect(result.stderr).toContain('EGRESS_RECEIPT_FAILED');
// Fix: an actionable command.
expect(result.stderr).toContain('Fix: chmod -R u+w');
// What this is: the ledger explained.
expect(result.stderr).toContain('ATTEMPTS to send off-machine');
expect(result.stderr).toContain('gstack-egress');
});
test('fail-open warns and proceeds when the receipt cannot be written', async () => {
if (!canRevokeWrites()) return; // chmod is advisory here (win32, root, DAC-override containers)
fs.mkdirSync(path.join(home, 'security'), { recursive: true, mode: 0o500 });
const result = await runBash(`
set -uo pipefail
. "${LIB}"
_receipted_curl open lib-open 127.0.0.1:${server.port} version-fetch "user ran --force" --no-payload \\
curl -s --max-time 5 "${URL_BASE}/VERSION"
`);
expect(result.status).toBe(0);
expect(received.length).toBe(1); // the send proceeded unrecorded
expect(result.stderr).toContain('sending anyway');
expect(result.stderr).toContain('lib-open');
});
test('--no-payload records sha256:null and does not append --data-binary', async () => {
const result = await runBash(`
set -uo pipefail
. "${LIB}"
_receipted_curl closed lib-get 127.0.0.1:${server.port} version-fetch "user ran --force" --no-payload \\
curl -s --max-time 5 "${URL_BASE}/VERSION"
`);
expect(result.status).toBe(0);
expect(received.length).toBe(1);
expect(received[0]).toBe(''); // GET, no body
const receipts = listReceipts(home);
expect(receipts.length).toBe(1);
expect(receipts[0].sha256).toBeNull();
expect(receipts[0].bytes).toBe(0);
});
});
describe('_receipted_git', () => {
test('writes a git-class sha256:null receipt then runs the command unmodified', async () => {
const result = await runBash(`
set -uo pipefail
. "${LIB}"
_receipted_git closed brain-sync github.com curated-memory-git-push "artifacts_sync_mode!=off" \\
bash -c 'echo GIT_RAN "$@"' _
`);
expect(result.status).toBe(0);
expect(result.stdout).toContain('GIT_RAN');
expect(result.stdout).not.toContain('--data-binary');
const receipts = listReceipts(home);
expect(receipts.length).toBe(1);
expect(receipts[0].sha256).toBeNull();
expect(receipts[0].payload_class).toBe('curated-memory-git-push');
expect(receipts[0].status).toBe('exit:0');
});
test('fail-closed git refusal returns 3 without running the command', async () => {
if (!canRevokeWrites()) return; // chmod is advisory here (win32, root, DAC-override containers)
fs.mkdirSync(path.join(home, 'security'), { recursive: true, mode: 0o500 });
const marker = path.join(os.tmpdir(), `gstack-egress-git-${process.pid}`);
fs.rmSync(marker, { force: true });
const result = await runBash(`
set -uo pipefail
. "${LIB}"
_receipted_git closed brain-sync github.com curated-memory-git-push "artifacts_sync_mode!=off" \\
touch "${marker}"
`);
expect(result.status).toBe(3);
expect(fs.existsSync(marker)).toBe(false); // command never ran
expect(result.stderr).toContain('brain-sync NOT sent');
});
});