mirror of
https://github.com/garrytan/gstack.git
synced 2026-08-20 13:07:17 +02:00
* fix(memory-ingest): pass --include-gitignored to gbrain import gstack-artifacts-init writes an ignore-everything .gitignore (a bare `*`, headed "Do not edit") at the root of ~/.gstack. The memory ingest stages pages into ~/.gstack/.staging-ingest-<pid>-<ts>/, which is inside that repo, and gbrain's markdown collector honours .gitignore. The collector therefore matches every staged file against `*` and collects zero. The failure is silent. gbrain import exits 0 having imported nothing while the ingest prints `written: N` from the STAGED count rather than the imported count, so a run that indexes nothing looks identical to a healthy one and the memory corpus quietly stops growing. Reproduction, using git's own ignore machinery (no gbrain needed): git init . mkdir -p .staging-ingest-12345/learnings echo x > .staging-ingest-12345/learnings/page.md printf '*\n' > .gitignore git ls-files --others --exclude-standard # -> empty Passing --include-gitignored makes the import independent of whatever .gitignore sits above the staging directory. Adding a negation to the generated .gitignore is the alternative, but that file is gstack-owned and marked "Do not edit", so any regeneration silently reintroduces the bug. Adds a regression pin in the shape of memory-ingest-no-put_page.test.ts, plus a behavioural test for the collision itself. Both source pins fail against the unpatched file. * fix(memory-ingest): GIT_CEILING_DIRECTORIES defense-in-depth on the import child (#2144) Second layer under #2560's --include-gitignored: a realpath'd ceiling at the staging dir's parent pushes any git-enumerating collector off the git fast path (which sees zero files under ~/.gstack's ignore-everything root) onto its plain FS walk, even on gbrain builds whose flag semantics drift. Ceiling is realpath'd because git compares canonicalized directories during discovery — a staging dir reached through a symlink (macOS /var -> /private/var, symlinked $GSTACK_HOME) otherwise never matches. Behavioral tests prove discovery stops at the ceiling from the staging dir, including through a symlinked path, using git itself — no gbrain required. Mechanism ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(autoplan): Phase 4 task aggregator emitted zero tasks on every run (#2018) The branch+commit jq filter piped to the split commit array and then referenced .commit — jq rebinds context across a pipe, so .commit indexed the ARRAY with a string, every input line errored into 2>/dev/null, and || true swallowed the exit. The aggregate table has been empty for every user since the feature shipped. Bind .commit to a variable before the pipe. Functional pin extracts the ACTUAL emitted jq program from the resolver and runs it against fixture JSONL (verified RED against the broken filter), plus a source-shape guard against reintroducing a context-rebinding reference. Fix mechanism from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(codex): BSD mktemp templates broke /codex on every macOS install (#2091) macOS mktemp requires the X's to end the template; the five "codex-*-XXXXXX.txt" sites failed with "mkstemp failed ... File exists" before Codex ever ran (reproduced live on this machine). Same class fixed in claude/SKILL.md.tmpl's three sites. bin/gstack-paths now strips macOS's trailing slash from TMPDIR so TMP_ROOT-built paths stop carrying "//". Static tripwire scans every tracked .tmpl for characters after the X-run in a mktemp template (longer X-runs stay valid), plus a live portability check of the emitted shape. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(decision-log): --supersede silently discarded the replacement decision The supersede/redact branch appended the retirement event and exited before the JSON argument was ever read — a user recording a reversal WITH its replacement lost the replacement, and the payload finder's first-non-flag-arg predicate would have mistaken the target id for JSON anyway. Payloads are now identified by their leading brace, validated BEFORE any write, and appended FIRST (retirement second), so the only visible interleaving under a crash is both-active — recoverable, never lost. The replacement carries supersedes:<old-id> provenance. Bare --supersede <id> (the documented reversal-without-replacement) stays legal; --redact with a payload now refuses instead of dropping it. Ported from time-attack/gstack (GStack 2), tests included. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(brain-context): cold-start probe latency permanently disabled gbrain context gbrainAvailable() spawned gbrain --version under a 500ms budget; a cold CLI start on a loaded machine blew the timeout, misclassified gbrain as missing, and every skill session silently ran brainless — plus the per-query re-probe burned 3x the budget before any real work. Replaced with a memoized stat-based PATH scan (PATHEXT-aware on Windows) and made the query timeout overridable via GSTACK_BRAIN_TIMEOUT_MS for loaded CI environments. Also picks up the fork's manifest-filter coverage (#1687 shape) against the fake-gbrain harness — passes against our existing filter support. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(setup-gbrain): voyage-code-3 flags were silently dropped under zsh (#1798) zsh does not word-split an unquoted $VAR, so all three PGLite-init sites passed the entire flag string as ONE argv word — gbrain ignored it and silently fell back to its default embedding model, downgrading code retrieval for every zsh user (macOS default shell). Flags now ride the positional params (set -- ...; "$@"). Tests run the shape under BOTH bash and zsh against the fake-gbrain argv recorder (per-word argc log distinguishes one-blob from split), include a demonstration of the zsh collision on the old shape, and pin the template's three sites statically. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(model-benchmark): recognize macOS Keychain auth in the claude adapter (#1890) The default macOS Claude Code install stores OAuth under the Keychain generic-password service "Claude Code-credentials" and never writes ~/.claude/.credentials.json, so available()'s file-or-env sniff reported "No Claude auth found" while claude -p worked fine. On darwin the sniff now also probes the Keychain entry — metadata only (no -w, the secret is never read), 5s timeout, any security(1) failure degrades to not-found. Verified live on this machine (subscription install, no creds file, Keychain entry present). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(upgrade): v1.27 migration no longer auto-proceeds without a TTY or records a failed rename as done (#1383) Two silent-failure shapes in one script. Non-interactive runs (Claude Code Bash tool, CI) blanket-auto-proceeded into a REMOTE repo rename — now they skip-for-now by default and ask again next upgrade; unattended runs opt in with GSTACK_MIGRATE_ASSUME_YES=1. And a failed gh rename was journaled as done and the done-touchfile written, permanently stranding a half-renamed install — the failed step now stays PENDING with the manual command printed, finalize refuses the done-marker while any step is unjournaled, and the migration exits 1 with a re-run pointer while completed steps still skip on retry. Harness updated to opt in explicitly; new tests pin the default-skip and failure-stays-pending-then-retry-succeeds contracts (13/13). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ship): REST fallback when gh pr edit hits the Projects-classic GraphQL deprecation (#1079) On repos where GitHub enforces the Projects-classic sunset, gh pr edit hard-errors on repository.pullRequest.projectCards and Step 19's PR body update dies. The template now names the error shape, says it is not an auth problem, and falls back to the REST endpoint (gh api pulls/N -X PATCH) with the SAME already-redaction-scanned temp file for body and title. Generated SKILL.md regen rides the cluster regen commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ship): test-command detection was blind to Django and config-less-but-tested projects The Test Framework Bootstrap detected Python only via requirements.txt or pyproject.toml and treated missing config files as no-tests, so a green 'python manage.py test' Django app, a Go project with *_test.go beside the source, in-source Rust #[test] blocks, or a package.json with only a test script all got offered a SECOND test framework over a working one. Detection now enumerates definitive per-ecosystem markers (manage.py, tox.ini/setup.cfg, pom.xml/gradle, Makefile test targets, a tracked-file test census, in-source Rust tests) as EVIDENCE for the question it asks — never a command to run blind — preserving the read-CLAUDE.md-or-ask contract, with a marker→candidate-command table and ask-once persistence. The shared coverage-audit detection block gains the same markers. Test runs the resolver's emitted detection bash against Django / Go / Rust / Node fixtures in throwaway git repos. Ported from time-attack/gstack commit e3259078 (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: regenerate SKILL.md files for cluster A (autoplan jq, codex mktemp, setup-gbrain zsh, ship detection + REST fallback) Atomic regen of the 9 generated files whose templates/resolvers changed in the A-cluster commits. bun run gen:skill-docs, no hand edits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test: refresh ship goldens + parity ratios for cluster A growth Codex/Factory hosts render single-file ship skills whose committed goldens must track template changes; refreshed from the regenerated renders. Parity size guards bumped with the growth itemized — ship (carve-guards) 1.08 -> 1.10 for the detection-evidence + REST-fallback growth measured at 1.090x, qa (parity-harness monolith invariant) 1.07 -> 1.12 for the shared coverage-audit markers measured at 1.111x. Kept tight so the next growth is a deliberate decision, not drift; the Apple adapter raises ship again with its own justification. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(gbrain-sync): enforce the per-repo policy at the code-import chokepoint (#2140 sync path) The deny/read-only tiers in ~/.gstack/gbrain-repo-policy.json were stored by gstack-gbrain-repo-policy but enforced only in /sync-gbrain skill prose — a direct or cron invocation of gstack-gbrain-sync ingested repo code regardless. Worse: the code stage's egress receipt has cited 'per-repo policy chokepoint (repoPolicyTier)' as its consent since v1.63 while no such function existed. repoPolicyTier() now gates the stage before the dry-run branch: deny → refused-policy-deny (exit 1, loud), read-only → clean skipped-policy-read-only (code ingest writes pages), unreadable store → fail-closed refused-policy-unreadable, no store → unchanged fail-open. Subprocess tests pin all four paths against real git repos and a permission-blocked store (verified RED against the ungated binary). The receipt's consent string is truthful from this commit. #2140's ingest-path source-isolation ask remains open — partial-progress comment at ship. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ios-qa): /auth/sessions no longer hands raw bearer tokens to any local process The loopback sessions list echoed live tokens — a harvest-and-replay primitive for anything on the machine (same class as the /health token leak fixed in v1.63). The list now returns a device-salted 16-hex token_id plus metadata; the salt is shared with the attempts log so identifiers correlate. /auth/revoke keeps the list→revoke workflow alive by accepting token_id alongside the caller's own raw token and identity. saltedHash() is exported from audit.ts and writeAttempt now reuses it (was inlined). Integration tests pin raw-token absence, the id shape/metadata, and the token_id revoke round-trip (verified RED against the leaking handler). List fix ported from time-attack/gstack (GStack 2); token_id revoke is ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ios-qa): boot token out of os_log entirely; IPv4 listener pinned to loopback at the socket The StateServer's bootstrap announce logged the live boot token with privacy: .public — and nothing consumed it: the daemon has read the token from the 0600 app-container file since the devicectl copy flow landed. The log line handed a credential to anything reading the unified log during the launch window. It now announces port/build only. The IPv4 listener bound the wildcard interface and relied on the per-connection peer check alone; IPv4 has no CoreDevice tunnel path, so it now binds 127.0.0.1 via requiredLocalEndpoint at the socket level. IPv6 keeps the wildcard bind for CoreDevice ULA peers by design. Static pins cover both the template and the fixture app copy. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(make-pdf): close the offline-gate bypass via raw-HTML fetch vectors With --allow-network off, the sanitizer stripped script/iframe/link but let Chromium fetch remote resources at print time through four raw-HTML vectors: <style> @import (any form), remote url() in <style> blocks and inline style attributes (incl. protocol-relative //), srcset with a remote candidate (Chromium prefers srcset over the inlined src), and remote src/poster on video/audio/source/track. All neutralized at the sanitizer; remote <img src> is deliberately left for the image inliner so its blocked-remote placeholder still fires, and url() mentions in prose/code spans stay untouched. Fork's test suite ported verbatim (12 cases incl. the end-to-end render assertion), verified RED against the old sanitizer. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(pair-agent): tunnel activation is consent-gated — and the receipt's consent claim is now real The tunnel egress receipts have claimed consent: 'pair_agent=on' since v1.63 while no such key or gate existed — ngrok installed+authed was enough for the CLI to auto-start an internet-facing tunnel. isPairAgentEnabled() (fail- closed, env-overridable) now gates all three activation points: CLI auto-start, POST /tunnel/start (refuses with the enable hint), and the BROWSE_TUNNEL=1 startup bind. Consent-on-first-use, not silent breakage: the /pair-agent skill asks once (one-way-door posture), sets pair_agent via gstack-config (registered with on|off validation, default off), and never asks again; direct API callers get the same hint in the refusal. Adapted from the fork's gate: their reader targeted config.json, which on main would have made the gate silently un-enableable — ours reads the canonical ~/.gstack/config.yaml with the JSON shape as fallback, pinned by tests either way (11 cases, gate wiring tripwires included). Ported from time-attack/gstack (GStack 2), store adaptation ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: regenerate pair-agent SKILL.md for cluster B (consent gate) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(browse): cancel the parent watchdog when handoff promotes a daemon to headed The parent-process watchdog assumes connection mode is fixed at boot: headless daemons outlive their parent, headed ones do not. The env guards (BROWSE_PARENT_PID=0, BROWSE_HEADED=1) only cover daemons that were headed when they started. handoff breaks that assumption. It swaps in a headed context on a RUNNING daemon and sets connectionMode = 'headed' without a restart, so a daemon that legitimately registered a watchdog lands on the fatal side of the branch. The parent is usually a short-lived shell, and Claude Code's Bash tool kills one after every invocation, so the next 15s poll shuts the daemon down. The user-visible effect is that handoff destroys the thing it just created. It exists so a human can log in, solve a CAPTCHA, or clear an MFA prompt; the browser disappears about fifteen seconds later and takes the session with it. Observed while driving two registrar control panels: five daemon deaths and three logins, each one discarding the authenticated session. BrowserManager now exposes onHeadedPromotion, fired only on runtime promotion and not on a headed boot, and the server binds it to a canceller for the interval it already owned but previously discarded. Bound on both the module-level manager and any embedder-supplied one, since the watchdog reads activeBrowserManager and binding only the default would let embedders promote silently. The binding sits next to the browserManager declaration rather than next to clearParentWatchdog. Placing it with the function, which lives with the watchdog it cancels, reads better but touches browserManager in its temporal dead zone, which aborts module evaluation and leaves every later const uninitialized. findport tests catch that immediately. Tests: watchdog.test.ts already noted in its header that its three cases all fix mode via env at spawn time, so none reaches the headed branch. Driving a real handoff needs a headed Chromium, so the wiring is pinned with static tripwires instead, matching cdp-session-cleanup.test.ts and server-auth.test.ts. Verified they fail when the notification call is removed and pass when restored. Full `bun test` shows the same 6 pre-existing failures on this branch and on main (gstack-gbrain-detect, gstack-artifacts-init), which pass in isolation on both, so they are test-order pollution rather than a regression here. * fix(browse): pass windowsHide so the daemon stops popping console windows On Windows, `browse` leaves empty black console windows on top of whatever the user is doing — they pop up every few minutes for as long as any browser skill is alive, and outlive the process that created them. Cause: `bun-polyfill.cjs` maps `Bun.spawn`/`Bun.spawnSync` onto node's `child_process`, and node defaults `windowsHide` to **false**. Bun never creates these windows, so nothing in the daemon's own code looks wrong — the behaviour only appears on the node fallback path. The one users notice is `spawnTerminalAgent()`, which launches `bun run terminal-agent.ts` through this shim. The daemon respawns it on a watchdog, so closing the window is not enough — a new one arrives shortly after. Ten `bun.exe` processes were live on the machine this was diagnosed on. Why they linger after the child exits: with the default terminal application set to "Let Windows decide", the console is brokered through Windows Terminal via svchost, and WT leaves the empty frame behind when its only child exits. The frame has no child process at all, which is why it looks like a dead terminal. Setting `windowsHide: true` on both wrappers fixes every console child routed through the shim — the bun agent plus the `tasklist`, `git` and `powershell` calls elsewhere in the daemon. No behaviour change on macOS or Linux, where the option is ignored. Not covered by this commit: `chromium.launch()` goes through playwright's own process launcher rather than this shim, so it still creates one window per daemon start. Worth a follow-up. * test(browse): make bun-polyfill tests runnable on Windows, and cover windowsHide `bun test browse/test/bun-polyfill.test.ts` was **0 pass / 4 fail on Windows** before this — every test in the file, on the platform the polyfill exists to support. Each test interpolates the polyfill's absolute path into a single-quoted JS string passed to `node -e`. On Windows that path has backslashes, so JS eats them as escapes: 'C:\Users\jwilk\dev\gstack-fork\browse\src\bun-polyfill.cjs' -> C:Usersjwilkdevgstack-forkrowsesrcun-polyfill.cjs (`\b` is a real escape, so it deletes a character too.) `require()` throws, the subprocess dies, stdout is empty, and every assertion compares against "". The tests pass on macOS and Linux purely because those paths have no backslashes. Fixed by interpolating with `JSON.stringify(polyfillPath)`, which quotes and escapes correctly on all platforms. Also adds a regression test for the windowsHide fix in the previous commit. It stubs `child_process.spawn`/`spawnSync` *before* the polyfill destructures them and asserts the captured options, so it is deterministic and needs no window — it verifies the contract on macOS and Linux too, where the option is a no-op. Verified on Windows: 5 pass / 0 fail with the fix, and the new test alone fails ("VISIBLE" instead of "HIDDEN") when the previous commit is reverted. * fix(browse): forward windowsHide through the Bun polyfill spawn shims The Node fallback shim accepts a Bun.spawn options object and forwards only stdio, env and cwd to child_process.spawn. windowsHide is dropped, and because Node defaults it to false while Bun.spawn hides the console window, the omission inverts the behavior on the one platform the shim exists to support. Symptom: the terminal-agent respawn in server.ts (60s watchdog ticker) pops a visible bun.exe console window on Windows every time it fires, so the window keeps coming back with no scheduled task or startup entry behind it. stdio:'ignore' silences the child's output but does not suppress its window. Both shims now forward the option and default it to true, matching the Bun API being emulated; an explicit windowsHide:false still passes through. spawnTerminalAgent also sets it explicitly at the call site. Tests: three cases in browse/test/bun-polyfill.test.ts assert the default for spawn and spawnSync and that an explicit false is honored. Each was confirmed to fail against the unpatched shim. Drive-by, required to run the suite at all on Windows: the tests interpolated an absolute path into a JS string literal, so backslashes were consumed as escapes and every require() failed with MODULE_NOT_FOUND. The path is now normalized to forward slashes. On Windows this file went from 0/4 passing to 7/7. * fix(browse): headed mode on macOS 26 — stop mutating the signed Chromium bundle, heal the ones we already broke (#2242, #2138, #2139) The in-place rebrand rewrote the Chrome-for-Testing bundle's Info.plist (global name replace — which also renamed CFBundleExecutable to a binary that doesn't exist) and overwrote its Resources/*.icns, breaking the codesign seal: GPU process exit_code=5, headed mode dead on macOS 26. The mutation lived in the SHARED Playwright cache, so it also poisoned the user's other Playwright projects. Three layers land together: (1) the rebrand block is gone — branding lives in the GStack Browser.app wrapper via GSTACK_CHROMIUM_PATH, with a tombstone and a static tripwire (no plist/icns writes into the bundle; the tripwire allows the read-only probe below); (2) a launch-time self-heal detects an already-poisoned cache bundle, removes it, and errors with the exact re-fetch command — covering deploy paths that never run migrations; (3) migration v1.64.0.0 sweeps every cached bundle, removes poisoned ones, and re-fetches clean Chromium immediately (migrations run after ./setup, so without the re-fetch an upgrade would end with zero working browser). Functionally verified against fixture caches: poisoned removed, clean untouched, rerun no-op. Migration filename tracks the final VERSION at ship. The #2242 watchdog half is the absorbed PR #2565 (thanks @Screddyice). Tombstone/tripwire ported from time-attack/gstack (GStack 2); self-heal and migration are ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(browse): 'browse stop' no longer restarts the daemon it was asked to stop The stop handler awaited shutdown() — which ends in process.exit — before returning, so the acknowledgement never egressed. The CLI's fetch reset, which its crash path reasonably interpreted as a dead daemon: it relaunched Chromium, re-sent stop, watched the daemon exit again, and errored 'Server crashed twice in a row'. Every stop cost a wasted Chromium launch and a nonzero exit. The ack now returns first; shutdown fires on a 25ms unref'd timer. Same fix for restart. Fork's test pins ack-before-teardown for both. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(browse): lock acquisition reports real errors instead of phantom contention (#1084) acquireServerLock's bare catch treated EVERY failure as 'another process holds the lock' — a missing state dir, EACCES, or ENOSPC read as permanent phantom contention with nothing to debug. Now only EEXIST is contention: ENOENT self-heals with one mkdirSecure retry, everything else throws ServerLockError carrying the real errno, and the stale-lock unlink/retry loop is depth-capped so it can't livelock. Fork's five-case test ported. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(browse): integration coverage for #1781 busy-vs-dead recovery Fork's wedged-daemon fixture: first /command connection drops, daemon PID stays alive. Pins the whole contract — CLI retries the same daemon instance without a kill, state file untouched, no restart, exactly two command requests. Message-text assertion adapted: our CLI retries silently at the probe layer where the fork announces on stderr; the behavior, not the message, is the invariant. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(browse): windowsHide on every Windows-reachable spawn (#1835) Console windows flashed (and stole focus) on every daemon relaunch, taskkill, tasklist poll, and powershell DPAPI call — node-level spawns default windowsHide to false. Covered: the node -e launcher (outer spawnSync AND the inner detached daemon spawn inside the launcher string), the dev-mode bun fallback, killServer's taskkill, isProcessAlive's tasklist, and cookie-import's powershell + tasklist. The Bun-polyfill shims were covered by absorbed PRs #2523 + #2539 (thanks @jwilk-hrep, @jerrynicholsai); this closes the sites those PRs didn't reach. The icacls sites land with the #1605 DACL commit alongside the static tripwire that pins all of them. R8's planned spawnHidden() helper is deliberately NOT built: the polyfill default plus the tripwire achieve the no-drift goal without indirection over seven heterogeneous call shapes. The polyfill + spawn-hide tests join the Windows CI shard. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(browse): self-repair broken Windows DACLs on state dirs (#1605) icacls '/inheritance:r /grant:r' can partially fail on localized or domain accounts: inheritance strips but the user grant doesn't resolve, leaving a machine-SID-only DACL the owner can't even list — the sidebar/PTY failure chain in #1605, caused by the very hardening call meant to protect the dir. mkdirSecure now verifies listability after hardening (a real readdir — fs.accessSync doesn't consult NTFS ACLs) and repairs via icacls /reset, re-hardens, and if hardening breaks access again leaves inherited ACLs: functional-but-unhardened beats hardened-but-unusable. The icacls calls carry windowsHide (#1835's last two sites) and the fork's static spawn-hide tripwire lands here, pinning every covered site. file-permissions.test.ts is already in the windows-free-tests curated shard, so the DACL contract executes on windows-latest. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(browse): opt-in session persistence — auth survives daemon restarts (#778, #2193) BROWSE_PERSIST_STATE=1 snapshots cookies + per-tab URL/localStorage/ sessionStorage to <stateDir>/session-state.json (0600) on a 30s unref'd interval and at clean shutdown, and restores on the next launch — killing the top-complained auth-lost-on-restart class (#778, #2193, #1128, #1129). Security invariants mirror state save|load: loadedHtml and owner are never persisted and never accepted from disk; restored cookies pass the same hygiene filter (localhost/.internal/metadata domains dropped); restoreState re-validates every URL. Default OFF; headed mode excluded (the persistent profile owns that state). Hardened past the fork's shape per review R3: corrupt state quarantines to .corrupt (forensic artifact, boots fresh, one log line), snapshot failures warn once and never kill the daemon, and the boot log reports restored counts or fresh-session status. Module + 10 tests ported (MIT header retained); server wiring at launch, interval, and shutdown; skill docs section added (regen rides the cluster regen commit). Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: regenerate browse SKILL.md for cluster C (session persistence docs) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(skills): third-party web-actions contract — offer to drive vendor-site steps, never just dump a manual list When a workflow needs something done on an external website the user controls (register an API key, create a vendor account, configure a dashboard/webhook/OAuth app), five skills (ship, spec, office-hours, setup-deploy, land-and-deploy) now follow one contract: offer to drive it in a visible browser via gstack's own stack ($B headed + handoff/resume, GStack Browser) behind ONE per-task consent question naming the exact site and actions; passwords, payment, CAPTCHA, and identity stay user-performed; captured secrets go to owner-only files or the user's secret store, never chat/logs/history; and the credential is verified with one non-mutating API call before any success claim — dashboards show masked placeholders, and a 401 catches them. Declining yields manual steps and a blocked-on-user mark; nothing new is ever installed to close the gap. New resolver token {{THIRD_PARTY_ACTIONS}} (adapted from the fork's contract — their Aside-browser detection swapped for our own driver stack; MIT portions noted). Parity guards bumped with growth itemized (ship 1.10->1.12 at measured 1.103x; office-hours skeleton 101K / 1.09 at measured 1.079x); ship goldens refreshed. Ported from time-attack/gstack (GStack 2), driver adaptation ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(office-hours): design docs land in the repo, written as decision records (#703, #2000) Office-hours Phase 5 now dual-writes the design doc: the docs/designs/ copy is what teammates and plan reviews read (committable, visible), while the ~/.gstack copy keeps memory ingest and cross-session discovery working. The repo copy leaves the private store, so it passes the redaction scan-at-sink first (HIGH blocks the repo copy, MEDIUM confirms per finding), and any failure — read-only checkout, non-git dir, unconfirmed finding — degrades to the private copy with a one-line reason, never blocking the handoff. The doc itself is now a decision record, not a transcript: one bullet per decision with its why, ruled-out approaches collapsed to a single line with the rejection reason, settled/empty template sections omitted. No page cap; extra length must come from genuinely open questions. Plan reviews (ceo/eng/devex + the shared review resolver) prefer the repo-local doc (DESIGN.md, then newest docs/designs/*.md) when it's at least as fresh as the private copy — a stale old repo doc never shadows a newer session. Parity guards bumped with measured values (three plan-review skeletons +~0.7KB each; office-hours 1.092x). Judgment ported from time-attack/gstack (GStack 2); scan-at-sink and freshness-preference adaptations ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(office-hours): 'never show me these again' for the founder-resources pitch (#538) The Phase 6 resources offer (34 PG essays + Garry/YC videos) had no permanent decline — the reporter showed memory instructions kept being overridden on every update, so people who said no got re-pitched forever. The offer now closes with a standing choice; opting out runs gstack-config set founder_resources false (new key, default true, true|false validated), the write is VERIFIED before any promise (a failed write says so and skips this session only), and every future session skips the entire section silently — no resources, no 'skipped as requested' mention. Config outlives session context, so never means never. Re-enable anytime: gstack-config set founder_resources true. The pitch stays default-ON for everyone who never opted out. Tests pin the key's default/persistence/validation through the real config bin and the generated section's gate-before-content + write-verify contract. Approved as a promo-surface change (CEO review D3.4, 2026-08-14). Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(ship): the Apple App Store release journey — working tree to Submit for Review Point /ship at a repo with an .xcodeproj, .xcworkspace, or app-product Swift package and ask to release: the adapter runs the whole journey with ONE authorization moment (membership + pricing + in-session sign-in, decision- store persisted so repeat releases ask nothing) and one store-assets question only when assets are missing. fastlane is the single tool (produce/cert/ sigh/gym/pilot/deliver/frameit); credential vocabulary never reaches the user. The adapter carries 21 live releases' worth of paid-for Apple knowledge: the web session mints the permanent upload key itself (iris POST /v1/apiKeys; privateKey is base64-of-PEM, downloadable only at creation) so nobody ever types an app-specific password; error -22938 is Transporter asking for a key, not a user task; errors are CLASSIFIED before credentials are touched (validation/UnexpectedResponse = metadata, incl. Apple's expanded age-rating attributes); pricing goes through POST /v1/appPriceSchedules because fastlane's price_tier is broken against the current API; and store distribution NEVER routes through the branch gate — a clean tree on main is the solo shipper's normal case (Step 0.9 loads the adapter BEFORE the gate, pinned by test with the non-Apple gate byte-unchanged and unique). Uploads/submissions follow an idempotency-log contract (inspect App Store Connect before any re-run). Non-Mac hosts get the honest split: build legs via a macOS CI runner with the minted key as a secret, API legs local. Browser use inside the journey is banned except the named paid-app banking/tax residue. Redaction dry-run clean. Ship's parity ratio raised 1.12 -> 1.22 deliberately: the 14.8KB section is on-demand (Apple store targets only), one manifest line otherwise. Ported from time-attack/gstack (GStack 2), refined across its 21 live releases; architecture adaptation (carved section, decision-store paths, idempotency log, third-party-actions handoff) ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(code-intelligence): provider contract Phase 1 — GBrain, Sourcebot, Graphify behind one ask-once offer Open a large repo (1,000+ tracked files) and gstack can offer code intelligence ONCE, with the trade-offs stated: GBrain (semantic memory + code, sends content to YOUR gbrain DB, per-repo consent), Sourcebot (self-hosted whole-repo search, local on localhost), Graphify (local tree-sitter graph, nothing leaves the machine, user-installed), or No indexing — a decline persists machine-wide so no skill ever asks again. Small repos never see the question; grep stays the always-working default and provider-OFF degrades silently (PROVIDER_UNAVAILABLE -> file-only). Ported: lib/code-intelligence/ (contract + 3 verified adapters + picker + selection + suggest, MIT headers), the gstack-code-intelligence CLI (suggest/select/consent/index/search/status), 31 offline tests (fake CLI shims + injected fetch), and the provider-contract design doc. Verified live on this repo: suggest fires at 1,233 files with real availability detail per provider. Hardened per review: the per-remote trust store is the SINGLE consent authority — a gstack-gbrain-repo-policy deny tier vetoes any recorded code-intelligence consent (fail-closed on an unreadable store, pinned by three tests); both send-capable adapters are registered as fail-closed MODULE_SINKS in the egress tripwire so a refactor can't drop their receipts; and local-compute vs remote-send consents are never bundled. setup-gbrain gains the provider-choice Step 0. The fork's Phases 2-4 glue-collapse is explicitly NOT ported. Ported from time-attack/gstack (GStack 2); consent unification ours. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(ci): supply-chain hygiene — secret gate on every PR diff, dependency review, OSV, dependabot, evidence-bar PR template The repo owned a redaction engine and had zero CI-side secret scanning. quality-gate.yml now pipes every PR diff's ADDED lines through our own bin/gstack-redact (gate-secret-scan.mjs, taken from the fork — it dogfoods the engine): HIGH findings fail the check, MEDIUM prints an advisory count only (no human in CI to confirm), planted-bug fixtures excluded by pathspec. Live-verified both directions: PEM key fails, clean diff and MEDIUM shapes pass; ShellCheck (errors) covers the setup/build shell boundary and passes today; bun audit gates critical advisories. Trigger is pull_request, never pull_request_target. dependency-review.yml adopts the hardened never-merged prior-art branch (fail-on-severity high, workflow paths watched, tight perms) — verify the dependency graph parses bun.lock with a canary bump before trusting the gate. dependabot: weekly, grouped per ecosystem, capped PR counts; and evals.yml image build/push now skips dependabot actors, whose read-only GITHUB_TOKEN made every lockfile bump a permanently red check. OSV scans weekly with a reasoned ignore file. All new workflow actions SHA-pinned. Scorecard deliberately not taken (no consumer for the score). The PR template front-loads the evidence bar (live proof, liveness screenshot, no-ETHOS/voice-changes checklist); the unenforced DCO line is dropped. bin/gstack-verify-gate ships OPT-IN (never registered by ./setup — a Stop hook running the project's verify command after every turn is the user's call), with the fork's tests adapted to pin exactly that. Ported from time-attack/gstack (GStack 2) + our own prior-art branch. Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: remove dead bins; extend the stale-ref scan to docs (the 36-release gap) bin/chrome-cdp, bin/gstack-open-url, and bin/gstack-platform-detect were referenced only by an audit test and CHANGELOG history — dead weight that the stale-ref scanner should police, which required removing them FIRST. The scanner now also sweeps docs/, README.md, and USING_GBRAIN_WITH_GSTACK — the deliberate exclusion that let a dead command survive ~36 releases as a command-not-found instruction. Scan is green on the extended surface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(bins): detect the default branch instead of hardcoding main gstack-diff-scope fell to an empty diff (all-false SCOPE_*) and gstack-next-version mis-based its bump math on any repo whose default branch isn't main (trunk, master, local-only). Both now resolve origin/HEAD -> origin/main -> origin/master -> main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: housekeeping sweep — telemetry integrity, persistent opt-out, context-bill accuracy, setup hang, dev-server discovery, model resolution (#2136 + v1.63 polish) Seven small fixes, one theme (claims matching code): - telemetry-sync strips local-only fields with jq del() (structural) instead of quote-fragile sed regexes; unparseable lines are dropped, never forwarded unstripped. Sed survives only as a jq-less fallback. - telemetry-log rejects non-integer durations BEFORE the range caps, whose test(1) comparisons silently no-op on non-numerics — a malformed duration spliced raw text into the JSONL stream. - browse's local telemetry honors the persistent tier (config.yaml telemetry: off), not just the preamble's env hint — direct $B use and embedders now respect the opt-out. - gstack-context-bill --exact sees GSTACK_-promoted keys inside Conductor (conductor-env-shim wired at the CLI entry), and the TOTAL line no longer double-counts every nested skill through the root skill's walk (v1.63 deferred polish; the telemetry-sync HTTP-status outcome deferred alongside it turned out already shipped). - setup's Chromium probe is deadline-bounded (90s, background + poll-kill — macOS has no GNU timeout) and prefers Node for the launch probe everywhere (the bun --eval hang family behind #2136); the install is single-flight behind a lock dir with an actionable stale-lock message. Probe verified live on this Mac. - the review resolver's dev-server check reads CLAUDE.md and the plan file before falling back to an expanded port probe, and says how to make itself smarter next time. - eval/harness model IDs resolve through lib/eval-model.ts (GSTACK_EVAL_MODEL[_KIND] env overrides, per-kind defaults, tested) at the SDK-capture and PTY-warmup sites; the bash-embedded distill snippet mirrors the resolution inline. - memory-ingest's silent-zero shape (staged>0, imported+unchanged==0, errors==0) warns even under --quiet — a run that indexes nothing must never look healthy again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test: wire ios-qa/daemon/test into the free suite and shard runner (E2) The daemon's 5 test files (allowlist, audit, auth-mint, cli-mint, daemon-integration — now 6 with session hardening) were invisible to every runner: not in the bun test glob, not in TEST_ROOTS. The same silent-coverage-hole class as the tracked design/test P2 — and it meant B2's auth regression tests would never have gated. All files are hermetic (stub state-servers on ephemeral ports, no devices); verified green in the shard census. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(skills): claimed limitations now require evidence, everywhere + wave follow-ups filed Every tier-2+ skill's preamble gains one directive distilled from nine live release failures in two days on the fork: a claimed limitation or requirement ('the API can't do this', 'X requires a credential', 'impossible on this platform') is a material claim, stated only with the verbatim error, the documented statement, or a live probe in hand — pattern-matching a failure to a familiar story is not evidence, and a cheap probe runs BEFORE asking the user or declaring a step blocked. ONE directive adapted into the preamble resolver; the fork's full judgment contract is deliberately not imported. Full regen (46 files), ship goldens refreshed, parity guards bumped with the measured ~0.45KB/skill (investigate, autoplan, plan-design-review, office-hours), Step 0.9 registered as an intentional sub-step. Approved deferrals filed: persona-fleet hostile-user harness + answer-key methodology in TODOS; the fork's question-budget ACCOUNTING judgment (never its 5/8/12 constants) folded into the V1.1 pacing design doc; the Apple adapter added to #1882's coverage note. Ported from time-attack/gstack (GStack 2). Co-authored-by: Sina Matian <sina@time-attack.dev> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(make-pdf): close offline-gate bypasses via unquoted style attrs, CSS-escape and HTML-entity obfuscation Three live vectors found by the ship review army, all red-first tested: unquoted style attributes skipped the remote-url neutralizer entirely; CSS ident/string escapes (@\69mport, url(\68ttps://…)) defeated the literal-match patterns Chromium happily decodes; and HTML entities in style attribute values (https) decoded to fetchable schemes before CSS parsing. Style-attr values are now entity-decoded in one browser- faithful pass, escape-bearing at-rules and function tokens are dropped fail-closed, and output is re-encoded double-quoted. 21 new test rows. * fix(migrations): v1.65 Chromium re-fetch actually re-downloads, and success is verified before .done The migration (renamed from the provisional v1.64.0.0 slot, which open PR #2564 claims) deleted only the poisoned .app while Playwright's INSTALLATION_COMPLETE marker survived in the revision dir — so the advertised 'bunx playwright install chromium' re-fetch no-opped and the user finished the upgrade with no browser and a success message. Now: the whole chromium-<rev> dir goes, bunx runs cwd-pinned to the install root, .done is gated on a verified executable, and a needs-refetch sentinel makes re-runs retry a failed download. Stranded rev dirs (markers without .app) also re-trigger. 6 hermetic tests, red-first. * fix(migrations): v1.27 remediation prints a real command instead of a fictional flag Every skip/failure path referenced '/setup-gbrain --rerun-migration', which is implemented nowhere, and promised the migration 'will ask again next upgrade', which the version-window runners make false. All five sites now print the direct GSTACK_MIGRATE_ASSUME_YES=1 bash invocation. Runner-side re-offer tracking is filed in TODOS. * fix(browse): poisoned-bundle self-heal removes the revision dir, probes handoff too, and throws typed Same marker flaw as the migration: rmSync of the .app alone left INSTALLATION_COMPLETE behind, so the error message's own remediation no-opped and the user was hard-stuck. The probe is now an exported, unit-tested helper (probePoisonedChromiumBundle) that removes the whole chromium-<rev> dir, never touches GSTACK_CHROMIUM_PATH custom bundles, throws PoisonedBundleError (instanceof, not string-match), and runs on BOTH headed entry points — launchHeaded and handoff. 7 tests. * fix(browse): session snapshots are atomic and the cookie filter drops loopback IP literals A crash mid-write destroyed the previous good snapshot — the exact scenario persistence exists to survive; writes now go tmp+rename. The internal-network cookie filter gains 127.*/::1/169.254.* (a tampered state file could previously hand loopback-service cookies back to the browser), and 'state load' imports the shared filter instead of maintaining a comment-synced copy. Test cleanup made exception-safe. * fix(browse): server runtime — restore off the boot path, shutdown that cannot hang, watchdog that still reaps tunnels Four review findings on the wave's own new wiring: session restore ran before Bun.serve with sequential 15s gotos while the CLI gives up at 8s (one slow saved URL bricked every $B command) — restore now runs in the background after bind; the shutdown snapshot gets a 2s deadline so a wedged page.evaluate can't hold the port forever behind the new ack-first stop; the persistence ticker gets in-flight + shutdown gates and is cleared before the final snapshot; and the absorbed #2565 handoff fix no longer clears the whole parent watchdog — a suppress flag keeps the tunnel-orphan reaper alive (handoff→resume→tunnel is no longer an unreapable internet-exposed daemon). pair-agent with consent off now names the real remedy instead of ngrok install instructions. Lock-acquisition edge branches (garbage pidfile, vanish-race depth cap) pinned. * fix(browse): telemetry defaults to off like every other surface The persistent tier defaulted ON when the config key was absent, while gstack-config's DEFAULTS table answers 'off' for the same question — preamble-spawned daemons and direct $B daemons disagreed about consent. Absent key/file now means disabled; community/anonymous enable; env kill-switch still beats everything. Both config.yaml consumers now share one readGstackConfigYamlKey reader. 12-case consent suite. * fix(code-intelligence): consent that means what it says — polarity, receipts, read-only veto Four review findings on the wave's own Phase 1 port, all red-first: 'consent <repo> no' recorded consent GRANTED (the CLI ignored the argument and always wrote true) — yes|no is now required and garbage records nothing; Sourcebot egress receipts claimed consented=true on paths that never checked consent — the actual consent state is threaded into every receipt, search is fail-closed on non-loopback, and the liveness probe's receipt says truthfully that it sends no repo content; repoPolicyVeto only honored the deny tier while gbrain refresh writes pages — write-class ops now veto on read-only too, matching the sync chokepoint, via one shared lib/gbrain-repo-policy-client.ts (win32 bash invocation, spawn-vs-unreadable error distinction) used by both call sites. Also: source ids get a host+path hash (same-name repos no longer collide), refresh timeout raised to 120s, availability probes run concurrently at 3s, graphify status stops JSON.parsing 100MB graphs for a count, and every ported file carries the fork MIT notice. +15 tests across the two suites. * fix(verify-gate): trust before eval, re-check on re-entry, audit every grant The opt-in Stop hook eval'd whatever command the first CLAUDE.md up the tree declared — any cloned repo got arbitrary shell at turn end. Now a per-repo trust store (path+command hash, 0600) gates execution: an untrusted or changed command never runs (exit 0 with the --trust invocation printed), stop_hook_active re-entry re-runs the trusted check instead of rubber-stamping (bounded at 3 blocks per episode), and every grant appends a forensic line to ~/.gstack/security/verify-gate-trust-grants.jsonl. 20 tests, red-first. * fix(setup): EXIT traps chain instead of clobbering; timed-out probes reap their whole tree The Playwright-lock trap replaced the copied-bun cleanup trap and then cleared ALL exit handling, leaking .tmp-bun-bin on every Chromium install; and _wait_with_deadline killed only the subshell, orphaning the wedged node→Chromium tree it exists to escape — re-creating the #2136 pile-up on every timed-out re-run. Traps now chain; timeouts walk pgrep -P descendants leaves-first. * refactor(resolvers): one source for the design-doc discovery block The #703 repo-doc-preference bash was pasted byte-identically into three plan-review templates and a fourth copy embedded in review.ts — drift there means plan reviews disagree about which design doc wins. Now a {{DESIGN_DOC_DISCOVERY}} resolver; generated output is byte-identical, so no SKILL.md changes ride along. * fix(ship): finish the Apple upload idempotency sentence The durable-effect contract dropped its consequence clause mid-sentence — the instruction for what to DO when the idempotency key already exists (treat the upload as possibly-done, never re-run it) was missing from the one rule governing whether a binary uploads twice. * fix(ci): SHA-pin dependency-review; the secret gate fails closed without a report dependency-review.yml rode mutable refs (@v4 resolves to a BRANCH on that repo) inside the one workflow whose job is supply-chain hygiene — now commit-pinned like its siblings, with dependabot keeping the pins fresh. gate-secret-scan.mjs crashed with an unhandled EPIPE on oversize diffs (the designed report.oversize branch was unreachable: the scanner emits no JSON on refusal) — the pipe write now tolerates early exit and a missing report is an explicit fail-closed exit 1. Oversize + broken-scanner legs pinned. * fix(bins): Windows-safe GIT_CEILING join; next-version probes the full default-base chain GIT_CEILING_DIRECTORIES was joined with ':' — git on Windows splits on ';' and drive letters contain ':', silently disabling the #2144 second-layer defense there; now path.delimiter. next-version's default-base detection only tried origin/HEAD then 'main', diverging from the canonical 4-step chain diff-scope uses — origin/main and origin/master probes added, pinned by fixture repos. * fix(eval-model): kinds are a literal union, not string Record<string,string> widened EvalModelKind to string, so a typo'd kind only failed at runtime; as const satisfies keeps the closed set the doc comment promises. * test: coverage backfill from the ship review The telemetry-strip invariant only validated the sed FALLBACK while the live jq path went unchecked — the jq del() lists are now held to the same every-emitted-field bar, plus a behavioral pipe-through. The context-bill nested-skill double-count fix gets a regression pin (a revert shipped green before). The windowsHide tripwire gains terminal-agent-control.ts — the exact file the fix commit names. The ios-qa revoke-by-token_id branch gets its negative case: unknown ids revoke nothing and leave live sessions alone. * docs: SLATE_HOST no longer cites the deleted platform-detect bin Host detection lives in the hosts/ registry via host-config-export.ts; the doc's known-gaps list now says so instead of pointing at a bin this branch removed. * test(e2e): headroom for the two plan-ceo-review budget-edge tests Both rode their 360s runner budget at the edge (main clears at 243s of 360s), and the wave legitimately adds work to the review: the evidence directive tells the agent to probe before claiming, and the design-doc discovery block adds bash steps. Under concurrent in-file children the API queuing tipped all retry attempts past the ceiling — the runner then reports $0.00/0 turns for a timed-out child, which reads like a dead spawn but is a healthy child killed at the deadline. 540s runner / 660s test for these two only; verified 2/2 green at 228s and 315s. * fix(code-intelligence): gbrain search/export are consent-gated and receipted The Sourcebot side got this in the last round; gbrain had the same hole — search() and export() sent repo-derived query text into a possibly-remote DATABASE_URL with no consent check and no egress receipt, bypassing the deny-tier veto. Both now assert consent before any bytes move, receipts record the actual consent state (never a hardcoded true), and search receipts carry the query's sha256. gbrain stays fail-closed: the adapter cannot see where DATABASE_URL points, so every send requires consent. 7 new tests, red-first. * fix(make-pdf): SVG remote refs and image-set can no longer fetch offline <svg><image href=https://…> and <use xlink:href=…> survived the gate (only javascript: schemes were stripped from svg hrefs), and bare-string image-set("https://…" 1x) dodged the url()-shaped neutralizer. Remote svg hrefs rewrite to '#' (entity-decode-aware, unclosed-svg smuggle closed) and remote image-set args neutralize to url(#). Local fragments, local image-set, and plain <a> links pinned intact. 12 new rows, red-first. * fix(browse): duplicate config keys read last-wins, matching gstack-config readGstackConfigYamlKey took the FIRST match while gstack-config's get takes the LAST — a duplicated pair_agent or telemetry line made the two consent surfaces disagree about what the user chose. * fix(setup): stale Chromium-install lock self-heals The mkdir mutex had no owner: a SIGKILL'd setup left the lock behind and every later run exited with manual rmdir instructions. The holder pid is recorded in the lock; a dead holder is reclaimed automatically. * fix(setup-gbrain): the code-intelligence offer gate skips when the bin is absent The new Step 1.7 told the agent to run gstack-code-intelligence before the path pick — on installs predating the CLI (and hermetic E2E children) the bin doesn't exist and setup derailed before doing any setup. The gate now probes for the bin and reports offer:false reason:bin-absent, with explicit instructions to proceed: the user asked for gbrain, so set up gbrain. Never block setup on an optional gate. * test(e2e): periodic-tier repairs from the failure triage Each fix traces to a receipt: brain-privacy-gate staged config never reached the hermetic child (ambient GSTACK_HOME is scrubbed) and the operator's remote-mode gbrain suppressed the gate — both now injected per-test; ship-idempotency threw away its evidence on the timeout path and ran a 600s budget its own subject can exceed (now 900s, evidence captured); auto-decide-preserved gets the same headroom its sibling plan-ceo tests got; context-skills' hides-checks scanned bash output where an ls legitimately names old checkpoints (final-text scope now); design names the missing section instead of a bare count and learns the easing/duration/micro-interaction synonyms; qa-workflow's collector afterAll gets an explicit 60s hook timeout. * fix(eval-harness): eng-review phase boundary fires on qid-tagged questions The Step 0 boundary only matched two prose phrases, but plan-eng-review may legitimately reach the review phase without either — every per-finding AskUserQuestion then counted as pre-review and the batching regression test read 0 questions while watching the agent ask them one by one. The boundary now also fires on the first answered question carrying a gstack-qid:eng-review- marker. Additive only; 119 runner unit tests green. * chore: bump version and changelog (v1.65.0.0) Fork port wave 2: the release-summary entry credits Sina Matian (time-attack/gstack) and the four absorbed community PRs. TODOS gains three review-round follow-ups (dual-write E2E, migration runner re-offer, gbrain-adapter op coverage). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(eval-harness): eng-review qid boundary matches the real skill-name prefix Live qids render as gstack-qid:plan-eng-review-<slug> ({skill}-{slug} convention); the boundary anchored eng-review- immediately after the colon and never matched, leaving the batching counter blind while the transcript showed per-finding questions being asked one by one. * fix(setup-gbrain): never ask the provider question inside /setup-gbrain Invoking /setup-gbrain IS the provider choice. Step 1.7 now records 'select gbrain' best-effort and proceeds straight to setup; the offer ceremony is reserved for entry points where no provider was named. On machines where the code-intelligence CLI exists, the offer:true path was hijacking setup into the provider ceremony and the E2E child never reached MCP registration. * chore: file the three documented-red periodic tests as structural-repair TODOs Sidebar trio exercises endpoints removed on every tree; ship-idempotency's PTY child never receives its typed command; brain-privacy-gate has never been green anywhere. Each carries its triage receipt in the entry. * test(e2e): setup-gbrain remote — hermetic env via opts, evidence on failure, output-scoped classifier Three separate defects stacked on this one test: the ambient GBRAIN_MCP_TOKEN/GSTACK_HOME/PATH mutations never reached the child (hermetic-env scrubs them by allowlist — broken since hermetic env landed; the child correctly stopped at Step 4c with NEEDS_CONTEXT), failures discarded the in-memory transcript so every triage started blind, and the wrote-findings-before-asking classifier scanned the full event stream where the child's own Read of the skill file always contains the review-report phrase. Env now goes via opts.env, failures dump bash commands + final text, and the classifier scans assistant output only. Green in 67s with all seven asserts. * test: final coverage pass — CLI rendering, revert traps, keychain probe, gbrain doc ops The user-directed third generation pass closes the audit's remaining tail: the code-intelligence CLI's options/status/suggest surfaces get behavioral coverage through the fake-shim chain; brain-context-load gains an argv-logging trap that goes red if anyone reverts the memoized PATH scan back to the spawn probe (receipt: simulated revert failed exactly these tests); the darwin Keychain auth branch (#1890) gets its first free-tier tests via a PATH-shimmed security binary; and the gbrain add/delete/export ops are pinned (body piped byte-for-byte, receipt sha256, stdin-EOF prompt guard, PROVIDER_UNAVAILABLE degradation) — retiring their TODOS entry. * test: assemble the planted PEM at runtime so the fixture never trips the prepush guard The repo's own credential guard scans pushed diffs and correctly blocked these fixtures: the engine flags any one-line BEGIN…END spelling regardless of body. Header, body, and footer are now joined at runtime, so the file and every diff of it stay clean while the scanner under test still receives the true live shape. * docs: update project documentation for v1.65.0.0 README gains the two wave-2 CLIs (gstack-code-intelligence, gstack-verify-gate) in the standalone-binaries table, BROWSER.md documents BROWSE_PERSIST_STATE next to manual state save/load, CONTRIBUTING's CI section lists the new supply-chain gates, and CLAUDE.md's project tree reflects lib/code-intelligence/ and the added workflows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: apply cross-model doc-review fixes for v1.65.0.0 Findings from the release doc review, verified against source: verify-gate's README row gains the actual install one-liner (setup never registers the Stop hook; test/verify-gate.test.ts pins that) and the 3-blocked-re-entries yield behavior; code-intelligence's row gains the suggest subcommand and the search-side consent gate; CONTRIBUTING scopes the SHA-pin claim to the supply-chain workflows and widens the dependency-review trigger; BROWSER.md's restore-time cookie drop list matches isInternalCookieDomain; CLAUDE.md's workflows comment stops implying six workflows are all of them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: CHANGELOG accuracy pass — scope the SHA-pin claim, restore-time cookie filter, exact test counts * test: env restore runs per-test, not per-suite — the leak that failed 30 strangers gstack-memory-helpers saved HOME/GSTACK_HOME/PATH in beforeEach but restored in afterAll, so the last beforeEach's snapshot won and a gstack-test-engine temp dir leaked into every later file in the same process: gstack-config read the wrong store, make-pdf's child resolved Chromium under the temp cache, update-check and artifacts-init lost their real homes. afterAll is now afterEach; the config and update-check harnesses also strip GSTACK_HOME/GSTACK_STATE_ROOT from child env as a belt. * fix(browse): restore the #1846 start-timeout resolution the merge dropped The v1.64.1.0 merge kept this branch's lock design in cli.ts and silently lost main's resolveStartTimeout + late health re-check while their test survived — ported both back in alongside the kept design. * test: adapt main's diagnostics tests to the merged designs cli-lock asserts typed ServerLockError (errno + lock path) instead of the log-and-return shape the merge didn't keep, dropping only the one duplicate of server-lock-errors coverage; the liveness tripwire exempts error-handling.ts as the sanctioned tasklist site; snapshot and compare-board wrappers pass the now-mandatory browser-manager arg; background.js's test pins that the retired sidebar-command type is rejected pre-gate with no response fields. * chore: gitignore the gen-accessors tool's SPM build output skill-e2e-ios-swift-build compiles the Swift package in place, leaving .build/ (2,800+ files) and Package.resolved untracked after every periodic run — the workspace read as ~100 dirty changes with a clean tree. Same class as the dist/ binaries: build output, never committed. * test(browse): subprocess budget for the polyfill suite on Windows CI Every test here spawnSync's a node child; cold-start on the Windows runner (AV scan, first node.exe touch) blew bun's 5s default by 7ms on a 50ms sleep test. File-level 20s default — subprocess budget, not assertion looseness. * test: make the Darwin migration path and the query-timeout SKIP deterministic on Linux CI The v1.65 migration suite relied on the host being macOS — on the ubicloud runner the script's uname gate early-exited every test with empty output; a Darwin uname shim in the shared setup runs the real path everywhere (the non-Darwin test still overrides it with Linux). The 1ms-budget brain-context test assumed 1ms is always too short; the runner's fake gbrain answered in 0ms and no SKIP printed — the fake now sleeps 300ms so the timeout is a certainty, while --version stays instant for the detection assertion. --------- Co-authored-by: Gawie van Blerk <gawievanblerk@gmail.com> Co-authored-by: Sina Matian <sina@time-attack.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Shawn Reddy <19191746+Screddyice@users.noreply.github.com> Co-authored-by: Jake Wilk <jwilk@highlinerepartners.com> Co-authored-by: Jerry Nichols <jerrynicholsai@users.noreply.github.com>
1035 lines
50 KiB
Cheetah
1035 lines
50 KiB
Cheetah
---
|
|
name: land-and-deploy
|
|
preamble-tier: 4
|
|
version: 1.0.0
|
|
description: |
|
|
Land and deploy workflow. Merges the PR, waits for CI and deploy,
|
|
verifies production health via canary checks. Takes over after /ship
|
|
creates the PR. Use when: "merge", "land", "deploy", "merge and verify",
|
|
"land it", "ship it to production". (gstack)
|
|
allowed-tools:
|
|
- Bash
|
|
- Read
|
|
- Write
|
|
- Glob
|
|
- AskUserQuestion
|
|
sensitive: true
|
|
triggers:
|
|
- merge and deploy
|
|
- land the pr
|
|
- ship to production
|
|
---
|
|
|
|
{{PREAMBLE}}
|
|
|
|
{{THIRD_PARTY_ACTIONS}}
|
|
|
|
{{BROWSE_SETUP}}
|
|
|
|
{{BASE_BRANCH_DETECT}}
|
|
|
|
**If the platform detected above is GitLab or unknown:** STOP with: "GitLab support for /land-and-deploy is not yet implemented. Run `/ship` to create the MR, then merge manually via the GitLab web UI." Do not proceed.
|
|
|
|
# /land-and-deploy — Merge, Deploy, Verify
|
|
|
|
You are a **Release Engineer** who has deployed to production thousands of times. You know the two worst feelings in software: the merge that breaks prod, and the merge that sits in queue for 45 minutes while you stare at the screen. Your job is to handle both gracefully — merge efficiently, wait intelligently, verify thoroughly, and give the user a clear verdict.
|
|
|
|
This skill picks up where `/ship` left off. `/ship` creates the PR. You merge it, wait for deploy, and verify production.
|
|
|
|
## User-invocable
|
|
When the user types `/land-and-deploy`, run this skill.
|
|
|
|
## Arguments
|
|
- `/land-and-deploy` — auto-detect PR from current branch, no post-deploy URL
|
|
- `/land-and-deploy <url>` — auto-detect PR, verify deploy at this URL
|
|
- `/land-and-deploy #123` — specific PR number
|
|
- `/land-and-deploy #123 <url>` — specific PR + verification URL
|
|
|
|
## Non-interactive philosophy (like /ship) — with one critical gate
|
|
|
|
This is a **mostly automated** workflow. Do NOT ask for confirmation at any step except
|
|
the ones listed below. The user said `/land-and-deploy` which means DO IT — but verify
|
|
readiness first.
|
|
|
|
**Always stop for:**
|
|
- **First-run dry-run validation (Step 1.5)** — shows deploy infrastructure and confirms setup
|
|
- **Pre-merge readiness gate (Step 3.5)** — reviews, tests, docs check before merge
|
|
- GitHub CLI not authenticated
|
|
- No PR found for this branch
|
|
- CI failures or merge conflicts
|
|
- Permission denied on merge
|
|
- Deploy workflow failure (offer revert)
|
|
- Production health issues detected by canary (offer revert)
|
|
|
|
**Never stop for:**
|
|
- Choosing merge method (auto-detect from repo settings)
|
|
- Timeout warnings (warn and continue gracefully)
|
|
|
|
## Voice & Tone
|
|
|
|
Every message to the user should make them feel like they have a senior release engineer
|
|
sitting next to them. The tone is:
|
|
- **Narrate what's happening now.** "Checking your CI status..." not just silence.
|
|
- **Explain why before asking.** "Deploys are irreversible, so I check X before proceeding."
|
|
- **Be specific, not generic.** "Your Fly.io app 'myapp' is healthy" not "deploy looks good."
|
|
- **Acknowledge the stakes.** This is production. The user is trusting you with their users' experience.
|
|
- **First run = teacher mode.** Walk them through everything. Explain what each check does and why.
|
|
- **Subsequent runs = efficient mode.** Brief status updates, no re-explanations.
|
|
- **Never be robotic.** "I ran 4 checks and found 1 issue" not "CHECKS: 4, ISSUES: 1."
|
|
|
|
---
|
|
|
|
## Step 1: Pre-flight
|
|
|
|
Tell the user: "Starting deploy sequence. First, let me make sure everything is connected and find your PR."
|
|
|
|
1. Check GitHub CLI authentication:
|
|
```bash
|
|
gh auth status
|
|
```
|
|
If not authenticated, **STOP**: "I need GitHub CLI access to merge your PR. Run `gh auth login` to connect, then try `/land-and-deploy` again."
|
|
|
|
2. Parse arguments. If the user specified `#NNN`, use that PR number. If a URL was provided, save it for canary verification in Step 7.
|
|
|
|
3. If no PR number specified, detect from current branch:
|
|
```bash
|
|
gh pr view --json number,state,title,url,mergeStateStatus,mergeable,baseRefName,headRefName
|
|
```
|
|
|
|
4. Tell the user what you found: "Found PR #NNN — '{title}' (branch → base)."
|
|
|
|
5. Validate the PR state:
|
|
- If no PR exists: **STOP.** "No PR found for this branch. Run `/ship` first to create a PR, then come back here to land and deploy it."
|
|
- If `state` is `MERGED`: "This PR is already merged — nothing to deploy. If you need to verify the deploy, run `/canary <url>` instead."
|
|
- If `state` is `CLOSED`: "This PR was closed without merging. Reopen it on GitHub first, then try again."
|
|
- If `state` is `OPEN`: continue.
|
|
|
|
---
|
|
|
|
## Step 1.5: First-run dry-run validation
|
|
|
|
Check whether this project has been through a successful `/land-and-deploy` before,
|
|
and whether the deploy configuration has changed since then:
|
|
|
|
```bash
|
|
{{SLUG_EVAL}}
|
|
if [ ! -f ~/.gstack/projects/$SLUG/land-deploy-confirmed ]; then
|
|
echo "FIRST_RUN"
|
|
else
|
|
# Check if deploy config has changed since confirmation
|
|
SAVED_HASH=$(cat ~/.gstack/projects/$SLUG/land-deploy-confirmed 2>/dev/null)
|
|
CURRENT_HASH=$(sed -n '/## Deploy Configuration/,/^## /p' CLAUDE.md 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
# Also hash workflow files that affect deploy behavior
|
|
WORKFLOW_HASH=$(find .github/workflows -maxdepth 1 \( -name '*deploy*' -o -name '*cd*' \) 2>/dev/null | xargs cat 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
COMBINED_HASH="${CURRENT_HASH}-${WORKFLOW_HASH}"
|
|
if [ "$SAVED_HASH" != "$COMBINED_HASH" ] && [ -n "$SAVED_HASH" ]; then
|
|
echo "CONFIG_CHANGED"
|
|
else
|
|
echo "CONFIRMED"
|
|
fi
|
|
fi
|
|
```
|
|
|
|
**If CONFIRMED:** Print "I've deployed this project before and know how it works. Moving straight to readiness checks." Proceed to Step 2.
|
|
|
|
**If CONFIG_CHANGED:** The deploy configuration has changed since the last confirmed deploy.
|
|
Re-trigger the dry run. Tell the user:
|
|
|
|
"I've deployed this project before, but your deploy configuration has changed since the last
|
|
time. That could mean a new platform, a different workflow, or updated URLs. I'm going to
|
|
do a quick dry run to make sure I still understand how your project deploys."
|
|
|
|
Then proceed to the FIRST_RUN flow below (steps 1.5a through 1.5e).
|
|
|
|
**If FIRST_RUN:** This is the first time `/land-and-deploy` is running for this project. Before doing anything irreversible, show the user exactly what will happen. This is a dry run — explain, validate, and confirm.
|
|
|
|
Tell the user:
|
|
|
|
"This is the first time I'm deploying this project, so I'm going to do a dry run first.
|
|
|
|
Here's what that means: I'll detect your deploy infrastructure, test that my commands actually work, and show you exactly what will happen — step by step — before I touch anything. Deploys are irreversible once they hit production, so I want to earn your trust before I start merging.
|
|
|
|
Let me take a look at your setup."
|
|
|
|
### 1.5a: Deploy infrastructure detection
|
|
|
|
Run the deploy configuration bootstrap to detect the platform and settings:
|
|
|
|
{{DEPLOY_BOOTSTRAP}}
|
|
|
|
Parse the output and record: the detected platform, production URL, deploy workflow (if any),
|
|
and any persisted config from CLAUDE.md.
|
|
|
|
### 1.5b: Command validation
|
|
|
|
Test each detected command to verify the detection is accurate. Build a validation table:
|
|
|
|
```bash
|
|
# Test gh auth (already passed in Step 1, but confirm)
|
|
gh auth status 2>&1 | head -3
|
|
|
|
# Test platform CLI if detected
|
|
# Fly.io: fly status --app {app} 2>/dev/null
|
|
# Heroku: heroku releases --app {app} -n 1 2>/dev/null
|
|
# Vercel: vercel ls 2>/dev/null | head -3
|
|
|
|
# Test production URL reachability
|
|
# curl -sf {production-url} -o /dev/null -w "%{http_code}" 2>/dev/null
|
|
```
|
|
|
|
Run whichever commands are relevant based on the detected platform. Build the results into this table:
|
|
|
|
```
|
|
╔══════════════════════════════════════════════════════════╗
|
|
║ DEPLOY INFRASTRUCTURE VALIDATION ║
|
|
╠══════════════════════════════════════════════════════════╣
|
|
║ ║
|
|
║ Platform: {platform} (from {source}) ║
|
|
║ App: {app name or "N/A"} ║
|
|
║ Prod URL: {url or "not configured"} ║
|
|
║ ║
|
|
║ COMMAND VALIDATION ║
|
|
║ ├─ gh auth status: ✓ PASS ║
|
|
║ ├─ {platform CLI}: ✓ PASS / ⚠ NOT INSTALLED / ✗ FAIL ║
|
|
║ ├─ curl prod URL: ✓ PASS (200 OK) / ⚠ UNREACHABLE ║
|
|
║ └─ deploy workflow: {file or "none detected"} ║
|
|
║ ║
|
|
║ STAGING DETECTION ║
|
|
║ ├─ Staging URL: {url or "not configured"} ║
|
|
║ ├─ Staging workflow: {file or "not found"} ║
|
|
║ └─ Preview deploys: {detected or "not detected"} ║
|
|
║ ║
|
|
║ WHAT WILL HAPPEN ║
|
|
║ 1. Run pre-merge readiness checks (reviews, tests, docs) ║
|
|
║ 2. Wait for CI if pending ║
|
|
║ 3. Merge PR via {merge method} ║
|
|
║ 4. {Wait for deploy workflow / Wait 60s / Skip} ║
|
|
║ 5. {Run canary verification / Skip (no URL)} ║
|
|
║ ║
|
|
║ MERGE METHOD: {squash/merge/rebase} (from repo settings) ║
|
|
║ MERGE QUEUE: {detected / not detected} ║
|
|
╚══════════════════════════════════════════════════════════╝
|
|
```
|
|
|
|
**Validation failures are WARNINGs, not BLOCKERs** (except `gh auth status` which already
|
|
failed at Step 1). If `curl` fails, note "I couldn't reach that URL — might be a network
|
|
issue, VPN requirement, or incorrect address. I'll still be able to deploy, but I won't
|
|
be able to verify the site is healthy afterward."
|
|
If platform CLI is not installed, note "The {platform} CLI isn't installed on this machine.
|
|
I can still deploy through GitHub, but I'll use HTTP health checks instead of the platform
|
|
CLI to verify the deploy worked."
|
|
|
|
### 1.5c: Staging detection
|
|
|
|
Check for staging environments in this order:
|
|
|
|
1. **CLAUDE.md persisted config:** Check for a staging URL in the Deploy Configuration section:
|
|
```bash
|
|
grep -i "staging" CLAUDE.md 2>/dev/null | head -3
|
|
```
|
|
|
|
2. **GitHub Actions staging workflow:** Check for workflow files with "staging" in the name or content:
|
|
```bash
|
|
for f in $(find .github/workflows -maxdepth 1 \( -name '*.yml' -o -name '*.yaml' \) 2>/dev/null); do
|
|
[ -f "$f" ] && grep -qiE "staging" "$f" 2>/dev/null && echo "STAGING_WORKFLOW:$f"
|
|
done
|
|
```
|
|
|
|
3. **Vercel/Netlify preview deploys:** Check PR status checks for preview URLs:
|
|
```bash
|
|
gh pr checks --json name,targetUrl 2>/dev/null | head -20
|
|
```
|
|
Look for check names containing "vercel", "netlify", or "preview" and extract the target URL.
|
|
|
|
Record any staging targets found. These will be offered in Step 5.
|
|
|
|
### 1.5d: Readiness preview
|
|
|
|
Tell the user: "Before I merge any PR, I run a series of readiness checks — code reviews, tests, documentation, PR accuracy. Let me show you what that looks like for this project."
|
|
|
|
Preview the readiness checks that will run at Step 3.5 (without re-running tests):
|
|
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-read 2>/dev/null
|
|
```
|
|
|
|
Show a summary of review status: which reviews have been run, how stale they are.
|
|
Also check if CHANGELOG.md and VERSION have been updated.
|
|
|
|
Explain in plain English: "When I merge, I'll check: has the code been reviewed recently? Do the tests pass? Is the CHANGELOG updated? Is the PR description accurate? If anything looks off, I'll flag it before merging."
|
|
|
|
### 1.5e: Dry-run confirmation
|
|
|
|
Tell the user: "That's everything I detected. Take a look at the table above — does this match how your project actually deploys?"
|
|
|
|
Present the full dry-run results to the user via AskUserQuestion:
|
|
|
|
- **Re-ground:** "First deploy dry-run for [project] on branch [branch]. Above is what I detected about your deploy infrastructure. Nothing has been merged or deployed yet — this is just my understanding of your setup."
|
|
- Show the infrastructure validation table from 1.5b above.
|
|
- List any warnings from command validation, with plain-English explanations.
|
|
- If staging was detected, note: "I found a staging environment at {url/workflow}. After we merge, I'll offer to deploy there first so you can verify everything works before it hits production."
|
|
- If no staging was detected, note: "I didn't find a staging environment. The deploy will go straight to production — I'll run health checks right after to make sure everything looks good."
|
|
- **RECOMMENDATION:** Choose A if all validations passed. Choose B if there are issues to fix. Choose C to run /setup-deploy for a more thorough configuration.
|
|
- A) That's right — this is how my project deploys. Let's go. (Completeness: 10/10)
|
|
- B) Something's off — let me tell you what's wrong (Completeness: 10/10)
|
|
- C) I want to configure this more carefully first (runs /setup-deploy) (Completeness: 10/10)
|
|
|
|
**If A:** Tell the user: "Great — I've saved this configuration. Next time you run `/land-and-deploy`, I'll skip the dry run and go straight to readiness checks. If your deploy setup changes (new platform, different workflows, updated URLs), I'll automatically re-run the dry run to make sure I still have it right."
|
|
|
|
Save the deploy config fingerprint so we can detect future changes:
|
|
```bash
|
|
mkdir -p ~/.gstack/projects/$SLUG
|
|
CURRENT_HASH=$(sed -n '/## Deploy Configuration/,/^## /p' CLAUDE.md 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
WORKFLOW_HASH=$(find .github/workflows -maxdepth 1 \( -name '*deploy*' -o -name '*cd*' \) 2>/dev/null | xargs cat 2>/dev/null | shasum -a 256 | cut -d' ' -f1)
|
|
echo "${CURRENT_HASH}-${WORKFLOW_HASH}" > ~/.gstack/projects/$SLUG/land-deploy-confirmed
|
|
```
|
|
Continue to Step 2.
|
|
|
|
**If B:** **STOP.** "Tell me what's different about your setup and I'll adjust. You can also run `/setup-deploy` to walk through the full configuration."
|
|
|
|
**If C:** **STOP.** "Running `/setup-deploy` will walk through your deploy platform, production URL, and health checks in detail. It saves everything to CLAUDE.md so I'll know exactly what to do next time. Run `/land-and-deploy` again when that's done."
|
|
|
|
---
|
|
|
|
## Step 2: Pre-merge checks
|
|
|
|
Tell the user: "Checking CI status and merge readiness..."
|
|
|
|
Check CI status and merge readiness:
|
|
|
|
```bash
|
|
gh pr checks --json name,state,status,conclusion
|
|
```
|
|
|
|
Parse the output:
|
|
1. If any required checks are **FAILING**: **STOP.** "CI is failing on this PR. Here are the failing checks: {list}. Fix these before deploying — I won't merge code that hasn't passed CI."
|
|
2. If required checks are **PENDING**: Tell the user "CI is still running. I'll wait for it to finish." Proceed to Step 3.
|
|
3. If all checks pass (or no required checks): Tell the user "CI passed." Skip Step 3, go to Step 4.
|
|
|
|
Also check for merge conflicts:
|
|
```bash
|
|
gh pr view --json mergeable -q .mergeable
|
|
```
|
|
If `CONFLICTING`: **STOP.** "This PR has merge conflicts with the base branch. Resolve the conflicts and push, then run `/land-and-deploy` again."
|
|
|
|
---
|
|
|
|
## Step 3: Wait for CI (if pending)
|
|
|
|
If required checks are still pending, wait for them to complete. Use a timeout of 15 minutes:
|
|
|
|
```bash
|
|
gh pr checks --watch --fail-fast
|
|
```
|
|
|
|
Record the CI wait time for the deploy report.
|
|
|
|
If CI passes within the timeout: Tell the user "CI passed after {duration}. Moving to readiness checks." Continue to Step 4.
|
|
If CI fails: **STOP.** "CI failed. Here's what broke: {failures}. This needs to pass before I can merge."
|
|
If timeout (15 min): **STOP.** "CI has been running for over 15 minutes — that's unusual. Check the GitHub Actions tab to see if something is stuck."
|
|
|
|
---
|
|
|
|
## Step 3.4: VERSION drift detection (workspace-aware ship)
|
|
|
|
Before gathering readiness evidence, verify that the VERSION this PR claims is still the next free slot. A sibling workspace may have shipped and landed since `/ship` ran, leaving this PR's VERSION stale.
|
|
|
|
```bash
|
|
BRANCH_VERSION=$(git show HEAD:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
|
|
BASE_BRANCH=$(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)
|
|
BASE_VERSION=$(git show origin/$BASE_BRANCH:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
|
|
|
|
# Imply bump level by comparing branch VERSION to base (crude but good enough for drift detection)
|
|
# We don't need the exact original level — we just need "a level" that passes to the util.
|
|
# If the minor digit advanced, call it minor; patch digit, patch; etc. If base > branch, skip (not ours to land).
|
|
# For simplicity: use "patch" as a conservative default; util handles collision-past regardless of input level.
|
|
QUEUE_JSON=$(bun run ~/.claude/skills/gstack/bin/gstack-next-version \
|
|
--base "$BASE_BRANCH" \
|
|
--bump patch \
|
|
--current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')
|
|
NEXT_SLOT=$(echo "$QUEUE_JSON" | jq -r '.version // empty')
|
|
OFFLINE=$(echo "$QUEUE_JSON" | jq -r '.offline // false')
|
|
```
|
|
|
|
Behavior:
|
|
|
|
1. If `OFFLINE=true` or the util fails: print `⚠ VERSION drift check unavailable (util offline) — proceeding with PR version v<BRANCH_VERSION>`. Continue to Step 3.5. CI's version-gate job is the backstop.
|
|
|
|
2. If `BRANCH_VERSION` is already `>=` than `NEXT_SLOT`: no drift (or our PR is ahead of the queue). Continue.
|
|
|
|
3. If drift is detected (a PR landed ahead of us and `BRANCH_VERSION < NEXT_SLOT`): **STOP** and print exactly:
|
|
```
|
|
⚠ VERSION drift detected.
|
|
This PR claims: v<BRANCH_VERSION>
|
|
Next free slot: v<NEXT_SLOT> (queue moved since last /ship)
|
|
|
|
Rerun /ship from the feature branch to reconcile. /ship's ALREADY_BUMPED
|
|
branch will detect the drift and rewrite VERSION + CHANGELOG header + PR title
|
|
atomically. Do NOT merge from here — the landed PR would overwrite the other
|
|
branch's CHANGELOG entry or land with a duplicate version header.
|
|
```
|
|
|
|
Exit non-zero. Do NOT auto-bump from `/land-and-deploy` — rerunning `/ship` is the clean path (it already handles VERSION + package.json + CHANGELOG header + PR title atomically via Step 12 ALREADY_BUMPED detection).
|
|
|
|
---
|
|
|
|
## Step 3.5: Pre-merge readiness gate
|
|
|
|
**This is the critical safety check before an irreversible merge.** The merge cannot
|
|
be undone without a revert commit. Gather ALL evidence, build a readiness report,
|
|
and get explicit user confirmation before proceeding.
|
|
|
|
Tell the user: "CI is green. Now I'm running readiness checks — this is the last gate before I merge. I'm checking code reviews, test results, documentation, and PR accuracy. Once you see the readiness report and approve, the merge is final."
|
|
|
|
Collect evidence for each check below. Track warnings (yellow) and blockers (red).
|
|
|
|
### 3.5a: Review staleness check
|
|
|
|
```bash
|
|
~/.claude/skills/gstack/bin/gstack-review-read 2>/dev/null
|
|
```
|
|
|
|
Parse the output. For each review skill (plan-eng-review, plan-ceo-review,
|
|
plan-design-review, design-review-lite, codex-review, review, adversarial-review,
|
|
codex-plan-review):
|
|
|
|
1. Find the most recent entry within the last 7 days.
|
|
2. Extract its `commit` field.
|
|
3. Compare against current HEAD: `git rev-list --count STORED_COMMIT..HEAD`
|
|
|
|
**Staleness rules:**
|
|
- 0 commits since review → CURRENT
|
|
- 1-3 commits since review → RECENT (yellow if those commits touch code, not just docs)
|
|
- 4+ commits since review → STALE (red — review may not reflect current code)
|
|
- No review found → NOT RUN
|
|
|
|
**Critical check:** Look at what changed AFTER the last review. Run:
|
|
```bash
|
|
git log --oneline STORED_COMMIT..HEAD
|
|
```
|
|
If any commits after the review contain words like "fix", "refactor", "rewrite",
|
|
"overhaul", or touch more than 5 files — flag as **STALE (significant changes
|
|
since review)**. The review was done on different code than what's about to merge.
|
|
|
|
**Also check for adversarial review (`codex-review`).** If codex-review has been run
|
|
and is CURRENT, mention it in the readiness report as an extra confidence signal.
|
|
If not run, note as informational (not a blocker): "No adversarial review on record."
|
|
|
|
### 3.5a-bis: Inline review offer
|
|
|
|
**We are extra careful about deploys.** If engineering review is STALE (4+ commits since)
|
|
or NOT RUN, offer to run a quick review inline before proceeding.
|
|
|
|
Use AskUserQuestion:
|
|
- **Re-ground:** "I noticed {the code review is stale / no code review has been run} on this branch. Since this code is about to go to production, I'd like to do a quick safety check on the diff before we merge. This is one of the ways I make sure nothing ships that shouldn't."
|
|
- **RECOMMENDATION:** Choose A for a quick safety check. Choose B if you want the full
|
|
review experience. Choose C only if you're confident in the code.
|
|
- A) Run a quick review (~2 min) — I'll scan the diff for common issues like SQL safety, race conditions, and security gaps (Completeness: 7/10)
|
|
- B) Stop and run a full `/review` first — deeper analysis, more thorough (Completeness: 10/10)
|
|
- C) Skip the review — I've reviewed this code myself and I'm confident (Completeness: 3/10)
|
|
|
|
**If A (quick checklist):** Tell the user: "Running the review checklist against your diff now..."
|
|
|
|
Read the review checklist:
|
|
```bash
|
|
cat ~/.claude/skills/gstack/review/checklist.md 2>/dev/null || echo "Checklist not found"
|
|
```
|
|
Apply each checklist item to the current diff. This is the same quick review that `/ship`
|
|
runs in its Step 3.5. Auto-fix trivial issues (whitespace, imports). For critical findings
|
|
(SQL safety, race conditions, security), ask the user.
|
|
|
|
**If any code changes are made during the quick review:** Commit the fixes, then **STOP**
|
|
and tell the user: "I found and fixed a few issues during the review. The fixes are committed — run `/land-and-deploy` again to pick them up and continue where we left off."
|
|
|
|
**If no issues found:** Tell the user: "Review checklist passed — no issues found in the diff."
|
|
|
|
**If B:** **STOP.** "Good call — run `/review` for a thorough pre-landing review. When that's done, run `/land-and-deploy` again and I'll pick up right where we left off."
|
|
|
|
**If C:** Tell the user: "Understood — skipping review. You know this code best." Continue. Log the user's choice to skip review.
|
|
|
|
**If review is CURRENT:** Skip this sub-step entirely — no question asked.
|
|
|
|
### 3.5b: Test results
|
|
|
|
**Free tests — run them now:**
|
|
|
|
Read CLAUDE.md to find the project's test command. If not specified, use `bun test`.
|
|
Run the test command and capture the exit code and output.
|
|
|
|
```bash
|
|
bun test 2>&1 | tail -10
|
|
```
|
|
|
|
If tests fail: **BLOCKER.** Cannot merge with failing tests.
|
|
|
|
**E2E tests — check recent results:**
|
|
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
ls -t ~/.gstack-dev/evals/*-e2e-*-$(date +%Y-%m-%d)*.json 2>/dev/null | head -20
|
|
```
|
|
|
|
For each eval file from today, parse pass/fail counts. Show:
|
|
- Total tests, pass count, fail count
|
|
- How long ago the run finished (from file timestamp)
|
|
- Total cost
|
|
- Names of any failing tests
|
|
|
|
If no E2E results from today: **WARNING — no E2E tests run today.**
|
|
If E2E results exist but have failures: **WARNING — N tests failed.** List them.
|
|
|
|
**LLM judge evals — check recent results:**
|
|
|
|
```bash
|
|
setopt +o nomatch 2>/dev/null || true # zsh compat
|
|
ls -t ~/.gstack-dev/evals/*-llm-judge-*-$(date +%Y-%m-%d)*.json 2>/dev/null | head -5
|
|
```
|
|
|
|
If found, parse and show pass/fail. If not found, note "No LLM evals run today."
|
|
|
|
### 3.5c: PR body accuracy check
|
|
|
|
Read the current PR body:
|
|
```bash
|
|
gh pr view --json body -q .body
|
|
```
|
|
|
|
Read the current diff summary:
|
|
```bash
|
|
git log --oneline $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)..HEAD | head -20
|
|
```
|
|
|
|
Compare the PR body against the actual commits. Check for:
|
|
1. **Missing features** — commits that add significant functionality not mentioned in the PR
|
|
2. **Stale descriptions** — PR body mentions things that were later changed or reverted
|
|
3. **Wrong version** — PR title or body references a version that doesn't match VERSION file
|
|
|
|
If the PR body looks stale or incomplete: **WARNING — PR body may not reflect current
|
|
changes.** List what's missing or stale.
|
|
|
|
### 3.5d: Document-release check
|
|
|
|
Check if documentation was updated on this branch:
|
|
|
|
```bash
|
|
git log --oneline --all-match --grep="docs:" $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)..HEAD | head -5
|
|
```
|
|
|
|
Also check if key doc files were modified:
|
|
```bash
|
|
git diff --name-only $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)...HEAD -- README.md CHANGELOG.md ARCHITECTURE.md CONTRIBUTING.md CLAUDE.md VERSION
|
|
```
|
|
|
|
If CHANGELOG.md and VERSION were NOT modified on this branch and the diff includes
|
|
new features (new files, new commands, new skills): **WARNING — /document-release
|
|
likely not run. CHANGELOG and VERSION not updated despite new features.**
|
|
|
|
If only docs changed (no code): skip this check.
|
|
|
|
### 3.5e: Readiness report and confirmation
|
|
|
|
Tell the user: "Here's the full readiness report. This is everything I checked before merging."
|
|
|
|
Build the full readiness report:
|
|
|
|
```
|
|
╔══════════════════════════════════════════════════════════╗
|
|
║ PRE-MERGE READINESS REPORT ║
|
|
╠══════════════════════════════════════════════════════════╣
|
|
║ ║
|
|
║ PR: #NNN — title ║
|
|
║ Branch: feature → main ║
|
|
║ ║
|
|
║ REVIEWS ║
|
|
║ ├─ Eng Review: CURRENT / STALE (N commits) / — ║
|
|
║ ├─ CEO Review: CURRENT / — (optional) ║
|
|
║ ├─ Design Review: CURRENT / — (optional) ║
|
|
║ └─ Codex Review: CURRENT / — (optional) ║
|
|
║ ║
|
|
║ TESTS ║
|
|
║ ├─ Free tests: PASS / FAIL (blocker) ║
|
|
║ ├─ E2E tests: 52/52 pass (25 min ago) / NOT RUN ║
|
|
║ └─ LLM evals: PASS / NOT RUN ║
|
|
║ ║
|
|
║ DOCUMENTATION ║
|
|
║ ├─ CHANGELOG: Updated / NOT UPDATED (warning) ║
|
|
║ ├─ VERSION: 0.9.8.0 / NOT BUMPED (warning) ║
|
|
║ └─ Doc release: Run / NOT RUN (warning) ║
|
|
║ ║
|
|
║ PR BODY ║
|
|
║ └─ Accuracy: Current / STALE (warning) ║
|
|
║ ║
|
|
║ WARNINGS: N | BLOCKERS: N ║
|
|
╚══════════════════════════════════════════════════════════╝
|
|
```
|
|
|
|
If there are BLOCKERS (failing free tests): list them and recommend B.
|
|
If there are WARNINGS but no blockers: list each warning and recommend A if
|
|
warnings are minor, or B if warnings are significant.
|
|
If everything is green: recommend A.
|
|
|
|
Use AskUserQuestion:
|
|
|
|
- **Re-ground:** "Ready to merge PR #NNN — '{title}' into {base}. Here's what I found."
|
|
Show the report above.
|
|
- If everything is green: "All checks passed. This PR is ready to merge."
|
|
- If there are warnings: List each one in plain English. E.g., "The engineering review
|
|
was done 6 commits ago — the code has changed since then" not "STALE (6 commits)."
|
|
- If there are blockers: "I found issues that need to be fixed before merging: {list}"
|
|
- **RECOMMENDATION:** Choose A if green. Choose B if there are significant warnings.
|
|
Choose C only if the user understands the risks.
|
|
- A) Merge it — everything looks good (Completeness: 10/10)
|
|
- B) Hold off — I want to fix the warnings first (Completeness: 10/10)
|
|
- C) Merge anyway — I understand the warnings and want to proceed (Completeness: 3/10)
|
|
|
|
If the user chooses B: **STOP.** Give specific next steps:
|
|
- If reviews are stale: "Run `/review` or `/autoplan` to review the current code, then `/land-and-deploy` again."
|
|
- If E2E not run: "Run your E2E tests to make sure nothing is broken, then come back."
|
|
- If docs not updated: "Run `/document-release` to update CHANGELOG and docs."
|
|
- If PR body stale: "The PR description doesn't match what's actually in the diff — update it on GitHub."
|
|
|
|
If the user chooses A or C: Tell the user "Merging now." Continue to Step 4.
|
|
|
|
---
|
|
|
|
## Step 4: Merge the PR
|
|
|
|
Record the start timestamp for timing data. Also record which merge path is taken
|
|
(auto-merge vs direct) for the deploy report.
|
|
|
|
Try auto-merge first (respects repo merge settings and merge queues):
|
|
|
|
```bash
|
|
gh pr merge --squash --auto --delete-branch
|
|
```
|
|
|
|
If `--auto` succeeds: record `MERGE_PATH=auto`. This means the repo has auto-merge enabled
|
|
and may use merge queues.
|
|
|
|
`--auto` fails for two unrelated reasons. Both fall through to the direct merge below, so
|
|
the flow is unaffected — but do not report the second one as "auto-merge is disabled":
|
|
|
|
1. **Auto-merge is disabled for the repo** — `Auto-merge is not allowed for this repository`.
|
|
2. **The PR is not waiting on anything.** `--auto` only *queues* a merge behind pending
|
|
required checks. When every required check has already settled — or the repo declares
|
|
no required status checks at all — GitHub treats the PR as immediately mergeable and
|
|
rejects the mutation:
|
|
`Pull request is in clean status` (everything green) or
|
|
`Pull request is in unstable status` (something red, but nothing required).
|
|
A repo with zero required status checks therefore takes the direct path 100% of the
|
|
time no matter how auto-merge is configured, and so does any repo whose CI finishes
|
|
before this step runs.
|
|
|
|
```bash
|
|
gh pr merge --squash --delete-branch
|
|
```
|
|
|
|
If direct merge succeeds: record `MERGE_PATH=direct`. Tell the user: "PR merged successfully. The branch has been cleaned up."
|
|
|
|
If the merge fails with a permission error: **STOP.** "I don't have permission to merge this PR. You'll need a maintainer to merge it, or check your repo's branch protection rules."
|
|
|
|
### 4a-postfail: Post-failure PR-state check
|
|
|
|
**Universal invariant:** after ANY non-zero exit from `gh pr merge`, query authoritative PR state before retrying or stopping. Do NOT retry `gh pr merge`. Related: cli/cli#3442, cli/cli#13380.
|
|
|
|
```bash
|
|
gh pr view --json state,mergeCommit,mergedAt,mergedBy
|
|
```
|
|
|
|
**If `state == "MERGED"`:**
|
|
|
|
The server-side merge succeeded (possibly completed before the local cleanup phase failed, or a concurrent merge landed). Tell the user: "PR is merged on GitHub." (Do NOT say "the merge succeeded" — this handles the concurrent-merge case.)
|
|
|
|
Capture merge SHA:
|
|
```bash
|
|
gh pr view --json mergeCommit -q .mergeCommit.oid
|
|
```
|
|
|
|
Squash/rebase merge readback guard:
|
|
- Do **not** prove success by requiring the PR head SHA to be an ancestor of the base branch. GitHub squash and rebase merges deliberately create a new commit, so `git merge-base --is-ancestor <head_sha> origin/<base>` can fail even when the PR is merged.
|
|
- Once GitHub reports `state == "MERGED"` with a non-null `mergeCommit.oid`, treat that as authoritative. Record the merge SHA and continue.
|
|
- If local cleanup or readback is needed, fetch the base branch and compare/sync against the merge commit, not the old PR branch commit:
|
|
```bash
|
|
BASE=$(gh pr view --json baseRefName -q .baseRefName)
|
|
MERGE_SHA=$(gh pr view --json mergeCommit -q .mergeCommit.oid)
|
|
git fetch origin "$BASE"
|
|
git diff --quiet "$MERGE_SHA" origin/"$BASE" || git log --oneline --decorate -1 "$MERGE_SHA" origin/"$BASE"
|
|
```
|
|
- If the worktree is clean and only needs to stop looking diverged after a squash merge, prefer a named local branch at the merge commit, for example `git switch -c "codex/post-merge-pr-$PR_NUMBER" "$MERGE_SHA"`. Avoid detached HEAD in Codex Desktop worktrees because git action workers often expect `git symbolic-ref --short HEAD` to return a branch. Do not force-push or reset a user's branch unless they explicitly ask.
|
|
|
|
Worktree cleanup — non-destructive, candidate-based:
|
|
```bash
|
|
git worktree list --porcelain
|
|
```
|
|
Identify candidates: a worktree is stale if (a) it is checked out on the base branch, AND (b) it is not the user's current main working tree, AND (c) `git status --porcelain` inside it is empty (no uncommitted work).
|
|
|
|
- For each clean candidate: OFFER to remove it. Say: "There's a stale worktree at `<path>` checked out on `<branch>` with no uncommitted work. Remove it?" Remove only if user confirms (`git worktree remove <path> && git worktree prune`).
|
|
- If any candidate has uncommitted work: list the files, tell the user, and STOP worktree cleanup without removing anything.
|
|
- Do NOT use `--force`. Do NOT remove the user's primary working tree.
|
|
|
|
Record `MERGE_PATH=direct`, then continue to §4a (CI auto-deploy detection).
|
|
|
|
**If `state == "OPEN"`:**
|
|
|
|
Check whether auto-merge is enabled:
|
|
```bash
|
|
gh pr view --json autoMergeRequest -q .autoMergeRequest
|
|
```
|
|
|
|
- If non-null: auto-merge is enabled or merge queue is in use. The open state is expected — proceed to §4a's merge-queue wait path.
|
|
- If null: genuine failure. Surface both errors — the `gh pr merge` stderr AND the current PR open state — then **STOP**.
|
|
|
|
**If `state == "CLOSED"`:** PR was closed without merging. **STOP.**
|
|
|
|
**Hard rule: never call `gh pr merge` a second time** after a non-zero exit. Server state is authoritative.
|
|
|
|
### 4a: Merge queue detection and messaging
|
|
|
|
If `MERGE_PATH=auto` and the PR state does not immediately become `MERGED`, the PR is
|
|
in a **merge queue**. Tell the user:
|
|
|
|
"Your repo uses a merge queue — that means GitHub will run CI one more time on the final merge commit before it actually merges. This is a good thing (it catches last-minute conflicts), but it means we wait. I'll keep checking until it goes through."
|
|
|
|
Poll for the PR to actually merge:
|
|
|
|
```bash
|
|
gh pr view --json state -q .state
|
|
```
|
|
|
|
Poll every 30 seconds, up to 30 minutes. Show a progress message every 2 minutes:
|
|
"Still in the merge queue... ({X}m so far)"
|
|
|
|
If the PR state changes to `MERGED`: capture the merge commit SHA. Tell the user:
|
|
"Merge queue finished — PR is merged. Took {duration}."
|
|
|
|
If the PR is removed from the queue (state goes back to `OPEN`): **STOP.** "The PR was removed from the merge queue — this usually means a CI check failed on the merge commit, or another PR in the queue caused a conflict. Check the GitHub merge queue page to see what happened."
|
|
If timeout (30 min): **STOP.** "The merge queue has been processing for 30 minutes. Something might be stuck — check the GitHub Actions tab and the merge queue page."
|
|
|
|
### 4b: CI auto-deploy detection
|
|
|
|
After the PR is merged, check if a deploy workflow was triggered by the merge:
|
|
|
|
```bash
|
|
gh run list --branch <base> --limit 5 --json name,status,workflowName,headSha
|
|
```
|
|
|
|
Look for runs matching the merge commit SHA. If a deploy workflow is found:
|
|
- Tell the user: "PR merged. I can see a deploy workflow ('{workflow-name}') kicked off automatically. I'll monitor it and let you know when it's done."
|
|
|
|
If no deploy workflow is found after merge:
|
|
- Tell the user: "PR merged. I don't see a deploy workflow — your project might deploy a different way, or it might be a library/CLI that doesn't have a deploy step. I'll figure out the right verification in the next step."
|
|
|
|
If `MERGE_PATH=auto` and the repo uses merge queues AND a deploy workflow exists:
|
|
- Tell the user: "PR made it through the merge queue and the deploy workflow is running. Monitoring it now."
|
|
|
|
Record merge timestamp, duration, and merge path for the deploy report.
|
|
|
|
---
|
|
|
|
## Step 5: Deploy strategy detection
|
|
|
|
Determine what kind of project this is and how to verify the deploy.
|
|
|
|
First, run the deploy configuration bootstrap to detect or read persisted deploy settings:
|
|
|
|
{{DEPLOY_BOOTSTRAP}}
|
|
|
|
Then run `gstack-diff-scope` to classify the changes:
|
|
|
|
```bash
|
|
eval $(~/.claude/skills/gstack/bin/gstack-diff-scope $(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main) 2>/dev/null)
|
|
echo "FRONTEND=$SCOPE_FRONTEND BACKEND=$SCOPE_BACKEND DOCS=$SCOPE_DOCS CONFIG=$SCOPE_CONFIG"
|
|
```
|
|
|
|
**Decision tree (evaluate in order):**
|
|
|
|
1. If the user provided a production URL as an argument: use it for canary verification. Also check for deploy workflows.
|
|
|
|
2. Check for GitHub Actions deploy workflows:
|
|
```bash
|
|
gh run list --branch <base> --limit 5 --json name,status,conclusion,headSha,workflowName
|
|
```
|
|
Look for workflow names containing "deploy", "release", "production", or "cd". If found: poll the deploy workflow in Step 6, then run canary.
|
|
|
|
3. If SCOPE_DOCS is the only scope that's true (no frontend, no backend, no config): skip verification entirely. Tell the user: "This was a docs-only change — nothing to deploy or verify. You're all set." Go to Step 9.
|
|
|
|
4. If no deploy workflows detected and no URL provided: use AskUserQuestion once:
|
|
- **Re-ground:** "PR is merged, but I don't see a deploy workflow or a production URL for this project. If this is a web app, I can verify the deploy if you give me the URL. If it's a library or CLI tool, there's nothing to verify — we're done."
|
|
- **RECOMMENDATION:** Choose B if this is a library/CLI tool. Choose A if this is a web app.
|
|
- A) Here's the production URL: {let them type it}
|
|
- B) No deploy needed — this isn't a web app
|
|
|
|
### 5a: Staging-first option
|
|
|
|
If staging was detected in Step 1.5c (or from CLAUDE.md deploy config), and the changes
|
|
include code (not docs-only), offer the staging-first option:
|
|
|
|
Use AskUserQuestion:
|
|
- **Re-ground:** "I found a staging environment at {staging URL or workflow}. Since this deploy includes code changes, I can verify everything works on staging first — before it hits production. This is the safest path: if something breaks on staging, production is untouched."
|
|
- **RECOMMENDATION:** Choose A for maximum safety. Choose B if you're confident.
|
|
- A) Deploy to staging first, verify it works, then go to production (Completeness: 10/10)
|
|
- B) Skip staging — go straight to production (Completeness: 7/10)
|
|
- C) Deploy to staging only — I'll check production later (Completeness: 8/10)
|
|
|
|
**If A (staging first):** Tell the user: "Deploying to staging first. I'll run the same health checks I'd run on production — if staging looks good, I'll move on to production automatically."
|
|
|
|
Run Steps 6-7 against the staging target first. Use the staging
|
|
URL or staging workflow for deploy verification and canary checks. After staging passes,
|
|
tell the user: "Staging is healthy — your changes are working. Now deploying to production." Then run
|
|
Steps 6-7 again against the production target.
|
|
|
|
**If B (skip staging):** Tell the user: "Skipping staging — going straight to production." Proceed with production deployment as normal.
|
|
|
|
**If C (staging only):** Tell the user: "Deploying to staging only. I'll verify it works and stop there."
|
|
|
|
Run Steps 6-7 against the staging target. After verification,
|
|
print the deploy report (Step 9) with verdict "STAGING VERIFIED — production deploy pending."
|
|
Then tell the user: "Staging looks good. When you're ready for production, run `/land-and-deploy` again."
|
|
**STOP.** The user can re-run `/land-and-deploy` later for production.
|
|
|
|
**If no staging detected:** Skip this sub-step entirely. No question asked.
|
|
|
|
---
|
|
|
|
## Step 6: Wait for deploy (if applicable)
|
|
|
|
The deploy verification strategy depends on the platform detected in Step 5.
|
|
|
|
### Strategy A: GitHub Actions workflow
|
|
|
|
If a deploy workflow was detected, find the run triggered by the merge commit:
|
|
|
|
```bash
|
|
gh run list --branch <base> --limit 10 --json databaseId,headSha,status,conclusion,name,workflowName
|
|
```
|
|
|
|
Match by the merge commit SHA (captured in Step 4). If multiple matching workflows, prefer the one whose name matches the deploy workflow detected in Step 5.
|
|
|
|
Poll every 30 seconds:
|
|
```bash
|
|
gh run view <run-id> --json status,conclusion
|
|
```
|
|
|
|
### Strategy B: Platform CLI (Fly.io, Render, Heroku)
|
|
|
|
If a deploy status command was configured in CLAUDE.md (e.g., `fly status --app myapp`), use it instead of or in addition to GitHub Actions polling.
|
|
|
|
**Fly.io:** After merge, Fly deploys via GitHub Actions or `fly deploy`. Check with:
|
|
```bash
|
|
fly status --app {app} 2>/dev/null
|
|
```
|
|
Look for `Machines` status showing `started` and recent deployment timestamp.
|
|
|
|
**Render:** Render auto-deploys on push to the connected branch. Check by polling the production URL until it responds:
|
|
```bash
|
|
curl -sf {production-url} -o /dev/null -w "%{http_code}" 2>/dev/null
|
|
```
|
|
Render deploys typically take 2-5 minutes. Poll every 30 seconds.
|
|
|
|
**Heroku:** Check latest release:
|
|
```bash
|
|
heroku releases --app {app} -n 1 2>/dev/null
|
|
```
|
|
|
|
### Strategy C: Auto-deploy platforms (Vercel, Netlify)
|
|
|
|
Vercel and Netlify deploy automatically on merge. No explicit deploy trigger needed. Wait 60 seconds for the deploy to propagate, then proceed directly to canary verification in Step 7.
|
|
|
|
### Strategy D: Custom deploy hooks
|
|
|
|
If CLAUDE.md has a custom deploy status command in the "Custom deploy hooks" section, run that command and check its exit code.
|
|
|
|
### Common: Timing and failure handling
|
|
|
|
Record deploy start time. Show progress every 2 minutes: "Deploy is still running... ({X}m so far). This is normal for most platforms."
|
|
|
|
If deploy succeeds (`conclusion` is `success` or health check passes): Tell the user "Deploy finished successfully. Took {duration}. Now I'll verify the site is healthy." Record deploy duration, continue to Step 7.
|
|
|
|
If deploy fails (`conclusion` is `failure`): use AskUserQuestion:
|
|
- **Re-ground:** "The deploy workflow failed after the merge. The code is merged but may not be live yet. Here's what I can do:"
|
|
- **RECOMMENDATION:** Choose A to investigate before reverting.
|
|
- A) Let me look at the deploy logs to figure out what went wrong
|
|
- B) Revert the merge immediately — roll back to the previous version
|
|
- C) Continue to health checks anyway — the deploy failure might be a flaky step, and the site might actually be fine
|
|
|
|
If timeout (20 min): "The deploy has been running for 20 minutes, which is longer than most deploys take. The site might still be deploying, or something might be stuck." Ask whether to continue waiting or skip verification.
|
|
|
|
---
|
|
|
|
## Step 7: Canary verification (conditional depth)
|
|
|
|
Tell the user: "Deploy is done. Now I'm going to check the live site to make sure everything looks good — loading the page, checking for errors, and measuring performance."
|
|
|
|
Use the diff-scope classification from Step 5 to determine canary depth:
|
|
|
|
| Diff Scope | Canary Depth |
|
|
|------------|-------------|
|
|
| SCOPE_DOCS only | Already skipped in Step 5 |
|
|
| SCOPE_CONFIG only | Smoke: `$B goto` + verify 200 status |
|
|
| SCOPE_BACKEND only | Console errors + perf check |
|
|
| SCOPE_FRONTEND (any) | Full: console + perf + screenshot |
|
|
| Mixed scopes | Full canary |
|
|
|
|
**Full canary sequence:**
|
|
|
|
```bash
|
|
$B goto <url>
|
|
```
|
|
|
|
Check that the page loaded successfully (200, not an error page).
|
|
|
|
```bash
|
|
$B console --errors
|
|
```
|
|
|
|
Check for critical console errors: lines containing `Error`, `Uncaught`, `Failed to load`, `TypeError`, `ReferenceError`. Ignore warnings.
|
|
|
|
```bash
|
|
$B perf
|
|
```
|
|
|
|
Check that page load time is under 10 seconds.
|
|
|
|
```bash
|
|
$B text
|
|
```
|
|
|
|
Verify the page has content (not blank, not a generic error page).
|
|
|
|
```bash
|
|
$B snapshot -i -a -o ".gstack/deploy-reports/post-deploy.png"
|
|
```
|
|
|
|
Take an annotated screenshot as evidence.
|
|
|
|
**Health assessment:**
|
|
- Page loads successfully with 200 status → PASS
|
|
- No critical console errors → PASS
|
|
- Page has real content (not blank or error screen) → PASS
|
|
- Loads in under 10 seconds → PASS
|
|
|
|
If all pass: Tell the user "Site is healthy. Page loaded in {X}s, no console errors, content looks good. Screenshot saved to {path}." Mark as HEALTHY, continue to Step 9.
|
|
|
|
If any fail: show the evidence (screenshot path, console errors, perf numbers). Use AskUserQuestion:
|
|
- **Re-ground:** "I found some issues on the live site after the deploy. Here's what I see: {specific issues}. This might be temporary (caches clearing, CDN propagating) or it might be a real problem."
|
|
- **RECOMMENDATION:** Choose based on severity — B for critical (site down), A for minor (console errors).
|
|
- A) That's expected — the site is still warming up. Mark it as healthy.
|
|
- B) That's broken — revert the merge and roll back to the previous version
|
|
- C) Let me investigate more — open the site and look at logs before deciding
|
|
|
|
---
|
|
|
|
## Step 8: Revert (if needed)
|
|
|
|
If the user chose to revert at any point:
|
|
|
|
Tell the user: "Reverting the merge now. This will create a new commit that undoes all the changes from this PR. The previous version of your site will be restored once the revert deploys."
|
|
|
|
```bash
|
|
git fetch origin <base>
|
|
git checkout <base>
|
|
git revert <merge-commit-sha> --no-edit
|
|
git push origin <base>
|
|
```
|
|
|
|
If the revert has conflicts: "The revert has merge conflicts — this can happen if other changes landed on {base} after your merge. You'll need to resolve the conflicts manually. The merge commit SHA is `<sha>` — run `git revert <sha>` to try again."
|
|
|
|
If the base branch has push protections: "This repo has branch protections, so I can't push the revert directly. I'll create a revert PR instead — merge it to roll back."
|
|
Then create a revert PR: `gh pr create --title 'revert: <original PR title>'`
|
|
|
|
After a successful revert: Tell the user "Revert pushed to {base}. The deploy should roll back automatically once CI passes. Keep an eye on the site to confirm." Note the revert commit SHA and continue to Step 9 with status REVERTED.
|
|
|
|
---
|
|
|
|
## Step 9: Deploy report
|
|
|
|
Create the deploy report directory:
|
|
|
|
```bash
|
|
mkdir -p .gstack/deploy-reports
|
|
```
|
|
|
|
Produce and display the ASCII summary:
|
|
|
|
```
|
|
LAND & DEPLOY REPORT
|
|
═════════════════════
|
|
PR: #<number> — <title>
|
|
Branch: <head-branch> → <base-branch>
|
|
Merged: <timestamp> (<merge method>)
|
|
Merge SHA: <sha>
|
|
Merge path: <auto-merge / direct / merge queue>
|
|
First run: <yes (dry-run validated) / no (previously confirmed)>
|
|
|
|
Timing:
|
|
Dry-run: <duration or "skipped (confirmed)">
|
|
CI wait: <duration>
|
|
Queue: <duration or "direct merge">
|
|
Deploy: <duration or "no workflow detected">
|
|
Staging: <duration or "skipped">
|
|
Canary: <duration or "skipped">
|
|
Total: <end-to-end duration>
|
|
|
|
Reviews:
|
|
Eng review: <CURRENT / STALE / NOT RUN>
|
|
Inline fix: <yes (N fixes) / no / skipped>
|
|
|
|
CI: <PASSED / SKIPPED>
|
|
Deploy: <PASSED / FAILED / NO WORKFLOW / CI AUTO-DEPLOY>
|
|
Staging: <VERIFIED / SKIPPED / N/A>
|
|
Verification: <HEALTHY / DEGRADED / SKIPPED / REVERTED>
|
|
Scope: <FRONTEND / BACKEND / CONFIG / DOCS / MIXED>
|
|
Console: <N errors or "clean">
|
|
Load time: <Xs>
|
|
Screenshot: <path or "none">
|
|
|
|
VERDICT: <DEPLOYED AND VERIFIED / DEPLOYED (UNVERIFIED) / STAGING VERIFIED / REVERTED>
|
|
```
|
|
|
|
Save report to `.gstack/deploy-reports/{date}-pr{number}-deploy.md`.
|
|
|
|
Log to the review dashboard:
|
|
|
|
```bash
|
|
{{SLUG_EVAL}}
|
|
mkdir -p ~/.gstack/projects/$SLUG
|
|
```
|
|
|
|
Write a JSONL entry with timing data:
|
|
```json
|
|
{"skill":"land-and-deploy","timestamp":"<ISO>","status":"<SUCCESS/REVERTED>","pr":<number>,"merge_sha":"<sha>","merge_path":"<auto/direct/queue>","first_run":<true/false>,"deploy_status":"<HEALTHY/DEGRADED/SKIPPED>","staging_status":"<VERIFIED/SKIPPED>","review_status":"<CURRENT/STALE/NOT_RUN/INLINE_FIX>","ci_wait_s":<N>,"queue_s":<N>,"deploy_s":<N>,"staging_s":<N>,"canary_s":<N>,"total_s":<N>}
|
|
```
|
|
|
|
---
|
|
|
|
## Step 10: Suggest follow-ups
|
|
|
|
After the deploy report:
|
|
|
|
If verdict is DEPLOYED AND VERIFIED: Tell the user "Your changes are live and verified. Nice ship."
|
|
|
|
If verdict is DEPLOYED (UNVERIFIED): Tell the user "Your changes are merged and should be deploying. I wasn't able to verify the site — check it manually when you get a chance."
|
|
|
|
If verdict is REVERTED: Tell the user "The merge was reverted. Your changes are no longer on {base}. The PR branch is still available if you need to fix and re-ship."
|
|
|
|
Then suggest relevant follow-ups:
|
|
- If a production URL was verified: "Want extended monitoring? Run `/canary <url>` to watch the site for the next 10 minutes."
|
|
- If performance data was collected: "Want a deeper performance analysis? Run `/benchmark <url>`."
|
|
- "Need to update docs? Run `/document-release` to sync README, CHANGELOG, and other docs with what you just shipped."
|
|
|
|
---
|
|
|
|
## Important Rules
|
|
|
|
- **Never force push.** Use `gh pr merge` which is safe.
|
|
- **Never skip CI.** If checks are failing, stop and explain why.
|
|
- **Narrate the journey.** The user should always know: what just happened, what's happening now, and what's about to happen next. No silent gaps between steps.
|
|
- **Auto-detect everything.** PR number, merge method, deploy strategy, project type, merge queues, staging environments. Only ask when information genuinely can't be inferred.
|
|
- **Poll with backoff.** Don't hammer GitHub API. 30-second intervals for CI/deploy, with reasonable timeouts.
|
|
- **Revert is always an option.** At every failure point, offer revert as an escape hatch. Explain what reverting does in plain English.
|
|
- **Single-pass verification, not continuous monitoring.** `/land-and-deploy` checks once. `/canary` does the extended monitoring loop.
|
|
- **Clean up.** Delete the feature branch after merge (via `--delete-branch`).
|
|
- **First run = teacher mode.** Walk the user through everything. Explain what each check does and why it matters. Show them their infrastructure. Let them confirm before proceeding. Build trust through transparency.
|
|
- **Subsequent runs = efficient mode.** Brief status updates, no re-explanations. The user already trusts the tool — just do the job and report results.
|
|
- **The goal is: first-timers think "wow, this is thorough — I trust it." Repeat users think "that was fast — it just works."**
|