mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-16 18:05:31 +02:00
* feat: add a restricted and supervised Claude Code runner Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment. * feat: route outside reviews by harness and migrate wrapper installs Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage. * test: recognize CEO mode labels without terminal spacing The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions. * test: isolate plan-count fixtures before starting review workflows Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations. * test: stabilize review fixtures and Claude eval startup Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: classify collapsed review modes and isolate seeded findings Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control. Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: isolate browser daemon state across free shards Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: stabilize native review counting and interactive navigation Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: prepare v1.82.0.0 release Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: eliminate browser and process-cleanup test flakes Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing reused live sockets. Add an isolated GC/listener regression that fails on Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime. Check renderer cleanup against the render's own staging directory so concurrent renders cannot invalidate the assertion. Make the no-pgrep process-tree walk tolerate disappearing /proc entries, and synchronize its test fixture through child readiness and pipe EOF instead of sleeps. Validation: 9,157 passed, 31 skipped, zero failures across 556 files with retries disabled. Build, all-host generation freshness, and skill checks passed. All three races have failing-before/passing-after regressions. * fix: count completed native review questions in evals * fix: drive review navigation from confirmed native choices * fix: require complete section-loading eval reports * test: isolate telemetry HTTP transport from local assertions * fix: keep review input on the active native question * test: let tunnel revocation daemon choose an available port * test: allocate available ports for pairing and watchdog fixtures * fix: stabilize planning eval navigation and phase reporting * test: isolate installed runtime paths in planning evals * test: stabilize review evidence and concurrent refresh fixtures * fix: resolve design findings before editing the plan * fix: honor and persist disabled outside plan reviews * fix: preserve planning decisions and terminal evidence Load installed host reviews at autoplan phase entry and wait for completed reviewers and saved artifacts. Reuse approved remedies while preserving individual finding decisions. Drive interactive evals from the current terminal viewport, bind native questions across scrolling, and require complete native report evidence. Cover captured stale menus, permission lifecycles, setup classification, and disabled-review tool availability with deterministic regressions. Advance release metadata and the upgrade migration to the unclaimed 1.83.0.0 slot. * fix: drive native review questions and preserve current plans Use the native single-choice keyboard protocol and current terminal viewport, with per-question navigation inside packets and completed-call coverage. Keep permissions, multi-select menus, and Submit controls distinct. Send Autoplan reviewers the amended implementation plan, keep its review record separate, and supply retained application contracts in the chain fixture. Clarify individual DevEx decisions and complete CEO fix options; use one active plan destination for the section-loading report. * fix: preserve complete plan-review decisions * fix: recognize native plan dialogs and reviewer controls * fix: preserve review decisions and phase completion * fix: recognize completed reviews without losing findings * fix: preserve review continuity and native eval completion * test: fix native review completion and eval retry isolation * test: handle native review menus and complete eval fixtures * test: fix native review setup, completion, and isolation failures * test: limit native skill discovery to runtime assets * fix: bind Autoplan reviews to full ordered phase inputs * test: fix planning eval routing, counting, and timeout handling * chore: advance queued release to v1.84.0.0 * fix: preserve complete review inputs and planning decisions * fix: reconcile review approvals and preserve phase obligations * fix: preserve review obligations and unblock eval permissions Carry recorded Autoplan requirements into blind phase inputs, require Eng review approvals before exit, and exercise combined asynchronous flows in CEO reviews. Correct native finding and handoff classification and unblock repeated report edits using scoped request identities. * fix: retain plan requirements and complete native review dialogs * fix: complete native review prompts and retain plan references * fix: preserve review inputs and classify native eval evidence * fix: check competing completion orders in CEO reviews * fix: recognize review decisions and require phase methodology Require the current phase methodology before Autoplan snapshots. Correct substantive decision, closed handoff, and cache-finding classification, and honor the recommended implementation approach in native review dialogs. Add captured-transcript regressions without changing review thresholds, provider models, retries, or deadlines. * test: bind native review decisions and close completed handoffs * fix: complete review dialogs and verify methodology delivery * fix: preserve review evidence and unblock native eval prompts * fix: handle native review question completions * fix: recognize native review narration and controls * fix: count native review decisions and isolate eval fixtures * test: verify seeded review coverage and current artifact permissions * test: isolate model and brain-aware skill renders * fix: repair native workflow evaluation and clarify review steps * fix: stabilize workflow eval evidence and review guidance * test: repair native workflow observation and fixture isolation * fix: recognize completed workflow evidence and owned skill reads * test: repair seeded workflow delivery and completion evidence * test: recognize current review evidence across native forms * test: handle native review variants and permission redraws * fix: honor review preferences and recognize native eval evidence * test: recognize completed review decisions and queued permissions * test: match current review contracts and partial-line edits * test: recognize completed workflow evidence and bounded human waits * fix: preserve review entry gates and native eval interactions * fix: recognize native workflow evidence and preserve review gates * test: recognize current review evidence and preconfigure workflow fixtures * test: recognize completed review findings and scoped artifact permissions * fix: stabilize native workflow review and permission evidence * fix: recognize current review evidence and scoped edit confirmations Clarify Design and engineering review entry instructions and Design scoring. Recognize required legacy coverage and public Autoplan completion recaps. Bind the pending Edit confirmation to its exact file, ordered digest, and one-request approval when a preceding command display remains visible. Keep reviews within their existing size limits and preserve scope gates when extracting workflow fixtures from either supported preamble header. Keep failure outcomes, review thresholds, provider choices, and eval budgets. * fix: recover review workflow progress and eval evidence * fix: recognize valid review evidence and scope selection * test: fix review evidence parsing and repeated artifact prompts * test: recognize valid review decisions and pending native cards * fix(plan-eng-review): keep final navigation consistent with approved tasks * test: recognize valid review evidence and bind legacy diff requests * fix: stabilize review eval evidence and harness repair guidance * docs: update project documentation for v1.85.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: fix Windows CI fixtures and credential scan Rebase captured JSON values and filesystem evidence using the appropriate path convention. Compile native fake CLIs on Windows and synchronize pipe holder readiness, with cleanup retained when assertions fail. Assemble synthetic credential fixtures at runtime so the added-line scan keeps enforcing the same gate without flagging its own rejection controls. Discover generated skills directly for the empty-find regression check, avoiding a recursive scan through saved evaluation artifacts and dependencies. * fix: preserve source renders on Windows Compare canonical generator paths using native separators so an output sidecar pointing at the source cannot overwrite its skill or metadata. Keep the regression fixture isolated from the real checkout and expose freshness diagnostics before asserting subprocess status. Detach Windows drain-test pipe holders from the fake provider's automatic child cleanup while preserving the enclosing runner job and its assertions. * fix: clarify outside review fallback and CEO decisions Render one applicable own-harness fallback path and retain native review, disabled policy, and missing-coverage semantics. Align report field names and mode labels, and make the existing per-cut scope approval explicit. Regenerate skill outputs and keep the workflow judge's model, thresholds, and retry policy unchanged. * chore: move release to free version slot (v1.86.0.0) PR #2852 now claims v1.85.0.0. Align the release metadata and rename migration so upgrades from that version still receive it. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: include engineering review prerequisites and restore branch context * fix: recognize coverage diagrams and clarify design review instructions * fix: preserve file identities and join Windows test processes --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
699 lines
48 KiB
Markdown
699 lines
48 KiB
Markdown
<!-- AUTO-GENERATED from review-sections.md.tmpl — do not edit directly -->
|
||
<!-- Regenerate: bun run gen:skill-docs -->
|
||
## Review Sections (7 passes, after scope is agreed)
|
||
|
||
**Anti-skip rule:** Never condense, abbreviate, or skip any review pass (1-7) regardless of plan type (strategy, spec, code, infra). Every pass in this skill exists for a reason. "This is a strategy doc so design passes don't apply" is always wrong — design gaps are where implementation breaks down. If a pass genuinely has zero findings, say "No issues found" and move on — but you must evaluate it.
|
||
|
||
**Context:** This section continues `plan-design-review/SKILL.md`. If its setup
|
||
is no longer in context, Read `~/.claude/skills/gstack/plan-design-review/SKILL.md`
|
||
for the System Audit, Design Philosophy, Step 0, Step 0.5 mockup setup (`$D`),
|
||
and Section self-check. Use their existing results; do not restart the review.
|
||
|
||
**Anti-shortcut clause:** Complete one decision cycle per unresolved finding:
|
||
explain the gap, recommend options, obtain its individual decision, then apply
|
||
the selected fix. Scope, focus, setup, and next-step choices approve no remedies.
|
||
Never use the final next-step AskUserQuestion to satisfy the issue-approval loop.
|
||
With no unresolved findings, no issue question is required.
|
||
|
||
**Carry decisions across passes.** An issue is one unresolved design requirement
|
||
or tradeoff, even when it appears in several plan locations. Before each pass,
|
||
compare the plan, DESIGN.md, and the decisions already made:
|
||
|
||
| Situation | Required action |
|
||
|-----------|-----------------|
|
||
| The exact fix already has an individual user decision or a preamble-authorized per-issue auto-decision. | Reuse that decision. Apply it to all affected references and matching tokens; do not ask again. |
|
||
| An accepted requirement needs to be copied unchanged into a required artifact, such as the journey storyboard. | Create the artifact without a separate format question. This records the requirement; it approves no new remedy. |
|
||
| The plan violates DESIGN.md or has a gap, and no individual decision has approved its fix. | Ask about that issue and wait before fixing it, even if the input names the gap or DESIGN.md prescribes the exact token. Keep the proposed remedy pending meanwhile. |
|
||
| New evidence introduces a missing requirement, a conflict, or a new tradeoff. | Name the new issue, offer alternatives, and obtain its individual decision before changing the plan. |
|
||
|
||
Writing a report, mapping a token, creating a mockup, or listing a task does not
|
||
approve a remedy. If findings exist but only navigation was answered, the review
|
||
is still waiting for its first issue decision.
|
||
|
||
## Prior Learnings
|
||
|
||
Search for relevant learnings from previous sessions:
|
||
|
||
```bash
|
||
_CROSS_PROJ=$(~/.claude/skills/gstack/bin/gstack-config get cross_project_learnings 2>/dev/null || echo "unset")
|
||
echo "CROSS_PROJECT: $_CROSS_PROJ"
|
||
if [ "$_CROSS_PROJ" = "true" ]; then
|
||
~/.claude/skills/gstack/bin/gstack-learnings-search --limit 10 --cross-project 2>/dev/null || true
|
||
else
|
||
~/.claude/skills/gstack/bin/gstack-learnings-search --limit 10 2>/dev/null || true
|
||
fi
|
||
```
|
||
|
||
If `CROSS_PROJECT` is `unset` (first time): Use AskUserQuestion:
|
||
|
||
> gstack can search learnings from your other projects on this machine to find
|
||
> patterns that might apply here. This stays local (no data leaves your machine).
|
||
> Recommended for solo developers. Skip if you work on multiple client codebases
|
||
> where cross-contamination would be a concern.
|
||
|
||
Options:
|
||
- A) Enable cross-project learnings (recommended)
|
||
- B) Keep learnings project-scoped only
|
||
|
||
If A: run `~/.claude/skills/gstack/bin/gstack-config set cross_project_learnings true`
|
||
If B: run `~/.claude/skills/gstack/bin/gstack-config set cross_project_learnings false`
|
||
|
||
Then re-run the search with the appropriate flag.
|
||
|
||
If learnings are found, incorporate them into your analysis. When a review finding
|
||
matches a past learning, display:
|
||
|
||
**"Prior learning applied: [key] (confidence N/10, from [date])"**
|
||
|
||
This makes the compounding visible. The user should see that gstack is getting
|
||
smarter on their codebase over time.
|
||
|
||
**Pass protocol (1-6):** Record the initial 0-10 score. Every `FIX TO 10` below is a proposal: ask about each issue, wait for approval, then edit the plan and re-rate that pass with the reason for the score change. A declined fix remains documented and lowers the final score. Never edit first and ask afterward. Pass 7 is the unscored decision register, not a seventh rating.
|
||
|
||
### Pass 1: Information Architecture
|
||
Rate 0-10: Does the plan define what the user sees first, second, third?
|
||
FIX TO 10: Add information hierarchy to the plan. Include ASCII diagram of screen/page structure and navigation flow. Apply "constraint worship" — if you can only show 3 things, which 3?
|
||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY. If no issues, say so and move on. Do NOT proceed until user responds.
|
||
|
||
### Pass 2: Interaction State Coverage
|
||
Rate 0-10: Does the plan specify loading, empty, error, success, partial states?
|
||
FIX TO 10: Add interaction state table to the plan:
|
||
```
|
||
FEATURE | LOADING | EMPTY | ERROR | SUCCESS | PARTIAL
|
||
---------------------|---------|-------|-------|---------|--------
|
||
[each UI feature] | [spec] | [spec]| [spec]| [spec] | [spec]
|
||
```
|
||
For each state: describe what the user SEES, not backend behavior.
|
||
Empty states are features — specify warmth, primary action, context.
|
||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||
|
||
### Pass 3: User Journey & Emotional Arc
|
||
Rate 0-10: Does the plan consider the user's emotional experience?
|
||
FIX TO 10: Render the accepted journey as the required storyboard; do not ask whether to create it:
|
||
```
|
||
STEP | USER DOES | USER FEELS | PLAN SPECIFIES?
|
||
-----|------------------|-----------------|----------------
|
||
1 | Lands on page | [what emotion?] | [what supports it?]
|
||
...
|
||
```
|
||
Apply time-horizon design: 5-sec visceral, 5-min behavioral, 5-year reflective.
|
||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||
|
||
### Pass 4: AI Slop Risk
|
||
|
||
**Pass 4 evaluation:** Rate 0-10: Does the plan describe specific, intentional UI, or generic patterns? Record each hard-rejection hit and litmus YES/NO with evidence. An unresolved hard rejection caps this pass below 8 (not design-complete); it does not automatically set the score to 0. Litmus answers support findings, not a separate numeric score.
|
||
Use plan text and any available mockups as evidence for the rules below.
|
||
|
||
#### Design Hard Rules
|
||
|
||
**Classifier: name the mode before you judge a pixel.** The mode is what the visitor's win looks like on THIS surface, not what the product is. A dev tool's landing page is Persuade. A fashion house's docs are Read.
|
||
- **PERSUADE** (MARKETING/LANDING PAGE: hero-driven, brand-forward, pricing, campaigns) → they decide and act. Design IS the product. Apply Landing Page Rules.
|
||
- **OPERATE** (APP UI: dashboards, admin, settings, editors, tools) → they finish a task. Scanability and native expectations beat expression; the brand lives in the details. Apply App UI Rules.
|
||
- **READ** (docs, articles, guides, changelogs) → they understand something. Structure for comprehension, then make staying worth it. Apply Read Rules.
|
||
- **EXPERIENCE** (portfolios, galleries, showcases) → they are inside the work. The artifact owns the first viewport; the interface gets out of the way. Apply Experience Rules.
|
||
- **HYBRID** (marketing shell with app-like sections) → classify per section, not per page.
|
||
|
||
**Hard rejection criteria** (instant-fail patterns — flag if ANY apply):
|
||
1. Generic SaaS card grid as first impression
|
||
2. Beautiful image with weak brand
|
||
3. Strong headline with no clear action
|
||
4. Busy imagery behind text
|
||
5. Sections repeating same mood statement
|
||
6. Carousel with no narrative purpose
|
||
7. App UI made of stacked cards instead of layout
|
||
|
||
**Litmus checks** (answer YES/NO for each — used for cross-model consensus scoring):
|
||
1. Brand/product unmistakable in first screen?
|
||
2. One strong visual anchor present?
|
||
3. Page understandable by scanning headlines only?
|
||
4. Each section has one job?
|
||
5. Are cards actually necessary?
|
||
6. Does motion improve hierarchy or atmosphere?
|
||
7. Would design feel premium with all decorative shadows removed?
|
||
|
||
**Landing page rules** (apply when classifier = PERSUADE / MARKETING/LANDING):
|
||
- First viewport reads as one composition, not a dashboard
|
||
- Brand-first hierarchy: brand > headline > body > CTA
|
||
- Typography: expressive, purposeful — no default stacks (Inter, Roboto, Arial, system)
|
||
- No flat single-color backgrounds by default: texture from the brand or a real asset, never a halo, spotlight, stripe, or grid-paper gradient (the catalog names each)
|
||
- Hero: full-bleed, edge-to-edge, no inset/tiled/rounded variants
|
||
- Hero budget: brand, one headline, one supporting sentence, one CTA group, one image
|
||
- No cards in hero. Cards only when card IS the interaction
|
||
- One job per section: one purpose, one headline, one short supporting sentence
|
||
- Motion: one authored moment on the first viewport (an entrance or a scroll-linked reveal), ease-out from a visible default; hover states only where they carry information
|
||
- Color: define CSS variables, avoid purple-on-white defaults, one accent color default
|
||
- Copy: product language not design commentary. "If deleting 30% improves it, keep deleting"
|
||
- Beautiful defaults: composition-first, brand as loudest text, two text faces max (plus a mono for data and code), cardless by default, first viewport as one composition, not a document (poster in stance, not in type size: display stays under 6rem)
|
||
|
||
**App UI rules** (apply when classifier = OPERATE / APP UI):
|
||
- Calm surface hierarchy, strong typography, few colors
|
||
- Dense but readable, minimal chrome
|
||
- Organize: primary workspace, navigation, secondary context, one accent
|
||
- Avoid: dashboard-card mosaics, thick borders, decorative gradients, ornamental icons
|
||
- Copy: utility language — orientation, status, action. Not mood/brand/aspiration
|
||
- Cards only when card IS the interaction
|
||
- Section headings state what area is or what user can do ("Selected KPIs", "Plan status")
|
||
|
||
**Read rules** (apply when classifier = READ):
|
||
- Measure 65-75ch, one reading column, headings closer to what follows than to what precedes
|
||
- Wayfinding is a feature: where am I, what is next, where do I search
|
||
- A docs index is Read, not Persuade: no hero, no CTA theater
|
||
|
||
**Experience rules** (apply when classifier = EXPERIENCE):
|
||
- The work fills the first viewport; chrome earns every pixel
|
||
- One authored transition, not a scroll-jacked tour
|
||
- Never crop the artifact to fit a template
|
||
|
||
**Universal rules** (apply to ALL types):
|
||
- Define CSS variables for color system
|
||
- No default font stacks as the display voice (Inter, Roboto, Arial, system); body/UI use on an Operate or Read surface follows the role-scoped list (DM Sans, Instrument Sans, IBM Plex Sans pass when the proposal says so)
|
||
- One job per section
|
||
- "If deleting 30% of the copy improves it, keep deleting"
|
||
- Cards earn their existence — no decorative card grids
|
||
- NEVER use small, low-contrast type (body text < 16px or contrast ratio < 4.5:1 on body text)
|
||
- NEVER put labels inside form fields as the only label (placeholder-as-label pattern — labels must be visible when the field has content)
|
||
- ALWAYS preserve visited vs unvisited link distinction (visited links must have a different color)
|
||
- NEVER float headings between paragraphs (heading must be visually closer to the section it introduces than to the preceding section)
|
||
|
||
**Reflexes no detector catches** (check by hand, every time):
|
||
- **Browser surfaces carry the design.** Selection color, caret, scrollbars, focus rings, underline offset, tabular numerals all ship with browser defaults that belong to no design system. Theme them from the palette. Cheapest tell that a page was designed rather than assembled, and the one models skip most.
|
||
- **One authored motion moment.** Not the same entrance on every section, not a hover effect on everything. Exponential ease-out from an already-visible default. Content never hides behind animation timing.
|
||
- **Depth has an offset.** Shadows are offset plus soft blur. A zero-offset colored halo is decoration, not depth.
|
||
- **Secondary text on a colored surface is tinted from that hue.** Never gray.
|
||
- **More space above a heading than below it.** Read the computed values.
|
||
- **Light or dark comes from the use scene.** Who, where, under what light: one sentence. Never from the category.
|
||
|
||
**Calibration: the three looks.** AI-built interfaces land in one of three looks no matter what the product is: (1) cream ground, high-contrast serif display, terracotta or signal-red accent; (2) near-black, one neon accent, glowing edges; (3) broadsheet hairlines, italic display serif, tiny tracked mono labels. Each is fine when the brief asks for it. If the brief left the look open and you landed in one anyway, you stopped looking. The test: could someone guess your look from the category alone? From "the category, but avoiding the obvious"? Either way, start over. "It's about books, so cream and a serif" fails this test. Book cloth and jackets come in every saturated color there is.
|
||
|
||
**AI Slop blacklist** (the 11 patterns that scream "AI-generated"):
|
||
1. Purple/violet/indigo gradient backgrounds or blue-to-purple color schemes
|
||
2. **The 3-column feature grid:** icon-in-colored-circle + bold title + 2-line description, repeated 3x symmetrically. THE most recognizable AI layout.
|
||
3. Icons in colored circles as section decoration (SaaS starter template look)
|
||
4. Centered everything (`text-align: center` on all headings, descriptions, cards)
|
||
5. Uniform bubbly border-radius on every element (same large radius on everything)
|
||
6. Decorative blobs, floating circles, wavy SVG dividers (if a section feels empty, it needs better content, not decoration)
|
||
7. Emoji as design elements (rockets in headings, emoji as bullet points)
|
||
8. Colored left-border on cards (`border-left: 3px solid <accent>`)
|
||
9. Generic hero copy ("Welcome to [X]", "Unlock the power of...", "Your all-in-one solution for...")
|
||
10. Cookie-cutter section rhythm (hero → 3 features → testimonials → pricing → CTA, every section same height)
|
||
11. system-ui or `-apple-system` as the PRIMARY display/body font — the "I gave up on typography" signal. Pick a real typeface.
|
||
|
||
Detector rule ids for the rest of the catalog (a `[rule-id]` in a finding is one of these): border-accent-on-rounded: Border accent on a rounded card; overused-font: Overused display font; flat-type-hierarchy: Flat type hierarchy; gradient-text: Gradient text; cream-palette: Cream default palette; nested-cards: Nested cards; monotonous-spacing: Monotonous spacing; bounce-easing: Bounce easing; pulsing-dot: Pulsing status dot; blinking-cursor: Blinking cursor effect; shape-assembled-illustration: Shape-assembled illustration; dark-glow: Dark-mode glow; radial-halo: Radial halo; radial-spotlight-glow: Radial spotlight glow; marquee: Logo marquee; icon-tile-stack: Icon tile above every heading; italic-serif-display: Italic serif display; hero-eyebrow-chip: Hero eyebrow chip; kicker-above-heading: Kicker above heading; numbered-section-labels: Numbered section labels; em-dash-overuse: Em-dash overuse; marketing-buzzword: Marketing buzzwords; aphoristic-cadence: Aphoristic cadence; oversized-h1: Oversized h1; extreme-negative-tracking: Extreme negative tracking; gpt-thin-border-wide-shadow: Thin border plus wide shadow; repeating-stripes-gradient: Repeating stripes gradient; codex-grid-background: Grid-paper background; theater-slop-phrase: Theater phrases; image-hover-transform: Image hover zoom.
|
||
Judgment tells with no detector rule: gradient cta button, stock-photo hero, cards as the default component, generic testimonial section, left-text right-image hero, generic cta labels, hero metric template, identical card grids, glassmorphism, hand-drawn svg illustration, modal by default, monospace as costume, content stand-ins, mode picked by category, unthemed browser surfaces, missing states.
|
||
|
||
Source: [OpenAI "Designing Delightful Frontends with GPT-5.4"](https://developers.openai.com/blog/designing-delightful-frontends-with-gpt-5-4) (Mar 2026) + gstack design methodology.
|
||
|
||
FIX TO 10: Rewrite vague UI descriptions with specific alternatives:
|
||
- "Cards with icons" → what differentiates these from every SaaS template?
|
||
- "Hero section" → what makes this hero feel like THIS product?
|
||
- "Clean, modern UI" → meaningless. Replace with actual design decisions.
|
||
- "Dashboard with widgets" → what makes this NOT every other dashboard?
|
||
If visual mockups were generated in Step 0.5, evaluate them against the AI slop blacklist above. Read each mockup image using the Read tool. Does the mockup fall into generic patterns (3-column grid, centered hero, stock-photo feel)? If so, flag it and offer to regenerate with more specific direction via `$D iterate --feedback "..."`.
|
||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||
|
||
### Pass 5: Design System Alignment
|
||
Rate 0-10: Does the plan align with DESIGN.md?
|
||
If DESIGN.md is absent, rate the plan's explicit token and component specifications. Missing specifications remain findings; do not skip the score or assume alignment.
|
||
FIX TO 10: If DESIGN.md exists, annotate with specific tokens/components; when it has YAML front matter (the open DESIGN.md format), cite tokens by path (`{colors.primary}`, `{rounded.md}`) so the plan and the file share one vocabulary. If no DESIGN.md, flag the gap and recommend `/design-consultation`.
|
||
Flag any new component — does it fit the existing vocabulary?
|
||
Before offering a token-alignment fix, check whether an earlier pass already approved that outcome. If so, apply the established tokens and update every stale gap/reference under that decision; changing the plan location or spelling out the same fix is not a new issue. Ask again only if new evidence exposes an unresolved requirement or tradeoff, and name it. An unapproved violation still needs its first individual decision.
|
||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||
|
||
### Pass 6: Responsive & Accessibility
|
||
Rate 0-10: Does the plan specify mobile/tablet, keyboard nav, screen readers?
|
||
FIX TO 10: Add responsive specs per viewport — not "stacked on mobile" but intentional layout changes. Add a11y: keyboard nav patterns, ARIA landmarks, touch target sizes (44px min), color contrast requirements.
|
||
**STOP.** AskUserQuestion once per issue. Do NOT batch. Recommend + WHY.
|
||
|
||
### Pass 7: Unresolved Design Decisions
|
||
Preserve accepted user-facing outcomes. Choosing implementation mechanics does not
|
||
reopen them; ask only if a concrete constraint exposes a new design requirement
|
||
or tradeoff. Surface the remaining ambiguities that will haunt implementation:
|
||
```
|
||
DECISION NEEDED | IF DEFERRED, WHAT HAPPENS
|
||
-----------------------------|---------------------------
|
||
What does empty state look like? | Engineer ships "No items found."
|
||
Mobile nav pattern? | Desktop nav hides behind hamburger
|
||
...
|
||
```
|
||
If visual mockups were generated in Step 0.5, reference them as evidence when surfacing unresolved decisions. A mockup makes decisions concrete — e.g., "Your approved mockup shows a sidebar nav, but the plan doesn't specify mobile behavior. What happens to this sidebar on 375px?"
|
||
Each decision = one AskUserQuestion with recommendation + WHY + alternatives. Edit the plan with each decision as it's made.
|
||
**STOP.** Wait for each answer before editing or advancing. Record unanswered decisions as unresolved.
|
||
|
||
### Post-Pass: Update Mockups (if generated)
|
||
|
||
After Pass 7: offer the mockup update below when applicable, resolve deferred TODO proposals, reconcile approvals, then synthesize tasks and the Completion Summary.
|
||
|
||
If mockups were generated in Step 0.5 and review passes changed significant design decisions (information architecture restructure, new states, layout changes), offer to regenerate (one-shot, not a loop):
|
||
|
||
AskUserQuestion: "The review passes changed [list major design changes]. Want me to regenerate mockups to reflect the updated plan? This ensures the visual reference matches what we're actually building."
|
||
|
||
If yes, use `$D iterate` with feedback summarizing the changes, or `$D variants` with an updated brief. Save to the same `$_DESIGN_DIR` directory.
|
||
|
||
## CRITICAL RULE — How to ask questions
|
||
Follow the AskUserQuestion format from the Preamble above. Additional rules for plan design reviews:
|
||
* **One issue = one AskUserQuestion call.** Never combine multiple issues into one question.
|
||
* Describe the design gap concretely — what's missing, what the user will experience if it's not specified.
|
||
* Present 2-3 options. For each: effort to specify now, risk if deferred.
|
||
* **Map to Design Principles above.** One sentence connecting your recommendation to a specific principle.
|
||
* Label with issue NUMBER + option LETTER (e.g., "3A", "3B").
|
||
* **Zero findings:** if a section has zero findings, state "No issues, moving on" and proceed. Otherwise, use AskUserQuestion for each gap — a gap with an "obvious fix" is still a gap and still needs user approval before any change lands in the plan.
|
||
* **NEVER use AskUserQuestion to ask which variant the user prefers.** Always create a comparison board first (`$D compare --serve`) and open it in the browser. The board has rating controls, comments, remix/regenerate buttons, and structured feedback output. Use AskUserQuestion ONLY to notify the user the board is open and wait for them to finish — not to present variants inline and ask "which do you prefer?" That is a degraded experience.
|
||
|
||
## Required Outputs
|
||
|
||
### "NOT in scope" section
|
||
Design decisions considered and explicitly deferred, with one-line rationale each.
|
||
|
||
### "What already exists" section
|
||
Existing DESIGN.md, UI patterns, and components that the plan should reuse.
|
||
|
||
### TODOS.md updates
|
||
Put implementation and verification of approved fixes in the plan tasks. Do not
|
||
make in-scope verification an optional follow-up. Reserve deferred TODO proposals
|
||
for unresolved/out-of-scope debt or a new scope decision or tradeoff. After the
|
||
passes, ask about each such TODO individually; never batch. Honor explicit user
|
||
deferrals. If none remain, say so.
|
||
|
||
For design debt: missing a11y, unresolved responsive behavior, deferred empty states. Each TODO gets:
|
||
* **What:** One-line description of the work.
|
||
* **Why:** The concrete problem it solves or value it unlocks.
|
||
* **Pros:** What you gain by doing this work.
|
||
* **Cons:** Cost, complexity, or risks of doing it.
|
||
* **Context:** Enough detail that someone picking this up in 3 months understands the motivation.
|
||
* **Depends on / blocked by:** Any prerequisites.
|
||
|
||
Then present options: **A)** Add to TODOS.md **B)** Skip — not valuable enough **C)** Build it now in this PR instead of deferring.
|
||
|
||
Before synthesizing tasks or the completion summary, perform the approval
|
||
reconciliation from the Section self-check in `~/.claude/skills/gstack/plan-design-review/SKILL.md` (Read it if no longer in context). Export only agreed implementation work; retain unapproved remedies as pending findings.
|
||
Count only individually approved new decisions in "Decisions made" and the
|
||
review log; a proposed remedy or next-step answer contributes zero.
|
||
|
||
## Implementation Tasks
|
||
|
||
Before closing this review, synthesize the findings above into a flat list of
|
||
build-actionable tasks. Each task derives from a specific finding — no padding.
|
||
Emit the markdown section AND write a JSONL artifact that `/autoplan` can
|
||
aggregate across phases.
|
||
|
||
### Markdown section (always emit)
|
||
|
||
```markdown
|
||
## Implementation Tasks
|
||
Synthesized from this review's findings. Each task derives from a specific
|
||
finding above. Run with Claude Code or Codex; checkbox as you ship.
|
||
|
||
- [ ] **T1 (P1, human: ~2h / CC: ~15min)** — <component> — <imperative title>
|
||
- Surfaced by: <section name> — <specific finding text or line reference>
|
||
- Files: <paths to touch>
|
||
- Verify: <test command or manual check>
|
||
- [ ] **T2 (P2, human: ~30min / CC: ~5min)** — ...
|
||
```
|
||
|
||
Rules:
|
||
- P1 blocks ship; P2 should land same branch; P3 is a follow-up TODO.
|
||
- If a finding produced no actionable task, do not invent one.
|
||
- If a section had zero findings, emit `_No new tasks from <section>._`
|
||
- Effort uses the AI-compression table from CLAUDE.md.
|
||
|
||
### JSONL artifact (always write, even if zero tasks)
|
||
|
||
`/autoplan` reads this file to aggregate across phases. Build each line with
|
||
`jq -nc` so titles and source findings containing quotes, newlines, or
|
||
backslashes serialize cleanly — never use hand-rolled `echo` / `printf`.
|
||
|
||
```bash
|
||
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
|
||
TASKS_DIR="${HOME}/.gstack/projects/${SLUG:-unknown}"
|
||
mkdir -p "$TASKS_DIR"
|
||
TASKS_FILE="$TASKS_DIR/tasks-design-review-$(date +%Y%m%d-%H%M%S).jsonl"
|
||
COMMIT=$(git rev-parse HEAD 2>/dev/null || echo unknown)
|
||
BRANCH=$(git branch --show-current 2>/dev/null || echo unknown)
|
||
RUN_ID="$(date -u +%Y%m%dT%H%M%SZ)-$$"
|
||
|
||
# Repeat ONE jq invocation per task identified during this review.
|
||
# Substitute the placeholders inline with shell variables you set per task:
|
||
# TASK_ID (T1, T2, ...), PRIORITY (P1/P2/P3), COMPONENT, TITLE,
|
||
# SOURCE_FINDING, EFFORT_HUMAN, EFFORT_CC, FILES_JSON (a JSON array literal
|
||
# like '["browse/src/sanitize.ts","browse/src/server.ts"]').
|
||
jq -nc \
|
||
--arg phase 'design-review' \
|
||
--arg run_id "$RUN_ID" \
|
||
--arg branch "$BRANCH" \
|
||
--arg commit "$COMMIT" \
|
||
--arg id "$TASK_ID" \
|
||
--arg priority "$PRIORITY" \
|
||
--arg component "$COMPONENT" \
|
||
--arg effort_human "$EFFORT_HUMAN" \
|
||
--arg effort_cc "$EFFORT_CC" \
|
||
--arg title "$TITLE" \
|
||
--arg source_finding "$SOURCE_FINDING" \
|
||
--argjson files "$FILES_JSON" \
|
||
'{phase:$phase, run_id:$run_id, branch:$branch, commit:$commit, id:$id, priority:$priority, component:$component, files:$files, effort_human:$effort_human, effort_cc:$effort_cc, title:$title, source_finding:$source_finding}' \
|
||
>> "$TASKS_FILE"
|
||
```
|
||
|
||
If `jq` is not installed, fall back to skipping the JSONL write and warn
|
||
the user to install jq for autoplan aggregation. Never hand-roll JSONL.
|
||
|
||
If zero tasks were identified in this review, still touch the JSONL file
|
||
(`: > "$TASKS_FILE"`) so the aggregator sees that the phase produced output
|
||
this run (an empty file means "ran, no findings" — distinct from "didn't run").
|
||
|
||
|
||
### Completion Summary
|
||
|
||
**Overall design score:** use the lowest of the six rated pass scores (1-6),
|
||
separately before and after approved fixes. Pass 7 is unscored. Keep Step 0's
|
||
initial impression in its own row. An overall 8+ therefore means every rated
|
||
pass is 8+; unresolved findings still prevent a clean review log.
|
||
|
||
```
|
||
+====================================================================+
|
||
| DESIGN PLAN REVIEW — COMPLETION SUMMARY |
|
||
+====================================================================+
|
||
| System Audit | [DESIGN.md status, UI scope] |
|
||
| Step 0 | [initial rating, focus areas] |
|
||
| Pass 1 (Info Arch) | ___/10 → ___/10 after fixes |
|
||
| Pass 2 (States) | ___/10 → ___/10 after fixes |
|
||
| Pass 3 (Journey) | ___/10 → ___/10 after fixes |
|
||
| Pass 4 (AI Slop) | ___/10 → ___/10 after fixes |
|
||
| Pass 5 (Design Sys) | ___/10 → ___/10 after fixes |
|
||
| Pass 6 (Responsive) | ___/10 → ___/10 after fixes |
|
||
| Pass 7 (Decisions) | ___ resolved, ___ deferred |
|
||
+--------------------------------------------------------------------+
|
||
| NOT in scope | written (___ items) |
|
||
| What already exists | written |
|
||
| TODOS.md updates | ___ items proposed |
|
||
| Approved Mockups | ___ generated, ___ approved |
|
||
| Decisions made | ___ added to plan |
|
||
| Decisions deferred | ___ (listed below) |
|
||
| Overall design score | ___/10 → ___/10 |
|
||
+====================================================================+
|
||
```
|
||
|
||
If all passes 8+: "Plan is design-complete. Run /design-review after implementation for visual QA."
|
||
If any below 8: note what's unresolved and why (user chose to defer).
|
||
|
||
### Unresolved Decisions
|
||
List every unresolved finding here, including a finding not yet asked or an unanswered AskUserQuestion. Never silently default to an option.
|
||
|
||
### Approved Mockups
|
||
|
||
If visual mockups were generated during this review, add to the plan file:
|
||
|
||
```
|
||
## Approved Mockups
|
||
|
||
| Screen/Section | Mockup Path | Direction | Notes |
|
||
|----------------|-------------|-----------|-------|
|
||
| [screen name] | ~/.gstack/projects/$SLUG/designs/[folder]/[filename].png | [brief description] | [constraints from review] |
|
||
```
|
||
|
||
Include the full path to each approved mockup (the variant the user chose), a one-line description of the direction, and any constraints. The implementer reads this to know exactly which visual to build from. These persist across conversations and workspaces. If no mockups were generated, omit this section.
|
||
|
||
## Review Log
|
||
|
||
After producing the Completion Summary above, persist the review result.
|
||
|
||
**PLAN MODE EXCEPTION — ALWAYS RUN:** This command writes review metadata to
|
||
`~/.gstack/` (user config directory, not project files). The skill preamble
|
||
already writes to `~/.gstack/sessions/` and `~/.gstack/analytics/` — this is
|
||
the same pattern. The review dashboard depends on this data. Skipping this
|
||
command breaks the review readiness dashboard in /ship.
|
||
|
||
```bash
|
||
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-design-review","timestamp":"TIMESTAMP","status":"STATUS","initial_score":N,"overall_score":N,"unresolved":N,"decisions_made":N,"commit":"COMMIT"}'
|
||
```
|
||
|
||
Substitute values from the Completion Summary:
|
||
- **TIMESTAMP**: current ISO 8601 datetime
|
||
- **STATUS**: "clean" if overall score 8+ AND 0 unresolved; otherwise "issues_open"
|
||
- **initial_score**: initial overall design score before fixes (0-10)
|
||
- **overall_score**: final overall design score after fixes (0-10)
|
||
- **unresolved**: number of unresolved design decisions
|
||
- **decisions_made**: number of design decisions added to the plan
|
||
- **COMMIT**: output of `git rev-parse --short HEAD`
|
||
|
||
## Review Readiness Dashboard
|
||
|
||
After completing the review, read the review log and config to display the dashboard.
|
||
|
||
```bash
|
||
~/.claude/skills/gstack/bin/gstack-review-read
|
||
```
|
||
|
||
Render each record using its recorded host, source, outside_provider, outside_status, and phase. Historical source "claude" means a native Claude subagent; source "claude-code" means the external CLI. Never infer a historical provider from the current harness. Unknown model identity remains unknown. Missing/disabled/skipped outside coverage is distinct from native completion.
|
||
|
||
Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, review, plan-design-review, design-review-lite, adversarial-review, codex-review, codex-plan-review). Ignore entries with timestamps older than 7 days. For the Eng Review row, show whichever is more recent between `review` (diff-scoped pre-landing review) and `plan-eng-review` (plan-stage architecture review). Append "(DIFF)" or "(PLAN)" to the status to distinguish. For the Adversarial row, show whichever is more recent between `adversarial-review` (new auto-scaled) and `codex-review` (legacy). For Design Review, show whichever is more recent between `plan-design-review` (full visual audit) and `design-review-lite` (code-level check). Append "(FULL)" or "(LITE)" to the status to distinguish. For the Outside Voice row, show the most recent `codex-plan-review` entry — this captures outside voices from both /plan-ceo-review and /plan-eng-review.
|
||
|
||
**Source attribution:** If the most recent entry for a skill has a \`"via"\` field, append it to the status label in parentheses. Examples: `plan-eng-review` with `via:"autoplan"` shows as "CLEAR (PLAN via /autoplan)". `review` with `via:"ship"` shows as "CLEAR (DIFF via /ship)". Entries without a `via` field show as "CLEAR (PLAN)" or "CLEAR (DIFF)" as before.
|
||
|
||
Read `autoplan-voices` and `design-outside-voices` for the coverage detail below the dashboard. Group by workflow run and phase, not merely skill. Show each phase’s recorded provider and outside_status; partial coverage must remain partial. These records do not change the engineering gate.
|
||
|
||
Display:
|
||
|
||
```
|
||
+====================================================================+
|
||
| REVIEW READINESS DASHBOARD |
|
||
+====================================================================+
|
||
| Review | Runs | Last Run | Status | Required |
|
||
|-----------------|------|---------------------|-----------|----------|
|
||
| Eng Review | 1 | 2026-03-16 15:00 | CLEAR | YES |
|
||
| CEO Review | 0 | — | — | no |
|
||
| Design Review | 0 | — | — | no |
|
||
| Adversarial | 0 | — | — | no |
|
||
| Outside Voice | 0 | — | — | no |
|
||
+--------------------------------------------------------------------+
|
||
| VERDICT: CLEARED — Eng Review passed |
|
||
+====================================================================+
|
||
```
|
||
|
||
**Review tiers:**
|
||
- **Eng Review (required by default):** The only review that gates shipping. Covers architecture, code quality, tests, performance. Can be disabled globally with \`gstack-config set skip_eng_review true\` (the "don't bother me" setting).
|
||
- **CEO Review (optional):** Use your judgment. Recommend it for big product/business changes, new user-facing features, or scope decisions. Skip for bug fixes, refactors, infra, and cleanup.
|
||
- **Design Review (optional):** Use your judgment. Recommend it for UI/UX changes. Skip for backend-only, infra, or prompt-only changes.
|
||
- **Adversarial Review (automatic):** Always-on for every review. Every diff gets a native adversarial pass and, when enabled and available, a host-selected outside challenge. Large diffs (200+ lines) additionally get a structured outside review with P1 gate.
|
||
- **Outside Voice (default-on):** Independent plan review through the host-selected provider after /plan-ceo-review and /plan-eng-review. The codex_reviews switch disables the entire extra step. Provider failure uses the existing native fallback and reports missing outside coverage. Never gates shipping.
|
||
|
||
**Verdict logic:**
|
||
- **CLEARED**: Eng Review has >= 1 entry within 7 days from either \`review\` or \`plan-eng-review\` with status "clean" (or \`skip_eng_review\` is \`true\`)
|
||
- **NOT CLEARED**: Eng Review missing, stale (>7 days), or has open issues
|
||
- CEO, Design, and outside reviews are shown for context but never block shipping
|
||
- If \`skip_eng_review\` config is \`true\`, Eng Review shows "SKIPPED (global)" and verdict is CLEARED
|
||
|
||
**Staleness detection:** After displaying the dashboard, check if any existing reviews may be stale:
|
||
- **Content-first rule (diff-scoped rows only: \`review\`, \`adversarial-review\`, \`codex-review\`, ship-stage entries).** Parse the \`---WTREE---\` and \`---DIRTY---\` sections from the bash output. If an entry has a \`wtree\` field AND it equals the current \`---WTREE---\` value, the review is CURRENT — identical content, regardless of commit count, rebase, amend, or whether it was committed yet (wtree equality alone proves identical content; that is the keystone property). Skip the commit-count heuristic for that entry and show no staleness note.
|
||
- Plan-tier rows (plan-ceo-review, plan-eng-review, plan-design-review) grade a plan file, not the repo tree — never apply the wtree rule to them; they keep the 7-day freshness logic. If such an entry carries a \`plan_sha256\` field, you MAY compare it against the current plan file's sha256 and note "plan changed since review" on mismatch.
|
||
- Fallback (no \`wtree\` on the entry, or wtree mismatch): parse the \`---HEAD---\` section to get the current HEAD commit hash. For each review entry that has a \`commit\` field: compare it against the current HEAD. If different, count elapsed commits: \`git rev-list --count STORED_COMMIT..HEAD\`. If that command FAILS (the stored commit was rebased away), grade UNKNOWN and treat as stale — do not error. Display: "Note: {skill} review from {date} may be stale — {N} commits since review"
|
||
- For entries without a \`commit\` field (legacy entries): display "Note: {skill} review from {date} has no commit tracking — consider re-running for accurate staleness detection"
|
||
- If all reviews grade CURRENT (wtree match or HEAD match), do not display any staleness notes
|
||
|
||
## Plan File Review Report
|
||
|
||
After displaying the Review Readiness Dashboard in conversation output, also update the
|
||
**plan file** itself so review status is visible to anyone reading the plan.
|
||
|
||
### Detect the plan file
|
||
|
||
1. Check if there is an active plan file in this conversation (the host provides plan file
|
||
paths in system messages — look for plan file references in the conversation context).
|
||
2. If not found, skip this section silently — not every review runs in plan mode.
|
||
|
||
### Generate the report
|
||
|
||
Read the review log output you already have from the Review Readiness Dashboard step above.
|
||
Parse each JSONL entry using recorded provenance. Historical source "claude" is a native Claude subagent; "claude-code" is the external CLI. Keep historical codex identifiers and never relabel old records from the current harness. Unknown model identity remains unknown. For new records, show host, outside_provider, outside_status, and phase. Only completed external records establish outside coverage; native fallbacks do not.
|
||
|
||
Each skill logs different fields:
|
||
|
||
- **plan-ceo-review**: \`status\`, \`unresolved\`, \`critical_gaps\`, \`mode\`, \`scope_proposed\`, \`scope_accepted\`, \`scope_deferred\`, \`commit\`
|
||
→ Findings: "{scope_proposed} proposals, {scope_accepted} accepted, {scope_deferred} deferred"
|
||
→ If scope fields are 0 or missing (HOLD/REDUCTION mode): "mode: {mode}, {critical_gaps} critical gaps"
|
||
- **plan-eng-review**: \`status\`, \`unresolved\`, \`critical_gaps\`, \`issues_found\`, \`mode\`, \`commit\`
|
||
→ Findings: "{issues_found} issues, {critical_gaps} critical gaps"
|
||
- **plan-design-review**: \`status\`, \`initial_score\`, \`overall_score\`, \`unresolved\`, \`decisions_made\`, \`commit\`
|
||
→ Findings: "score: {initial_score}/10 → {overall_score}/10, {decisions_made} decisions"
|
||
- **plan-devex-review**: \`status\`, \`initial_score\`, \`overall_score\`, \`product_type\`, \`tthw_current\`, \`tthw_target\`, \`mode\`, \`persona\`, \`competitive_tier\`, \`unresolved\`, \`commit\`
|
||
→ Findings: "score: {initial_score}/10 → {overall_score}/10, TTHW: {tthw_current} → {tthw_target}"
|
||
- **devex-review**: \`status\`, \`overall_score\`, \`product_type\`, \`tthw_measured\`, \`dimensions_tested\`, \`dimensions_inferred\`, \`boomerang\`, \`commit\`
|
||
→ Findings: "score: {overall_score}/10, TTHW: {tthw_measured}, {dimensions_tested} tested/{dimensions_inferred} inferred"
|
||
- **codex-review**: \`status\`, \`gate\`, \`findings\`, \`findings_fixed\`
|
||
→ Findings: "{findings} findings, {findings_fixed}/{findings} fixed"
|
||
|
||
All fields needed for the Findings column are now present in the JSONL entries.
|
||
For the review you just completed, you may use richer details from your own Completion
|
||
Summary. For prior reviews, use the JSONL fields directly — they contain all required data.
|
||
|
||
Produce this markdown table:
|
||
|
||
\`\`\`markdown
|
||
## GSTACK REVIEW REPORT
|
||
|
||
| Review | Trigger | Why | Runs | Status | Findings |
|
||
|--------|---------|-----|------|--------|----------|
|
||
| CEO Review | \`/plan-ceo-review\` | Scope & strategy | {runs} | {status} | {findings} |
|
||
| Outside Review | {recorded provider and trigger} | Independent 2nd opinion | {runs} | {outside_status} | {findings} |
|
||
| Eng Review | \`/plan-eng-review\` | Architecture & tests (required) | {runs} | {status} | {findings} |
|
||
| Design Review | \`/plan-design-review\` | UI/UX gaps | {runs} | {status} | {findings} |
|
||
| DX Review | \`/plan-devex-review\` | Developer experience gaps | {runs} | {status} | {findings} |
|
||
\`\`\`
|
||
|
||
Below the table, add these lines. **OUTSIDE COVERAGE** and **CROSS-MODEL** are optional (omit when
|
||
empty); **VERDICT** is always present:
|
||
|
||
- **OUTSIDE COVERAGE:** provider, phase, completion state, and findings. Include unavailable, disabled, and skipped phases; never infer completion from another phase.
|
||
- **CROSS-MODEL:** only when native and completed external reviews exist — overlap analysis with recorded providers and known model identity. Do not infer distinct model families from harness names.
|
||
- **VERDICT:** list reviews that are CLEAR (e.g., "CEO + ENG CLEARED — ready to implement").
|
||
If Eng Review is not CLEAR and not skipped globally, append "eng review required".
|
||
|
||
**Unresolved-decisions status (MANDATORY — never omitted; the report's final non-whitespace
|
||
line).** After VERDICT, end the report (content under the \`## GSTACK REVIEW REPORT\`
|
||
heading — a bold label, never a new \`## \` heading; exempt from the "omit when empty"
|
||
rule) with exactly one: the exact unbolded line \`NO UNRESOLVED DECISIONS\` (a bolded one
|
||
does NOT count), OR a \`**UNRESOLVED DECISIONS:**\` header + one bullet per open item
|
||
(last bullet = final line; add \`+ N unresolved from prior reviews\` only when N > 0).
|
||
This avoids double-counting: list THIS review's open items from context; for prior reviews
|
||
sum \`unresolved\` over the latest fresh row per skill (dashboard 7-day window) after you
|
||
DROP the current skill's row; emit the sentinel only when both are zero.
|
||
|
||
### Write to the plan file
|
||
|
||
**PLAN MODE EXCEPTION — ALWAYS RUN:** This writes to the plan file, which is the one
|
||
file you are allowed to edit in plan mode. The plan file review report is part of the
|
||
plan's living status.
|
||
|
||
The report must always be the LAST section of the plan file — never mid-file.
|
||
Use a single delete-then-append flow:
|
||
|
||
1. Read the plan file (Read tool) to see its full current content. Search the read
|
||
output for a \`## GSTACK REVIEW REPORT\` heading anywhere in the file.
|
||
2. If found, use the Edit tool to DELETE the entire existing section. Match from
|
||
\`## GSTACK REVIEW REPORT\` through either the next \`## \` heading or end of
|
||
file, whichever comes first. Replace with the empty string. This applies
|
||
regardless of where the section currently lives — mid-file deletion is
|
||
intentional, not a special case. If the Edit fails (e.g., concurrent edit
|
||
changed the content), re-read the plan file and retry once.
|
||
3. After the delete (or skipped, if no section existed), append the new
|
||
\`## GSTACK REVIEW REPORT\` section at the END of the file. Use the Edit
|
||
tool to match the file's current last paragraph and add the section after it,
|
||
or use Write to re-emit the whole file with the section at the end.
|
||
4. Verify with the Read tool that \`## GSTACK REVIEW REPORT\` is the last
|
||
\`## \` heading in the file before continuing. If it isn't, repeat steps
|
||
2-3 once.
|
||
|
||
Do NOT replace the section in place. The "replace mid-file" path is what allowed
|
||
prior versions to leave the report mid-file when an older report already lived
|
||
there — the user then sees a plan whose review report is not at the bottom and
|
||
(correctly) rejects it.
|
||
|
||
## Capture Learnings
|
||
|
||
If you discovered a non-obvious pattern, pitfall, or architectural insight during
|
||
this session, log it for future sessions:
|
||
|
||
```bash
|
||
~/.claude/skills/gstack/bin/gstack-learnings-log '{"skill":"plan-design-review","type":"TYPE","key":"SHORT_KEY","insight":"DESCRIPTION","confidence":N,"source":"SOURCE","files":["path/to/relevant/file"]}'
|
||
```
|
||
|
||
**Types:** `pattern` (reusable approach), `pitfall` (what NOT to do), `preference`
|
||
(user stated), `architecture` (structural decision), `tool` (library/framework insight),
|
||
`operational` (project environment/CLI/workflow knowledge).
|
||
|
||
**Sources:** `observed` (you found this in the code), `user-stated` (user told you),
|
||
`inferred` (AI deduction), `cross-model` (both Claude and Codex agree).
|
||
|
||
**Confidence:** 1-10. Be honest. An observed pattern you verified in the code is 8-9.
|
||
An inference you're not sure about is 4-5. A user preference they explicitly stated is 10.
|
||
|
||
**files:** Include the specific file paths this learning references. This enables
|
||
staleness detection: if those files are later deleted, the learning can be flagged.
|
||
|
||
**Only log genuine discoveries.** Don't log obvious things. Don't log things the user
|
||
already knows. A good test: would this insight save time in a future session? If yes, log it.
|
||
|
||
|
||
|
||
## Brain Calibration Write-Back (Phase 2 / gated)
|
||
|
||
When the skill makes a typed prediction worth tracking (scope decision,
|
||
TTHW target, architectural bet, wedge commitment), it MAY write a
|
||
`kind=bet` take to the brain so a calibration profile builds over time.
|
||
|
||
**Gated on two things:**
|
||
1. Brain trust policy for the active endpoint is `personal` (check via
|
||
`~/.claude/skills/gstack/bin/gstack-config get brain_trust_policy@<endpoint-hash>`).
|
||
Shared brains skip write-back to avoid polluting team calibration.
|
||
2. Feature flag `BRAIN_CALIBRATION_WRITEBACK` is set (today: false; flips
|
||
to true when upstream gbrain v0.42+ ships `takes_add` MCP op).
|
||
|
||
When both gates pass, the write-back path uses `mcp__gbrain__takes_add`
|
||
to record a take with weight 0.5 (per SKILL_CALIBRATION_WEIGHTS).
|
||
If the MCP op is unavailable, fall back to `mcp__gbrain__put_page` with
|
||
a gstack:takes fence block (documented but uglier path).
|
||
|
||
Mandatory take frontmatter shape:
|
||
```yaml
|
||
kind: bet
|
||
holder: <user identity from whoami>
|
||
claim: <one-line prediction the skill is making>
|
||
weight: 0.5
|
||
since_date: <today's date>
|
||
expected_resolution: <date in 1-3 months depending on skill>
|
||
source_skill: plan-design-review
|
||
```
|
||
|
||
After write, invalidate the affected digests so the next preflight reflects
|
||
the new state:
|
||
|
||
```bash
|
||
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)" 2>/dev/null || true
|
||
~/.claude/skills/gstack/bin/gstack-brain-cache invalidate brand --project "$SLUG" 2>/dev/null || true
|
||
```
|
||
|
||
|
||
## Brain Cache Background Refresh
|
||
|
||
After the skill's work completes (and telemetry has logged), kick a
|
||
background refresh of any cache digest that's getting close to its TTL.
|
||
This is non-blocking — the user doesn't wait. Next invocation benefits
|
||
from the warm cache.
|
||
|
||
```bash
|
||
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)" 2>/dev/null || true
|
||
(~/.claude/skills/gstack/bin/gstack-brain-cache refresh --project "$SLUG" 2>/dev/null &) || true
|
||
```
|
||
|
||
|
||
## Next Steps — Review Chaining
|
||
|
||
After displaying the Review Readiness Dashboard, recommend the next review(s) based on what this design review discovered. Read the dashboard output to see which reviews have already been run and whether they are stale.
|
||
|
||
**Recommend /plan-eng-review if eng review is not skipped globally** — check the dashboard output for `skip_eng_review`. If it is `true`, eng review is opted out — do not recommend it. Otherwise, eng review is the required shipping gate. If this design review added significant interaction specifications, new user flows, or changed the information architecture, emphasize that eng review needs to validate the architectural implications. If an eng review already exists but the commit hash shows it predates this design review, note that it may be stale and should be re-run.
|
||
|
||
**Consider recommending /plan-ceo-review** — but only if this design review revealed fundamental product direction gaps. Specifically: if the overall design score started below 4/10, if the information architecture had major structural problems, or if the review surfaced questions about whether the right problem is being solved. AND no CEO review exists in the dashboard. This is a selective recommendation — most design reviews should NOT trigger a CEO review.
|
||
|
||
**If both are needed, recommend eng review first** (required gate).
|
||
|
||
**Recommend design exploration skills when appropriate** — /design-shotgun and /design-html
|
||
produce design artifacts (mockups, HTML previews), not application code. They belong in
|
||
plan mode alongside reviews. If this design review found visual issues that would benefit
|
||
from exploring new directions, recommend /design-shotgun. If approved mockups exist and
|
||
need to be turned into working HTML, recommend /design-html.
|
||
|
||
Use AskUserQuestion to present the next step. Always include the manual/stop
|
||
option E; offer only applicable follow-on skills. If the user chooses manual,
|
||
finish without starting another skill:
|
||
- **A)** Run /plan-eng-review next (required gate)
|
||
- **B)** Run /plan-ceo-review (only if fundamental product gaps found)
|
||
- **C)** Run /design-shotgun — explore visual design variants for issues found
|
||
- **D)** Run /design-html — generate Pretext-native HTML from approved mockups
|
||
- **E)** Skip — I'll handle next steps manually
|
||
|
||
## Formatting Rules
|
||
* NUMBER issues (1, 2, 3...) and LETTERS for options (A, B, C...).
|
||
* Label with NUMBER + LETTER (e.g., "3A", "3B").
|
||
* One sentence max per option.
|
||
* Pause for each unresolved issue. If a pass has none, say so and continue; do not manufacture a question.
|
||
* Rate before and after each pass for scannability.
|