mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-02 17:40:02 +02:00
Garry Tan
dcaea52800
* feat: add surface-aware exploratory QA and ship documentation gates * test: preserve delegated QA setup authority after main integration * fix(qa): clarify exploration order and preserve report artifacts * test(qa): follow the shared setup reference directly * refactor(ship): make verification and recovery routes explicit * test(ship): align evidence and review guards with explicit routes * fix(workflows): clarify ship recovery and functional QA evidence * fix(workflows): clarify approval recovery and full QA coverage * refactor(workflows): order review transactions and clarify ship state * fix(ship): clarify final verification and fail closed at publication * fix(evals): attribute native atomic documentation writes * fix(ship): clarify recovery and documentation lifecycle guidance * fix(test): preserve observed native placeholder styling in CI * fix(codex): report watchdog timeouts without a process-exit race * Checkpoint functional QA implementation and workflow validation repairs * Fix documentation and shared-review fixture contracts * docs: clarify judge reuse and evaluation supervision * test: align review evidence and selected case contracts * test: verify append-only documentation checkpoints and recovery * fix: qualify QA workflows and CI validation repairs * fix: launch shared-libs fixture scripts on Windows * fix: qualify QA deadlines, fixture isolation, and shard cleanup * fix: preserve qualified QA and cancellation repairs * fix: enforce functional fixture authority and share strict event decoding * fix: retain free-test evidence and explain recovery * fix: reject malformed native evidence after decoder consolidation * test: use reliable capture for telemetry privacy filters * test: refresh measured quick coverage and document validation costs * Fix native fixture receipts and preserve VM validation evidence * Align negative judge controls with upstream clarity policy * Fix report-only QA preparation and public evidence handling * Clarify QA-only preparation and current-report preservation * Stream Ship quality judgments with an explicit 64k response contract * Validate compact judge reasoning locally with supported wire schema * Align functional QA fixture instructions with evidence acceptance * Bind native browser diagnostics to execution evidence and align review verdicts * Preserve native diagnostic line boundaries * Serialize functional QA evidence from native captures * Keep large QA evidence fixture payload out of Windows argv
30 lines
1.4 KiB
TypeScript
30 lines
1.4 KiB
TypeScript
import { expect, test } from 'bun:test';
|
|
import { mkdtempSync, readFileSync, rmSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import {
|
|
reviewLifecycleInstructions, SHARED_LIBS_ROOT, type SharedLibsFixture,
|
|
} from './helpers/shared-libs-eval-fixture';
|
|
|
|
test('the native shared-code fixture consumes the relocated persistence contract', () => {
|
|
const root = mkdtempSync(join(tmpdir(), 'review-flow-'));
|
|
try {
|
|
const text = readFileSync(reviewLifecycleInstructions({ root } as SharedLibsFixture), 'utf8');
|
|
const start = text.indexOf('## Step 5.8: Persist Eng Review result');
|
|
const command = text.indexOf('/bin/gstack-review-log', start);
|
|
expect(start).toBeGreaterThan(0);
|
|
expect(command).toBeGreaterThan(start);
|
|
for (const field of ['REVIEW_START', 'COMPLETED', 'CONVERGED', 'CYCLES', 'snapshot_covered_paths']) {
|
|
expect(text.slice(start, command)).toContain(field);
|
|
}
|
|
expect(text.match(/## Step 5\.8: Persist Eng Review result/g)).toHaveLength(1);
|
|
expect(text).toContain('--finish REVIEW_START');
|
|
expect(text).toContain(`${SHARED_LIBS_ROOT}/review/sections/shared-code-reuse.md`);
|
|
expect(text).not.toContain('### Before persisting Eng Review (Step 5.8)');
|
|
expect(readFileSync(join(SHARED_LIBS_ROOT, 'review/sections/shared-code-reuse.md'), 'utf8'))
|
|
.toContain('canReuseSharedLibsAdvisory');
|
|
} finally {
|
|
rmSync(root, { recursive: true, force: true });
|
|
}
|
|
});
|