Files
gstack/test
garrytan 561b82e861 test(W7c): shrink plan-review-cases to structural and meaning checks
W7c conversion (t03 F1-F4; t02 F4/F5 duplicate STOP/threshold pins). Pins
713 -> 208 lines by the brief's grep (toContain|toMatch|indexOf|includes);
prose assertions 592 -> 366 (toContain/toMatch calls plus expectAll regex
rules; expect() calls per run 3232 -> 2808). Tests 218 -> 215. t03 F1 (stale
~/.gstack/projects discovery path) was already fixed by W7a on the base; its
$GSTACK_STATE_ROOT check and the stale-path ban are kept.

Kept byte-exact or structural: marker-order arrays (### Prepare an unanswered
choice -> ### Send once and wait -> ### Record the answer, heading list
equality, Pending-record checkpoint, finish steps 1-6, entrypoint recovery
order, output placeholder order), the parsed write-policy table routes, the
generateAntiShortcutClause host matrix, every not.toContain(stale) ban,
numeric limits (8+ files / 2+ new classes, fewer than 8 / 2, under 5 words,
2-3 options, six-column / five-field / four-step), consumed tokens and field
names (`scope accepted as-is`, `scope reduced per recommendation`, FULL_REVIEW/
SCOPE_REDUCED mapping, **issues_found**, SOURCE=/OUTSIDE_STATUS=/STATUS=,
OUTCOME=, `BLOCKED`, `## GSTACK REVIEW REPORT`, `currentDecision`, D<N> and
ROW-ID formats, prescribed A-D menus), placeholders, commands/paths and all
picker behavior tests (unchanged). STOP/wait/approval/safety lines become
case-insensitive meaning checks located between their headings (e.g.
/stop until the actual answer arrives/i between Send once and Record the
answer; /do not replace the section in place/i plus /append the new report
at EOF/i). CEO invariants (periodic-only once plan-ceo-review-benefits
retires) each keep one free check. Eng/Design/DX invariants keep one free
check too; nothing below relies on a periodic-only E2E.

Removed assertion groups (invariant -> remaining protection):
- CEO route/narrow depth (:19) full sentences: admin answers approve nothing,
  plan decisions run steps 1-4, settled choices go to 0E -> kept free:
  Admin < Plan decision order, checkpoint order, five short /i checks, stale ban.
- Eng evidence paths/labels (:33) 'Prior Learnings configuration', path rule
  sentences -> kept free: the three path field labels, /never invent paths/i,
  `not available`, label tokens, stale ban.
- Eng first report save (:47) 9 requirement sentences -> 5 short /i
  requirements with the same remove-one-must-throw self-control; parent-dir,
  original-plan-copy and scope-record clauses dropped (initialization
  invariant kept by target-header/preserve/no-findings/placement/terminal-
  report checks; collision suffix kept in the write-policy test).
- Eng setup selectors (:79) and its duplicate in the big Eng ordering test:
  selectors approve no remedy -> kept free: /these selections approve no
  engineering remedy/i, B selectors, no pre-answer ledger, stale ban; the
  'For the next choice' sentence -> kept free: transaction marker order.
- Eng performance (:94) exact bullet list -> kept free: four concern
  keywords from the parsed bullets; Decision-procedure sentence -> kept free
  in the four-section test.
- Eng complexity/MODE (:105) per-target counting, 'Count each once', 'Keep it
  current', 'Continue to Section 1' sentences -> kept free: count-selected-
  work, both thresholds, MODE tokens and mapping, scope-reduction meaning,
  'approves no pending remedy', Continue-to-Section-1 in the C order array.
- Eng three-stage transaction (:125) sentence markers -> same 13-step order
  array with short /i anchors and the remove-one-must-throw control.
- Eng Test Plan refresh, coverage trace (:150, :162) sentences -> kept free:
  placeholder count/order, prepare step count, short /i checks; coverage audit
  also graded by plan-eng-coverage-audit (gate).
- CEO fallback (:178) sentences -> kept free: host mode token matrix, status
  field values, /final report is written later in Required Outputs/i, ban.
- Persistence per skill (:229) Eng duplicates ('If the required log is
  forbidden', 'Neither supplies', FULL_REVIEW mapping, 'after successful
  Read-back') -> kept free in the readiness, complexity and write-policy
  tests; CEO 'retain its diagnostic' -> kept free: /do not claim that entry
  was recorded/i and three other CEO log checks.
- Report resolver per host (:261) duplicate 'Do not choose another
  destination', 'Review record and write policy', 'full review output',
  explicit/named/active sentences -> kept free: target precedence order;
  CEO writer's seven sentences -> kept free: six-anchor order ending at
  '4. **Read-back gate:**' plus the blocked-return check.
- Generated carriers (:327) bold STOP pin -> /stop until the actual answer
  arrives/i in the dispatch order array.
- Big Eng ordering test (:358) duplicates of the gate describe (one question
  object, 8+/STOP, both-retain, setup, separate instrumentation, keep chosen
  values, calibration<procedure<scope, Decision procedure < Architecture,
  outside-voice consent lines) -> kept free once each (boundary list, queue
  test, preparation order array now ending at ### 1. Architecture review);
  'Use existing tests ... bounded probes', 'post-answer scope summary',
  'Compare only the file/class arrangement', 'contracts and approved
  security...', 'With no proposed cuts', 'Present numbered...' sentences ->
  kept free: build-boundary order check, structure-question and
  unapproved-fixes checks, C-step order array.
- Eng gate describe: exact-duplicate pins (same sentence 2-4x in one test or
  repeated per section inside the 4-section loop) -> one copy kept; ledger
  placeholder descriptions (Plan baseline/Runtime evidence/Actual answer/
  Accepted scope text) -> kept free: parsed ledger field-name list, R1 header,
  State values, A)/B) selectors, ledger position.
- Gate tests 'identifies commitments before comparing values', 'common new
  defaults...', 'exact prior answers authorize...', 'finding evidence, stable
  decision identity...' merged: every non-duplicate invariant (optional
  depths, shared new value needs approval, unknown risks visible, drafts grant
  nothing, reopened ID keeps D<N>, test scores not answer status) -> kept free
  as one /i check in 'current contracts...' or 'all four section gates...';
  their order checks -> kept free: prepare<identify<compare<save<send<record.
- Remove-old-occurrence, 'Otherwise leave the remedy pending', 'no question
  or comparison grid is needed', 'never the saved-report gate', 'Compare the
  label separately', 'When revising, replace the whole current payload',
  'It may be the selected plan', 'Present each completely as not persisted',
  'If none is permitted...', 'A forbidden write follows its row', 'Run
  Learning hooks ...', 'Refresh affected tests...', 'If startup values...',
  'instead of creating another approval row', 'Keep that remedy pending' ->
  same invariant kept free by an adjacent check (State replace/once checks,
  approves-no-implementation, factual-correction, recovery routing, payload
  rebuild, write-policy routes, return-to-entrypoint count, late-change and
  blocked checks, common-work check).
- Worked example anchor sentence -> anchored on the Compare section and
  'Ask about jitter first:'; parsed R1/R2 table equality kept.
- Outside-voice queue: dead generic branch (all three skills `continue`
  before it; never executed) removed -> none needed (unreachable). Eng
  procedure re-checks inside the queue (5 sentences) -> kept free in the
  gate describe. Shared CEO/Eng/DX scope-revision sentences hoisted to one
  shared /i block per skill; CEO 'Keep candidate scope ...' etc. -> kept free
  as short /i checks; prescribed A-D menus kept exact.
- Design register (:1771) sentences -> kept free: grounding-before-question
  order and three /i checks; 'Surface real missing decisions' dropped
  (positive restatement of the same rule).
Gate-tier coverage that also grades this prose: judges 'plan-eng-review/
SKILL.md sections', 'plan-design-review/SKILL.md passes', 'plan-ceo-review/
SKILL.md modes'; E2Es plan-eng-coverage-audit, plan-review-report,
plan-devex-review-plan-mode (gate). Cosmetic pins dropped without controls:
bold/caps STOP and NOT, issue-number comments unchanged.

Mutation pass (scratch worktree; eng/ceo/design templates and the
outside-voice, testing and review-dashboard resolvers): 33/33 as expected;
24 kept-step/marker/safety/numeric mutations go red, 6 rewordings of dropped
sentences and 3 lowered-register STOP/NOT lines stay green. Log:
.context/mutation-plan-review-cases.md.

Runtime (bun test, Bun 1.4.0, median of 3): 0.85 s -> 0.77 s.
2026-10-03 01:18:06 +00:00
..