mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-02 17:40:02 +02:00
Garry Tan
dcaea52800
* feat: add surface-aware exploratory QA and ship documentation gates * test: preserve delegated QA setup authority after main integration * fix(qa): clarify exploration order and preserve report artifacts * test(qa): follow the shared setup reference directly * refactor(ship): make verification and recovery routes explicit * test(ship): align evidence and review guards with explicit routes * fix(workflows): clarify ship recovery and functional QA evidence * fix(workflows): clarify approval recovery and full QA coverage * refactor(workflows): order review transactions and clarify ship state * fix(ship): clarify final verification and fail closed at publication * fix(evals): attribute native atomic documentation writes * fix(ship): clarify recovery and documentation lifecycle guidance * fix(test): preserve observed native placeholder styling in CI * fix(codex): report watchdog timeouts without a process-exit race * Checkpoint functional QA implementation and workflow validation repairs * Fix documentation and shared-review fixture contracts * docs: clarify judge reuse and evaluation supervision * test: align review evidence and selected case contracts * test: verify append-only documentation checkpoints and recovery * fix: qualify QA workflows and CI validation repairs * fix: launch shared-libs fixture scripts on Windows * fix: qualify QA deadlines, fixture isolation, and shard cleanup * fix: preserve qualified QA and cancellation repairs * fix: enforce functional fixture authority and share strict event decoding * fix: retain free-test evidence and explain recovery * fix: reject malformed native evidence after decoder consolidation * test: use reliable capture for telemetry privacy filters * test: refresh measured quick coverage and document validation costs * Fix native fixture receipts and preserve VM validation evidence * Align negative judge controls with upstream clarity policy * Fix report-only QA preparation and public evidence handling * Clarify QA-only preparation and current-report preservation * Stream Ship quality judgments with an explicit 64k response contract * Validate compact judge reasoning locally with supported wire schema * Align functional QA fixture instructions with evidence acceptance * Bind native browser diagnostics to execution evidence and align review verdicts * Preserve native diagnostic line boundaries * Serialize functional QA evidence from native captures * Keep large QA evidence fixture payload out of Windows argv
35 lines
2.3 KiB
Markdown
35 lines
2.3 KiB
Markdown
<!-- AUTO-GENERATED from shared-code-reuse.md.tmpl — do not edit directly -->
|
|
<!-- Regenerate: bun run gen:skill-docs -->
|
|
**Reuse a skipped shared-code advisory only with complete structural evidence:**
|
|
|
|
1. **Read the evidence.** Read all supporting callers and the helper destination.
|
|
Establish first-party authored provenance and whether the current extraction
|
|
is worthwhile; the checker cannot decide that. Retain `evidence_paths`/`helper_target`.
|
|
2. **Run the checker.** From the repository root, pass the current finding as
|
|
literal JSON on stdin. Replace REVIEW_START with this pass's captured token
|
|
and the example paths/symbol with actual evidence. Keep the quoted delimiter.
|
|
|
|
```bash
|
|
"$HOME/.claude/skills/gstack/bin/gstack-review-log" --check-shared-libs REVIEW_START <<'GSTACK_SHARED_LIBS_REUSE_JSON'
|
|
{"advisory":true,"severity":"INFORMATIONAL","evidence_paths":["src/caller-a.ts","src/caller-b.ts"],"helper_target":{"path":"src/shared.ts","symbol":"sharedHelper"}}
|
|
GSTACK_SHARED_LIBS_REUSE_JSON
|
|
```
|
|
|
|
3. **Act on its result.** Read the JSON. Only `reusable: true` permits suppression.
|
|
False, command failure or unreadable output requires fresh source review and a
|
|
new decision, never suppression. Do not supply your own snapshot, prior record or coverage.
|
|
4. **Persist through the logger.** The logger recomputes final coverage; never
|
|
supply proof yourself. Real defects retain normal Fix-First handling independently.
|
|
|
|
**What a reusable result proves (do not reconstruct these checks yourself):**
|
|
- Identity: `sharedLibsFingerprint` plus the actual repo, raw branch and current snapshot.
|
|
The checker reads REVIEW_START without consuming/replacing it. Sanitized branch names are not identity.
|
|
- Prior decision: completed/converged review, verified binding, explicit Skip and
|
|
logger-versioned `snapshot_covered_paths`; older unversioned coverage needs a fresh decision.
|
|
- Source: `canReuseSharedLibsAdvisory` requires every supporting path's raw file
|
|
byte-for-byte with its blob. Exclude assume-unchanged, skip-worktree and sparse index
|
|
entries; symlinks/ancestors, submodules, ignored/outside or unreadable files;
|
|
active/unknown Git filters, encodings and line conversion.
|
|
- Safe inspection: disables fsmonitor and optional locks; never uses external diff/textconv.
|
|
Unknown evidence fails closed.
|