Garry Tan and capy-ai[bot]
a26529ac8e
/ship accepts a stopped review once the owner rules its findings open notes (GST-3267) ( #4552 )
...
When the final review or the native reader stops on findings and the
owner records each one with `gstack-approvals rule` at that head, /ship
now counts those rulings when it binds the two reviews, so /ship can
finish.
Before, the review reader ignored rulings there, so a PR with green CI
and accepted findings could not finish /ship (harness-evals#498).
Nothing to do: a ruling for another branch, head or finding, or one
gstack wrote for itself, still counts for nothing.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2026-11-20 08:26:16 +00:00
..
2026-11-18 17:00:18 +00:00
2026-10-31 18:12:53 +00:00
2026-11-08 02:18:23 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 16:54:44 +00:00
2026-11-18 17:00:18 +00:00
2026-11-08 00:59:38 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-20 02:24:04 +00:00
2026-11-09 23:29:20 +00:00
2026-11-09 06:38:42 +00:00
2026-11-02 14:49:46 +00:00
2026-11-09 09:14:58 +00:00
2026-11-02 14:49:46 +00:00
2026-11-18 16:45:06 +00:00
2026-11-17 12:02:11 +00:00
2026-11-18 08:47:07 +00:00
2026-11-03 02:08:50 +00:00
2026-11-17 13:22:10 +00:00
2026-11-17 13:22:10 +00:00
2026-11-18 08:47:07 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 12:02:11 +00:00
2026-11-17 12:02:11 +00:00
2026-11-08 16:53:27 +00:00
2026-11-18 02:12:43 +00:00
2026-11-04 03:42:16 +00:00
2026-11-18 02:12:43 +00:00
2026-11-18 02:21:31 +00:00
2026-11-18 08:47:07 +00:00
2026-11-07 08:39:20 +00:00
2026-11-02 14:49:46 +00:00
2026-11-02 14:49:46 +00:00
2026-11-03 02:08:50 +00:00
2026-11-07 18:43:11 +00:00
2026-11-18 16:45:06 +00:00
2026-11-18 17:00:18 +00:00
2026-11-13 23:46:15 +00:00
2026-11-17 13:22:10 +00:00
2026-11-17 12:02:11 +00:00
2026-11-19 08:55:01 +00:00
2026-11-17 16:44:06 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 15:17:30 +00:00
2026-11-19 20:10:49 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 10:03:19 +00:00
2026-11-18 02:12:43 +00:00
2026-11-19 11:50:17 +00:00
2026-11-09 18:23:40 +00:00
2026-11-19 22:37:01 +00:00
2026-11-19 15:42:21 +00:00
2026-11-18 17:00:18 +00:00
2026-11-08 00:59:38 +00:00
2026-11-18 17:00:18 +00:00
2026-11-08 11:23:55 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-15 02:11:18 +00:00
2026-11-02 01:35:47 +00:00
2026-11-18 17:00:18 +00:00
2026-11-16 02:55:19 +00:00
2026-11-16 02:55:19 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 08:39:43 +00:00
2026-11-17 23:19:24 +00:00
2026-11-19 15:16:23 +00:00
2026-11-07 06:01:30 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 22:47:26 +00:00
2026-11-18 01:28:22 +00:00
2026-11-20 08:26:16 +00:00
2026-11-17 12:02:11 +00:00
2026-11-19 13:33:04 +00:00
2026-11-18 17:00:18 +00:00
2026-11-13 18:22:43 +00:00
2026-11-13 18:22:43 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 11:30:53 +00:00
2026-11-13 18:22:43 +00:00
2026-11-20 02:24:04 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 23:36:58 +00:00
2026-11-18 23:36:58 +00:00
2026-11-19 20:10:49 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 11:30:53 +00:00
2026-11-03 22:58:53 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 17:13:42 +00:00
2026-11-02 17:44:00 +00:00
2026-11-09 04:14:37 +00:00
2026-11-18 17:00:18 +00:00
2026-11-07 07:39:51 +00:00
2026-11-02 14:49:46 +00:00
2026-11-04 01:31:37 +00:00
2026-11-18 16:44:07 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-01 06:11:17 +00:00
2026-11-19 11:50:17 +00:00
2026-11-02 14:49:46 +00:00
2026-11-19 11:50:17 +00:00
2026-11-18 15:08:17 +00:00
2026-11-17 12:02:11 +00:00
2026-11-04 01:22:38 +00:00
2026-11-17 13:14:33 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 17:05:16 +00:00
2026-11-17 13:14:33 +00:00
2026-11-18 08:34:39 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 10:03:19 +00:00
2026-11-07 05:51:12 +00:00
2026-11-03 02:18:33 +00:00
2026-11-18 17:00:18 +00:00
2026-11-08 17:09:24 +00:00
2026-11-03 03:14:57 +00:00
2026-11-18 17:00:18 +00:00
2026-11-03 01:40:07 +00:00
2026-11-17 18:47:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-08 14:26:14 +00:00
2026-11-18 17:00:18 +00:00
2026-11-06 23:55:54 +00:00
2026-11-02 14:49:46 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 16:45:06 +00:00
2026-11-02 14:49:46 +00:00
2026-11-06 18:14:51 +00:00
2026-11-19 17:05:16 +00:00
2026-11-02 14:49:46 +00:00
2026-11-16 02:55:19 +00:00
2026-11-17 13:14:33 +00:00
2026-11-01 06:11:17 +00:00
2026-11-19 20:10:49 +00:00
2026-11-19 16:54:44 +00:00
2026-11-01 13:28:21 +00:00
2026-11-03 01:40:07 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 23:17:49 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 11:15:51 +00:00
2026-11-04 23:46:23 +00:00
2026-11-19 15:17:30 +00:00
2026-11-14 07:31:35 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 03:55:13 +00:00
2026-11-19 17:05:16 +00:00
2026-11-18 12:57:24 +00:00
2026-11-05 19:27:19 +00:00
2026-11-05 22:23:20 +00:00
2026-11-07 06:01:30 +00:00
2026-11-19 13:33:04 +00:00
2026-11-19 17:05:16 +00:00
2026-11-14 07:31:35 +00:00
2026-11-20 02:24:04 +00:00
2026-11-19 20:10:49 +00:00
2026-11-17 11:28:47 +00:00
2026-11-18 18:40:12 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 12:57:24 +00:00
2026-11-17 20:56:07 +00:00
2026-11-19 20:10:49 +00:00
2026-11-17 16:44:06 +00:00
2026-11-17 16:44:06 +00:00
2026-11-17 16:44:06 +00:00
2026-11-04 02:59:50 +00:00
2026-11-17 16:44:06 +00:00
2026-11-17 11:12:52 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-04 23:50:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-17 16:44:06 +00:00
2026-11-18 17:00:18 +00:00
2026-11-05 04:16:06 +00:00
2026-11-09 04:14:37 +00:00
2026-11-19 09:02:33 +00:00
2026-11-06 04:33:54 +00:00
2026-11-04 23:46:23 +00:00
2026-11-03 18:22:59 +00:00
2026-11-03 14:06:33 +00:00
2026-11-19 09:02:33 +00:00
2026-11-19 20:10:49 +00:00
2026-11-17 13:14:33 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 17:05:16 +00:00
2026-11-18 17:00:18 +00:00
2026-11-06 15:04:30 +00:00
2026-11-12 01:49:08 +00:00
2026-11-19 20:10:49 +00:00
2026-11-19 17:05:16 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 12:44:06 +00:00
2026-11-07 18:43:11 +00:00
2026-11-19 22:04:13 +00:00
2026-11-17 12:23:35 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-18 17:00:18 +00:00
2026-11-04 01:28:17 +00:00
2026-11-18 22:33:08 +00:00
2026-11-01 06:11:17 +00:00
2026-11-20 02:24:04 +00:00
2026-11-13 23:46:15 +00:00
2026-11-18 17:00:18 +00:00
2026-11-19 08:11:34 +00:00
2026-11-18 17:00:18 +00:00