mirror of
https://github.com/garrytan/gstack.git
synced 2026-06-03 00:28:02 +02:00
Garry Tan
62024d114c
* fix(make-pdf): emoji font fallback in print CSS Emoji code points rendered as .notdef tofu (▯) because the body and @top-center font stacks had no emoji family for Chromium to fall back to. Add SANS_STACK / CJK_STACK / EMOJI_FAMILIES constants (one source of truth per family list) and append the emoji families before the generic sans-serif in the two stacks that can hold emoji. The @bottom-* boxes hold counters / a fixed CONFIDENTIAL string, so they share SANS_STACK without emoji. Non-emoji output is byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(setup): auto-install color-emoji font on Linux macOS and Windows ship a color-emoji font; most Linux distros/containers ship none, so make-pdf emits tofu there. ensure_emoji_font() best-effort installs fonts-noto-color-emoji (apt, with dnf/pacman/apk fallbacks) and refreshes the fontconfig cache. Hardened: Linux-only guard, GSTACK_SKIP_FONTS escape hatch, fc-match color=True detection (the broad fc-list query false-matched LastResort), sudo -n so a password prompt fails fast instead of hanging, DEBIAN_FRONTEND=noninteractive, timeout 30 on apt update, and fc-cache under sudo. Warns instead of failing. After a fresh install, refresh_browse_daemon_for_fonts() runs 'browse stop' so the next render spawns a Chromium that sees the new font (font fallback is process-cached). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(make-pdf): emoji render gate (pdffonts + pixel proof) pdftotext is a false oracle for emoji: Skia preserves the Unicode in the text cluster even when the glyph drew as .notdef tofu, so extraction passes on a broken render. The gate instead asserts (1) pdffonts shows an emoji family embedded and (2) pdftoppm rasterizes the page to color (measured ~1650 saturated pixels vs ~0 for tofu). pdfimages is not used: macOS embeds color emoji as Type 3 fonts, so it lists nothing even on a correct render. Adds resolvePopplerTool() (DRY resolver, returns null for clean skips) and a fixture exercising FE0F variation-selector emoji. Skips cleanly when poppler tools or a color-emoji font are unavailable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci(make-pdf): install emoji font + run emoji gate on Ubuntu Install fonts-noto-color-emoji before Chromium launches on the Ubuntu leg (macOS already ships Apple Color Emoji), refresh fontconfig, and log the fc-match result. Run the whole make-pdf/test/e2e/ dir so the emoji gate runs alongside the combined-features copy-paste gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * harden(make-pdf): emoji gate + font install per adversarial review Codex adversarial pass on the implementation diff flagged five robustness gaps, all fixed here: - emoji-gate skipped green in CI when poppler/font prerequisites were absent, which could let the tofu regression ship behind a green build. Missing prerequisites are now a HARD FAILURE when process.env.CI is set; local dev still skips cleanly. - execFileSync children (make-pdf, pdffonts, pdftoppm, fc-match) had no timeout; a wedged binary or hostile GSTACK_*_BIN override could hang the job past Bun's test timeout. Each child now has a 25s ceiling. - PPM parser trusted header tokens blindly; malformed/variant output gave a silently-wrong count. Now validates magic/dimensions/maxval and pixel-buffer length, handles header comments, throws a hard diagnostic on mismatch. - predictable /tmp paths were collision/symlink-prone; now mkdtempSync under /tmp (kept under /tmp for browse's validateOutputPath allowlist). - only apt-get update was timeout-wrapped; dnf/pacman/apk installs and apt install can hang on locks/mirrors. All package installs now timeout-bound. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump version and changelog (v1.52.2.0) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(make-pdf): document color-emoji font requirement + GSTACK_SKIP_FONTS Extend the Linux font note to cover the color-emoji font that make-pdf emoji rendering needs: setup auto-installs fonts-noto-color-emoji, the print CSS falls back through Apple/Segoe/Noto emoji families, and GSTACK_SKIP_FONTS=1 opts out. Edit the .tmpl and regenerate SKILL.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
90 lines
2.8 KiB
YAML
90 lines
2.8 KiB
YAML
name: make-pdf copy-paste gate
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
paths:
|
|
- 'make-pdf/**'
|
|
- 'browse/src/meta-commands.ts'
|
|
- 'browse/src/write-commands.ts'
|
|
- 'browse/src/commands.ts'
|
|
- 'browse/src/cli.ts'
|
|
- 'scripts/resolvers/make-pdf.ts'
|
|
- 'package.json'
|
|
- '.github/workflows/make-pdf-gate.yml'
|
|
workflow_dispatch:
|
|
|
|
concurrency:
|
|
group: make-pdf-gate-${{ github.head_ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
gate:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: [ubicloud-standard-8, macos-latest]
|
|
# Windows is tolerant-mode — Xpdf / Poppler-Windows extraction
|
|
# differs enough from the Linux/macOS baseline that the strict
|
|
# exact-diff gate is unreliable. Enable once the normalized
|
|
# comparator proves tolerant enough (Codex round 2 #18).
|
|
#
|
|
# include:
|
|
# - os: windows-latest
|
|
# tolerant: true
|
|
|
|
runs-on: ${{ matrix.os }}
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: oven-sh/setup-bun@v2
|
|
with:
|
|
bun-version: latest
|
|
|
|
- name: Install dependencies
|
|
run: bun install --frozen-lockfile
|
|
|
|
- name: Install poppler (macOS)
|
|
if: matrix.os == 'macos-latest'
|
|
run: brew install poppler
|
|
|
|
- name: Install poppler-utils (Ubuntu)
|
|
if: matrix.os == 'ubicloud-standard-8'
|
|
run: sudo apt-get update && sudo apt-get install -y poppler-utils
|
|
|
|
# Install a color-emoji font BEFORE Chromium launches so the emoji render
|
|
# gate has a fallback font. macOS ships Apple Color Emoji already.
|
|
- name: Install color-emoji font (Ubuntu)
|
|
if: matrix.os == 'ubicloud-standard-8'
|
|
run: |
|
|
sudo apt-get install -y fonts-noto-color-emoji
|
|
fc-cache -f || true
|
|
fc-match -f '%{family[0]}\t%{color}\n' ':lang=und-zsye:charset=1F600' || true
|
|
|
|
- name: Install Playwright Chromium
|
|
run: bunx playwright install chromium
|
|
|
|
- name: Build binaries
|
|
run: bun run build
|
|
|
|
- name: ad-hoc codesign (Apple Silicon)
|
|
if: matrix.os == 'macos-latest'
|
|
run: |
|
|
for bin in browse/dist/browse browse/dist/find-browse design/dist/design make-pdf/dist/pdf; do
|
|
codesign --remove-signature "$bin" 2>/dev/null || true
|
|
codesign -s - -f "$bin" || true
|
|
done
|
|
|
|
- name: Log toolchain versions
|
|
run: |
|
|
echo "OS: ${{ matrix.os }}"
|
|
bun --version
|
|
which pdftotext && pdftotext -v 2>&1 | head -1 || true
|
|
|
|
- name: Run make-pdf unit tests
|
|
run: bun test make-pdf/test/*.test.ts
|
|
|
|
- name: Run E2E gates (combined-features copy-paste + emoji render)
|
|
env:
|
|
BROWSE_BIN: ${{ github.workspace }}/browse/dist/browse
|
|
run: bun test make-pdf/test/e2e/
|