mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-01 19:25:10 +02:00
Garry Tan
a4a181ca92
* feat: extend gstack-diff-scope with SCOPE_MIGRATIONS, SCOPE_API, SCOPE_AUTH
Three new scope signals for Review Army specialist activation:
- SCOPE_MIGRATIONS: db/migrate/, prisma/migrations/, alembic/, *.sql
- SCOPE_API: *controller*, *route*, *endpoint*, *.graphql, openapi.*
- SCOPE_AUTH: *auth*, *session*, *jwt*, *oauth*, *permission*, *role*
* feat: add 7 specialist checklist files for Review Army
- testing.md (always-on): coverage gaps, flaky patterns, security enforcement
- maintainability.md (always-on): dead code, DRY, stale comments
- security.md (conditional): OWASP deep analysis, auth bypass, injection
- performance.md (conditional): N+1 queries, bundle impact, complexity
- data-migration.md (conditional): reversibility, lock duration, backfill
- api-contract.md (conditional): breaking changes, versioning, error format
- red-team.md (conditional): adversarial analysis, cross-cutting concerns
All use standard header with JSON output schema and NO FINDINGS fallback.
* feat: Review Army resolver — parallel specialist dispatch + merge
New resolver in review-army.ts generates template prose for:
- Stack detection and specialist selection
- Parallel Agent tool dispatch with learning-informed prompts
- JSON finding collection, fingerprint dedup, consensus highlighting
- PR quality score computation
- Red Team conditional dispatch
Registered as REVIEW_ARMY in resolvers/index.ts.
* refactor: restructure /review template for Review Army
- Replace Steps 4-4.75 with CRITICAL pass + {{REVIEW_ARMY}}
- Remove {{DESIGN_REVIEW_LITE}} and {{TEST_COVERAGE_AUDIT_REVIEW}}
(subsumed into Design and Testing specialists respectively)
- Extract specialist-covered categories from checklist.md
- Keep CRITICAL + uncovered INFORMATIONAL in main agent pass
* test: Review Army — 14 diff-scope tests + 7 E2E tests
- test/diff-scope.test.ts: 14 tests for all 9 scope signals
- test/skill-e2e-review-army.test.ts: 7 E2E tests
Gate: migration safety, N+1 detection, delivery audit,
quality score, JSON findings
Periodic: red team, consensus
- Updated gen-skill-docs tests for new review structure
- Added touchfile entries and tier classifications
* docs: update SELF_LEARNING_V0.md with Release 2 status + Release 2.5
Mark Release 2 (Review Army) as in-progress. Add Release 2.5 for
deferred expansions (E1 adaptive gating, E3 test stubs, E5 cross-review
dedup, E7 specialist tracking).
* chore: bump version and changelog (v0.14.3.0)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
49 lines
2.2 KiB
Markdown
49 lines
2.2 KiB
Markdown
# API Contract Specialist Review Checklist
|
|
|
|
Scope: When SCOPE_API=true
|
|
Output: JSON objects, one finding per line. Schema:
|
|
{"severity":"CRITICAL|INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"api-contract","summary":"...","fix":"...","fingerprint":"path:line:api-contract","specialist":"api-contract"}
|
|
If no findings: output `NO FINDINGS` and nothing else.
|
|
|
|
---
|
|
|
|
## Categories
|
|
|
|
### Breaking Changes
|
|
- Removed fields from response bodies (clients may depend on them)
|
|
- Changed field types (string → number, object → array)
|
|
- New required parameters added to existing endpoints
|
|
- Changed HTTP methods (GET → POST) or status codes (200 → 201)
|
|
- Renamed endpoints without maintaining the old path as a redirect/alias
|
|
- Changed authentication requirements (public → authenticated)
|
|
|
|
### Versioning Strategy
|
|
- Breaking changes made without a version bump (v1 → v2)
|
|
- Multiple versioning strategies mixed in the same API (URL vs header vs query param)
|
|
- Deprecated endpoints without a sunset timeline or migration guide
|
|
- Version-specific logic scattered across controllers instead of centralized
|
|
|
|
### Error Response Consistency
|
|
- New endpoints returning different error formats than existing ones
|
|
- Error responses missing standard fields (error code, message, details)
|
|
- HTTP status codes that don't match the error type (200 for errors, 500 for validation)
|
|
- Error messages that leak internal implementation details (stack traces, SQL)
|
|
|
|
### Rate Limiting & Pagination
|
|
- New endpoints missing rate limiting when similar endpoints have it
|
|
- Pagination changes (offset → cursor) without backwards compatibility
|
|
- Changed page sizes or default limits without documentation
|
|
- Missing total count or next-page indicators in paginated responses
|
|
|
|
### Documentation Drift
|
|
- OpenAPI/Swagger spec not updated to match new endpoints or changed params
|
|
- README or API docs describing old behavior after changes
|
|
- Example requests/responses that no longer work
|
|
- Missing documentation for new endpoints or changed parameters
|
|
|
|
### Backwards Compatibility
|
|
- Clients on older versions: will they break?
|
|
- Mobile apps that can't force-update: does the API still work for them?
|
|
- Webhook payloads changed without notifying subscribers
|
|
- SDK or client library changes needed to use new features
|