mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-01 19:25:10 +02:00
Garry Tan
a4a181ca92
* feat: extend gstack-diff-scope with SCOPE_MIGRATIONS, SCOPE_API, SCOPE_AUTH
Three new scope signals for Review Army specialist activation:
- SCOPE_MIGRATIONS: db/migrate/, prisma/migrations/, alembic/, *.sql
- SCOPE_API: *controller*, *route*, *endpoint*, *.graphql, openapi.*
- SCOPE_AUTH: *auth*, *session*, *jwt*, *oauth*, *permission*, *role*
* feat: add 7 specialist checklist files for Review Army
- testing.md (always-on): coverage gaps, flaky patterns, security enforcement
- maintainability.md (always-on): dead code, DRY, stale comments
- security.md (conditional): OWASP deep analysis, auth bypass, injection
- performance.md (conditional): N+1 queries, bundle impact, complexity
- data-migration.md (conditional): reversibility, lock duration, backfill
- api-contract.md (conditional): breaking changes, versioning, error format
- red-team.md (conditional): adversarial analysis, cross-cutting concerns
All use standard header with JSON output schema and NO FINDINGS fallback.
* feat: Review Army resolver — parallel specialist dispatch + merge
New resolver in review-army.ts generates template prose for:
- Stack detection and specialist selection
- Parallel Agent tool dispatch with learning-informed prompts
- JSON finding collection, fingerprint dedup, consensus highlighting
- PR quality score computation
- Red Team conditional dispatch
Registered as REVIEW_ARMY in resolvers/index.ts.
* refactor: restructure /review template for Review Army
- Replace Steps 4-4.75 with CRITICAL pass + {{REVIEW_ARMY}}
- Remove {{DESIGN_REVIEW_LITE}} and {{TEST_COVERAGE_AUDIT_REVIEW}}
(subsumed into Design and Testing specialists respectively)
- Extract specialist-covered categories from checklist.md
- Keep CRITICAL + uncovered INFORMATIONAL in main agent pass
* test: Review Army — 14 diff-scope tests + 7 E2E tests
- test/diff-scope.test.ts: 14 tests for all 9 scope signals
- test/skill-e2e-review-army.test.ts: 7 E2E tests
Gate: migration safety, N+1 detection, delivery audit,
quality score, JSON findings
Periodic: red team, consensus
- Updated gen-skill-docs tests for new review structure
- Added touchfile entries and tier classifications
* docs: update SELF_LEARNING_V0.md with Release 2 status + Release 2.5
Mark Release 2 (Review Army) as in-progress. Add Release 2.5 for
deferred expansions (E1 adaptive gating, E3 test stubs, E5 cross-review
dedup, E7 specialist tracking).
* chore: bump version and changelog (v0.14.3.0)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
52 lines
2.5 KiB
Markdown
52 lines
2.5 KiB
Markdown
# Performance Specialist Review Checklist
|
|
|
|
Scope: When SCOPE_BACKEND=true OR SCOPE_FRONTEND=true
|
|
Output: JSON objects, one finding per line. Schema:
|
|
{"severity":"CRITICAL|INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"performance","summary":"...","fix":"...","fingerprint":"path:line:performance","specialist":"performance"}
|
|
If no findings: output `NO FINDINGS` and nothing else.
|
|
|
|
---
|
|
|
|
## Categories
|
|
|
|
### N+1 Queries
|
|
- ActiveRecord/ORM associations traversed in loops without eager loading (.includes, joinedload, include)
|
|
- Database queries inside iteration blocks (each, map, forEach) that could be batched
|
|
- Nested serializers that trigger lazy-loaded associations
|
|
- GraphQL resolvers that query per-field instead of batching (check for DataLoader usage)
|
|
|
|
### Missing Database Indexes
|
|
- New WHERE clauses on columns without indexes (check migration files or schema)
|
|
- New ORDER BY on non-indexed columns
|
|
- Composite queries (WHERE a AND b) without composite indexes
|
|
- Foreign key columns added without indexes
|
|
|
|
### Algorithmic Complexity
|
|
- O(n^2) or worse patterns: nested loops over collections, Array.find inside Array.map
|
|
- Repeated linear searches that could use a hash/map/set lookup
|
|
- String concatenation in loops (use join or StringBuilder)
|
|
- Sorting or filtering large collections multiple times when once would suffice
|
|
|
|
### Bundle Size Impact (Frontend)
|
|
- New production dependencies that are known-heavy (moment.js, lodash full, jquery)
|
|
- Barrel imports (import from 'library') instead of deep imports (import from 'library/specific')
|
|
- Large static assets (images, fonts) committed without optimization
|
|
- Missing code splitting for route-level chunks
|
|
|
|
### Rendering Performance (Frontend)
|
|
- Fetch waterfalls: sequential API calls that could be parallel (Promise.all)
|
|
- Unnecessary re-renders from unstable references (new objects/arrays in render)
|
|
- Missing React.memo, useMemo, or useCallback on expensive computations
|
|
- Layout thrashing from reading then writing DOM properties in loops
|
|
- Missing loading="lazy" on below-fold images
|
|
|
|
### Missing Pagination
|
|
- List endpoints that return unbounded results (no LIMIT, no pagination params)
|
|
- Database queries without LIMIT that grow with data volume
|
|
- API responses that embed full nested objects instead of IDs with expansion
|
|
|
|
### Blocking in Async Contexts
|
|
- Synchronous I/O (file reads, subprocess, HTTP requests) inside async functions
|
|
- time.sleep() / Thread.sleep() inside event-loop-based handlers
|
|
- CPU-intensive computation blocking the main thread without worker offload
|