mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-09 22:48:57 +02:00
* feat: add optional Memorable workflow memory (cherry picked from commit6bd5d477b2) * fix: refuse the second registration, and say what leaves the machine Two things the first cut got wrong. Memorable's own installer registers the same UserPromptSubmit hook, under its own name and outside gstack's table. `memorable start`, `memorable setup` and `memorable install-hooks` all do it, and that is the documented way to install the CLI, so on most machines it is already there before gstack is asked. Registering ours beside it ran the same command twice on every prompt: context injected twice, and the session captured twice against the user's own extraction allowance. `enable` now looks for it and refuses, naming the entry and the file it lives in; `status` says who registered it rather than reporting none. Matched on the command rather than on a tag, for the reason the hook table already gives: Claude Code rewrites settings and private tags do not survive it. The removal instruction says to delete the entry by hand because Memorable has no command that removes its own hook. `uninstall-hooks` is not a command in 0.5.18; it answers "unknown command". The README said "Memorable, not gstack, owns the captured data and any network access", which answers the question by pointing away from it. It now carries a per-command table of exactly what leaves the machine, in the shape the adopted gbrain section uses, and it is explicit that the hook makes no network call of its own, that every row is the third-party CLI acting under its own consent, and that `gstack-egress` will therefore not show any of it. Under it, the split between what gstack pin-tests (the gating and the wiring) and what is Memorable's claim (storage, sending, and what disable and forget erase). The CHANGELOG entry is removed. This file has never carried an [Unreleased] heading; every entry is a version and a date, written at release. The text is in the pull request for whoever cuts the next one. Three tests added: enable refuses and touches neither consent nor settings when Memorable already holds the hook, status names that registration, and a foreign UserPromptSubmit hook is not mistaken for Memorable's. (cherry picked from commite0899afa8c) * docs: a guide for the Memorable bridge, in the gbrain-sync shape README carries the section and the egress table; this is the page it links to for anyone who wants the whole thing. Same shape as docs/gbrain-sync.md, which is the closest thing in the repo: an optional integration whose interesting questions are all about what leaves the machine and how to turn it off. What it covers that the README cannot at that length: that the hook sees every Claude Code prompt rather than only the ones a skill produced; that capture is a separate consent from this bridge, so turning the bridge off does not turn capture off; what to do when Memorable has already registered the hook itself, which is the common case because its own installer does it; and why the hook has no loud failure path. The egress table is repeated here rather than linked, because the sentence it is answering ("what does this send") is the one somebody arrives on this page already asking. Co-authored-by: Advaiyt Sane <advaiyt.sane@gmail.com> Co-authored-by: Nikhil Krishnaswamy <krishnaswamynikhil@gmail.com> (cherry picked from commit5c108cc0f7) * feat(settings-hook): identity-aware remove-source + read-only list-items remove-source used to inspect only entries still carrying the _gstack_source tag. Claude Code strips that tag when it rewrites settings.json, so an off switch built on remove-source alone silently no-oped on exactly the entries it was written for. Removal is now driven by KNOWN_HOOKS identity for the requested source (tagged or not), keeps the tagged-single-item legacy-stray rule, never touches another source's items, and leaves entries with nothing of ours byte-identical. list-items is the read-only view of the same identity table: one JSON string literal per matching hook command, filters (--owned-by, --command-regex as a JavaScript RegExp) applied inside the JS, empty stdout for no match, and the mutating verbs' exit codes (1 usage, 3 unparseable settings, 4 unexpected shape) so callers can decide mutations from its output without parsing raw command strings. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(config): memorable_recall consent key (on|off, default off, reject-and-preserve) The gstack-side gate for the Memorable UserPromptSubmit bridge. `on` lets a Claude Code hook hand every prompt to a third-party binary, so the key follows the codex_reviews rule: an invalid value is rejected and the stored value kept, never coerced in either direction. Registered in all four places gstack-config keeps in sync (annotated header, DEFAULTS table, the set validator, and both enumeration loops). Memorable's own capture consent (`memorable enable`) is a separate thing gstack never sets. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(hooks): memorable-user-prompt-hook.ts — consent gate, deny veto, HIGH-tier pre-scan, fail-closed receipt, trust envelope; runExternal in spawn-bin The PR's hook exec'd the vendor binary with the full environment and passed its stdout to Claude verbatim. It is now the house pattern: a fail-open bash shim over a .ts twin that (1) gates on the memorable_recall consent key, (2) skips repos whose trust policy is deny or read-only, (3) scans the prompt (raw bytes and decoded string leaves) and refuses to hand over a HIGH-tier credential shape, (4) writes a fail-closed egress receipt naming the local executable it ran, (5) spawns the vendor in its own process group with an allowlisted environment and group-kills it on timeout, (6) accepts only a string additionalContext back, caps it at 8 KiB on a UTF-8 boundary and wraps it in the trust envelope, and (7) records an `output-written` outcome after the stdout write completes. One deadline clock (4.5 s) undercuts Claude Code's 5 s kill and bounds both ledger writes through the new lockBudgetMs option on writeReceipt/writeOutcome (default unchanged). spawn-bin gains runExternal for external executables (detached group, stderr drained, stdin EPIPE handled, stdout capped, win32 refused). The wiring test pins the sink fail-closed and sweeps hosts/. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): canonical hook path, no vendor consent, --timeout 5, identity-based status, verified disable, lifecycle lock enable used to bake the hook path from whatever tree the CLI ran in and to run the vendor's own `memorable enable` (its consent for storing AND uploading session traces) before registering anything. It now resolves the canonical install like setup does and refuses when that install does not carry this bridge (version and hook-twin check), registers through the canonical hook manager with --timeout 5, records gstack's own consent in memorable_recall, never executes the vendor, and restores the captured prior state if consent cannot be recorded. disable flips the gate first, removes the entry by identity (tag or no tag), verifies both states and reports partial failure instead of a blended success. status reads only: resolution path, gate, registration by identity (gstack / vendor-own / both / unknown), mismatch lines, receipt count, recent hook errors. enable and disable serialise under a lock with stale takeover. Windows is refused (TODOS.md D21). Exit codes mirror the hook manager (3/4/5). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(setup): --no-team sweep keeps the opt-in gstack-memorable hook `./setup --no-team` finishes its teardown with `prune-stale --all`, which removes every KNOWN_HOOKS item. The Memorable bridge hook is a user-registered opt-in unrelated to team mode, exactly like verify-gate, so it joins the sweep exclusion list. The verify-gate pin now accepts the comma-extended list; a schema-aware case proves the exclusion keeps both opt-ins (tagged or tag-stripped) while the uninstall sweep still removes them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(uninstall): named gstack-memorable arm, vendor-consent notice, honest kept config The identity sweep already removed the Memorable bridge hook as an unnamed stray. It now has a named arm like every other source, so the summary says what went, and says plainly that Memorable's own consent (if the user granted it) is theirs to revoke. Under --keep-state the kept config is set memorable_recall=off so it never claims a hook that is gone. The canonical-paths pins cover the sixth KNOWN_HOOKS row and the new uninstall source. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(egress): memorable-recall row in gstack-egress grants `gstack-egress grants` promises every standing consent in force with the command that revokes it. The Memorable bridge's memorable_recall key is one, so it gets a row: off by default, granted only when `gstack-memorable enable` set it, revoked by `gstack-memorable disable`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): accurate bridge guide; README row, Docs table, privacy pointer; PROJECT_STRUCTURE The README section becomes one row in the Standalone binaries table (the shape every other binary uses) plus a Docs-table row and one Privacy bullet saying that optional third-party bridges are off by default and receipted. The guide now separates the two consents, says what gstack hands to the vendor binary and what the receipt can and cannot attest, attributes every statement about the vendor's network activity to the vendor, describes the hook manager accurately (identity via KNOWN_HOOKS, list-items vs list-sources, rollback is whole-file), states the Claude Code hot-reload behaviour, adds a troubleshooting runbook, and keeps the contributors' credit in the CHANGELOG idiom. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(todos): Memorable bridge follow-ups Filed from the CEO and eng reviews of the bridge fix-up: the generic third-party hook seam, Windows support (deferred whole), the envelope kind parameter, a vendor payload-minimization contract, a latency and timeout revisit, resolver and canonical-root consolidation, a non-interactive MEDIUM-tier redaction policy for hooks, and adopting list-items at setup's plan-tune check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(settings-hook): list-items --owned-by with --command-regex intersects When both filters are given, an item must satisfy both: owned by the requested source AND matching the pattern. Before, the regex branch skipped every owned row, so the combination could never match. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): compat_check reads list-items output before grepping Under pipefail, piping the probe straight into grep -q let a non-zero probe exit mask the match, so a hook manager without list-items was sometimes reported as compatible. Capture the output, then grep. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: coverage for the memorable bridge (remove-source regression for every KNOWN_HOOKS source) - settings-hook: identity removal pinned for each source in KNOWN_HOOKS; list-items unknown flag and combined --owned-by/--command-regex - gstack-memorable: enable/disable failure paths (lock give-up exit 5 with the test-only lock timeout override, consent-write failures guarded by canRevokeWrites, canonical-version mismatch, no-bun status) - hook: non-object JSON, missing cwd, non-ASCII bytes, held-open stdin, shim without bun, stripControl, resolveVendor, runExternal ENOENT - egress-receipt: lockBudgetMs 0 and writeOutcome on garbage input - uninstall: no memorable entry present reports nothing removed Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): gbrain backend note and the settings-rewrite race Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * perf(redact-engine): line/col by binary search over a per-scan line index lineColAt walked the input from offset 0 for every finding, so a match-dense input (a pasted log full of emails and IPs) cost O(findings x bytes): 128 KiB took ~400 ms and 900 KiB tens of seconds. The line starts are now indexed once per scan, on the first finding, and each finding is a binary search. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(gbrain-repo-policy-client): repoPolicyTier accepts a spawn timeout The policy script spawn was fixed at 10 s, more than twice the memorable hook's whole budget. Callers on their own deadline pass what they can afford; a timeout reads as unreadable and polarity stays the caller's. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(spawn-bin): runExternal resolves on the child's exit, keeps stdin errors advisory - A vendor that exits 0 but leaves a background child holding its pipes was held to the deadline, group-killed and reported as a timeout with its answer dropped. 'exit' now starts a short stdout drain, then resolves with the real exit code and kills whatever still holds the group. - EPIPE on the child's stdin (it answered before reading a large input) is reported as stdinError, separate from error, so a delivered answer is not classified as a spawn failure. - Stdio streams are destroyed and the child unref'd on resolve so a straggler cannot pin the hook process; tail/grace/drain sizes are named constants. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): memorable hook closes the review army's gaps - Vendor failures are logged even with empty stderr (a silently hanging vendor taxed every prompt invisibly); the stderr tail is withheld when the redaction engine finds a credential or PII shape in it; hook-errors.log is created 0600. - Trust-policy veto fails closed when git cannot run or answer in time (it read as 'no remote' before); the policy script spawn is bounded by the hook's clock; a payload cwd that is not a directory falls back. - Each secret scan is admitted by the deadline clock (the engine's cost grows with match density); stdin is decoded once. - The pre-spawn gate re-check logs a config failure instead of swallowing it; an incomplete stdin read is named as such, not as 'not JSON'. - Carriage returns are stripped with the other controls. - The vendor env allowlist adds the standard proxy, TLS and XDG variables so a vendor behind a corporate proxy or private CA still reaches its service. - A stdin EPIPE on a delivered answer is recorded in the outcome, not treated as a spawn error. - Stage caps and the truncation marker are named constants; a test-only GSTACK_MEMORABLE_TEST_BUDGET_MS can shorten (never widen) the budget. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): lock staleness from the directory mtime; honest messages - A contender that looked between the holder's mkdir and its ts write read a missing ts as 0, called the lock stale and reclaimed it; staleness now comes from the lock directory's own mtime (the settings-hook idiom). - The ensure-event failure is no longer labelled 'warning'; the consent-write rollback message says what was actually kept; a removal that left no entry is reported on stdout, not as an error; receipts are counted from the filtered JSON array, not a formatting artefact; the resolution order and lock tuning are named once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(uninstall): memorable_recall goes off whether or not state is kept gstack-config resolves its root through GSTACK_STATE_ROOT/GSTACK_HOME, which can differ from the STATE_DIR uninstall removes; a full uninstall could leave memorable_recall=on in a config that survived. Flipped only when currently on. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: pin the review-army fixes for the memorable bridge Nonce-scoped orphan checks (the system-wide ps grep could see another shard's sleeper); exit-with-lingering-grandchild; advisory stdin EPIPE; withheld stderr; vendor timeout logged with empty stderr; CR stripping; budget seam; rate-limit expiry and 0600 log; unreadable policy store fails closed; file-as-cwd fallback; mtime-based lock staleness and the mkdir gap. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): vendor environment allowlist and stderr policy; two follow-ups Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): memorable hook second-pass review fixes - Trust-policy lookup fails closed on any git failure that is not 'no such remote' or 'not a git repository' (a corrupt or unreadable .git/config and dubious ownership exit 128 and used to read as 'no remote'). - pickAdditionalContext takes the first complete top-level JSON object, so a vendor whose background helper appends a line to stdout (or prints a banner first) does not lose its answer. - The hook-errors.log rate limiter keys on a stable string (a vendor's timestamped stderr no longer defeats it); the log is chmod 0600 on every append because sibling hooks create the same file without a mode. - Scan admission is sized by payload bytes (scan() is uninterruptible). - The receipt payload class is a stable token; the prose moved to the docs. - Header, constants and comments match the behaviour (silent skips vs logged refusals; HIGH/MEDIUM withholding; STAGE_CAP_MS scope; runExternal in the spawn-bin header; the ledger lock budget doc). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): stale-lock takeover by atomic rename; comments match behaviour Two contenders that both saw a stale lock could both reclaim it with rm -rf; the settings-hook idiom (mv to a private name, exactly one winner) is used instead. The hook-manager fallback comment now says every verb falls back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: second-pass coverage for the memorable bridge Policy lookup outcomes (plain dir, repo without policy, corrupt .git/config fails closed); repoPolicyTier timeoutMs; line/col at line starts, after blank lines, CRLF and first char; tolerant first-JSON-object parsing; keyed rate limit; uninstall never creates a config just to say off and flips consent in a GSTACK_STATE_ROOT outside the removed state dir. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): silent skips vs logged refusals; payload class token; D21/D24 anchors Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): memorable hook survives host termination and brace-bearing banners - The bash shim runs bun as a job and forwards SIGTERM/SIGINT/SIGHUP (bash holds a signal until a foreground child exits); the .ts kills the in-flight vendor's process group on the way out (runExternal exposes the group kill through onSpawn), so a hook the host terminates cannot leave the vendor running with the prompt on its stdin. - The tolerant stdout parser tries every complete top-level object (bounded) and takes the first carrying a string additionalContext, so a banner with braces or quotes, or a progress object, no longer costs the answer. - git runs with LC_ALL=C and the not-a-repository check is anchored to the start of its message: a localized git or a repository path containing the phrase can no longer flip the lookup. - The rate limiter remembers up to 32 live keys, so alternating failures cost two lines, not one per prompt. - Unicode format characters (bidi overrides, zero-width spaces) are stripped from vendor text at egress; the zero-width joiner stays for emoji. - A killed child (timeout, ENOBUFS) resolves on exit without the stdout drain, and the post-kill grace is 100 ms, so the timeout outcome fits the reserve. - The ledger size warning, which the host discards from an exit-0 hook's stderr, is logged where status looks. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): failed stale-lock takeover reaches the give-up; disable runs without gstack-config; status shows ledger size Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: host termination kills the vendor group; brace banners, decoys and format characters; non-reclaimable stale lock gives up; ledger line in status Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): the vendor dies with a terminated hook Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: deterministic stdin EPIPE case for runExternal (child closes stdin, stays alive) Under parallel shard load a child that merely exits fast raced the write and the EPIPE was not always observed; closing the read end first makes it so. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(hooks): outside-model review fixes for the memorable hook and runExternal - Nothing in the vendor's process group outlives the call: the group is killed on every resolve, the clean 'close' path included (a helper the vendor forked with redirected stdio ran on unsupervised before). - A child that already exited when the deadline fires keeps its result; the deadline only ends the drain instead of rewriting a completed exit as a timeout. - The decoded-leaf scan reports when its node/depth bound cut the walk short and the hook refuses the hand-off as unscanned; object keys are scanned too. - git for the trust-policy lookup runs without inherited GIT_* selectors (GIT_DIR, GIT_WORK_TREE, GIT_CONFIG_*), so it inspects the session's repository and no other; a host cancellation kills that git as well. - An unmatched brace in a vendor banner no longer hides the answer after it. - The stderr tail is scanned whole before it is cropped for the log, so a credential's prefix cannot be cropped away from its secret half. - The vendor override reads an empty GSTACK_MEMORABLE_BIN as unset, exactly as bin/gstack-memorable does, so enable checks the binary the hook runs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): stale-lock reclaim checks the inode it judged and the owner's liveness; status reports a failed receipt query as unknown Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(uninstall): revoke memorable_recall independently of the hook manager and name a failed revocation Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: group kill on clean close, walk exhaustion refused, GIT_DIR cannot bypass the deny, unmatched-brace banner, whole-tail scan, empty-override parity, uninstall revocation without the hook manager Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs(memorable): the process-group guarantee and its setsid boundary Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(release): v1.83.0.0 — Memorable recall bridge, identity-aware hook removal, faster redaction line/col CHANGELOG entry for the Memorable workflow-memory bridge (opt-in, off by default, Claude Code only), the identity-aware remove-source and read-only list-items in the hook manager, the memorable-recall egress sink, runExternal, lockBudgetMs, and the binary-search line/col index in the redaction engine. No migration. Contributed by @AdvaiytSane and @NIkhil-cmd-cmd (#2831). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: stdin EPIPE observation is scheduling-dependent under shard load; pin the invariant instead A delivered answer is never reclassified as a spawn error; when the EPIPE is observed it is reported as stdinError. Whether it is observed before the child's exit resolves the call is not something the test can force. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * docs: list the memorable-recall sink among the fail-closed egress sinks CLAUDE.md and ARCHITECTURE.md enumerate the receipt sinks that refuse to send when the ledger cannot be written; the Memorable bridge's per-prompt hand-off is pinned fail-closed in test/egress-receipt-wiring.test.ts but was missing from both lists. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: memorable bridge tests pass on a runner that enforces file modes; scanner-proof key fixture - The consent-write-failure tests make the state dir read-only, which also blocked the bridge lock directory (exit 5 before the path under test); the locks dir is pre-created so only the consent write fails. - The unreadable-store test leaves a 0600 directory behind (the policy script chmods the store path); cleanup restores the search bit and the suite's afterEach reopens directories before removing. - The AWS-key-shaped fixture is built by concatenation, as every sibling test does, so the CI credential gate does not read it as a live key. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(gstack-memorable): name an unwritable state directory when the lock cannot be created Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: AdvaiytSane <advaiyt.sane@gmail.com> Co-authored-by: Nikhil Krishnaswamy <krishnaswamynikhil@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
233 lines
12 KiB
Markdown
233 lines
12 KiB
Markdown
# Workflow memory with Memorable (optional, third party)
|
|
|
|
The third time you ask Claude Code to do the same shape of work, it starts
|
|
from nothing again. It re-reads the same files, re-runs the same searches, and
|
|
arrives at the fix it already wrote last month. **Memorable** is a third-party
|
|
CLI that records how a task was done and hands that back the next time you ask
|
|
for something close to it.
|
|
|
|
gstack does not install it, bundle it, or depend on it. What gstack adds is a
|
|
**bridge**: Memorable's `UserPromptSubmit` hook registered through gstack's own
|
|
hook manager, wrapped in the guarantees gstack gives every other off-machine
|
|
sink. It is off until you turn it on, Claude Code is the only host it works
|
|
with, and it is not available on Windows yet.
|
|
|
|
## What you get
|
|
|
|
- Before each prompt, the hook asks Memorable whether a past session already
|
|
solved something close to this and, if so, injects that procedure as
|
|
clearly labelled reference data.
|
|
- An explicit gstack-side consent key, `memorable_recall`, off by default and
|
|
listed by `gstack-egress grants` with its revoke command.
|
|
- A receipt for every prompt handed to the vendor binary, before the hand-off
|
|
(`gstack-egress list --sink memorable-recall`). No receipt, no hand-off.
|
|
- A HIGH-tier secret pre-scan: a prompt carrying a live-shaped credential is
|
|
never handed over.
|
|
- A trust envelope and an 8 KiB cap on whatever comes back, and the vendor can
|
|
never block a prompt or speak as gstack.
|
|
- The vendor runs in an allowlisted environment (no API keys from your
|
|
session) inside its own process group, and that whole group is killed when
|
|
the hook finishes, times out, or is terminated by Claude Code mid-flight.
|
|
A process the vendor deliberately detaches into its own session (`setsid`)
|
|
is outside that group and outside this guarantee; that is a choice visible
|
|
in the vendor's own behaviour, not something gstack can prevent.
|
|
- Registration at the stable install, healing on every `./setup`, survival of
|
|
`./setup --no-team`, removal by `gstack-uninstall`, and an off switch that
|
|
works even after Claude Code has rewritten `settings.json`.
|
|
|
|
## What this is not
|
|
|
|
- Not deterministic replay. It is recalled guidance the model may ignore.
|
|
- Not related to Aside or to browser automation.
|
|
- Not a gstack feature with gstack's guarantees past the process boundary.
|
|
Everything the `memorable` binary does after gstack hands it a prompt belongs
|
|
to a closed-source npm package from another vendor.
|
|
|
|
## Two consents, neither implies the other
|
|
|
|
| Consent | Who sets it | What it controls |
|
|
|---|---|---|
|
|
| `memorable_recall` (gstack) | `gstack-memorable enable` / `disable` | whether gstack's hook hands prompts to the vendor binary at all |
|
|
| Memorable's own consent | `memorable enable` / `disable` / `forget`, run by you | whether Memorable stores procedures and, per its docs, sends session traces to its extraction API |
|
|
|
|
gstack never runs the vendor's consent commands and never reads their state.
|
|
`gstack-memorable enable` prints them so you can run or inspect them yourself.
|
|
Turning the bridge off turns off gstack's hand-off; it does not change what
|
|
Memorable is allowed to do with what it already has.
|
|
|
|
## What gstack hands over, and what it can attest
|
|
|
|
| Command | What gstack hands to the vendor binary |
|
|
|---|---|
|
|
| `gstack-memorable status`, `enable`, `disable` | Nothing. They check that the binary exists; they never execute it. |
|
|
| the hook, on every prompt (gate on) | Claude Code's `UserPromptSubmit` JSON: `session_id`, `cwd`, `transcript_path`, `prompt`. The binary runs with your privileges, so it can read anything you can, including the transcript that path names. |
|
|
|
|
The receipt attests exactly those bytes (count and sha256) and names the
|
|
recipient gstack actually ran: `local:<path to the memorable executable>`. It
|
|
does not and cannot attest the vendor's network activity. Memorable's
|
|
documentation states that recall embeds a scrubbed task line through its API
|
|
only when the local lexical match misses, and that capture uploads tool names,
|
|
allowlisted argument fields and a 200-character task line. Those are the
|
|
vendor's claims. The bridge is tested against memorable-cli 0.5.18's hook
|
|
contract; other versions are the vendor's compatibility claim.
|
|
|
|
The binary's environment is an allowlist, not your session's: `PATH`, `HOME`,
|
|
user and shell names, locale (`LANG`, `LC_*`), temp directories, the standard
|
|
proxy and TLS variables (`HTTP_PROXY`, `HTTPS_PROXY`, `NO_PROXY`,
|
|
`SSL_CERT_FILE`, `SSL_CERT_DIR`, `NODE_EXTRA_CA_CERTS`), the `XDG_*`
|
|
directories, and every `MEMORABLE*` variable. No `ANTHROPIC_API_KEY`, no
|
|
`GSTACK_*`, no `CLAUDE_*` reaches it. Its stderr is kept out of
|
|
`hook-errors.log` whenever the redaction engine finds a HIGH- or MEDIUM-tier
|
|
shape in it (a credential, an email, a phone number), so a vendor that echoes
|
|
its input on an error cannot copy your prompt into a log. The receipt's
|
|
`payload_class` is the token `claude-user-prompt-json->local-vendor-cli`: the
|
|
prompt JSON, handed to the local vendor executable; the network destination is
|
|
unknown to gstack (Memorable states: its embed API, on a local recall miss).
|
|
|
|
The hook skips the hand-off silently (nothing was refused, so nothing is
|
|
logged) when the gate is off or `MEMORABLE=0` is set.
|
|
|
|
It refuses the hand-off, with one rate-limited line in
|
|
`~/.gstack/hook-errors.log`, when:
|
|
|
|
- the vendor binary is missing;
|
|
- the prompt carries a HIGH-tier credential shape (checked on the raw bytes
|
|
and on the decoded string values, so a JSON-escaped key does not slip by),
|
|
or is larger than 1 MiB;
|
|
- the repo's per-remote trust policy is `deny` or `read-only` (judged by the
|
|
session's working directory, so a session that touches other repositories
|
|
is not covered), or that policy could not be looked up at all (git could
|
|
not read the repository, the store is unreadable): the lookup fails closed;
|
|
- the receipt cannot be written, or the hook's 4.5 s budget cannot afford the
|
|
next step (the secret scan of a very large prompt, or the vendor spawn).
|
|
|
|
A receipt whose outcome is missing means the host killed the hook or the clock
|
|
ran out. Read it as unknown, never as success. An outcome of `output-written`
|
|
means gstack wrote enveloped context on its stdout for Claude Code to inject;
|
|
whether Claude used it is not something a hook can know.
|
|
|
|
## What gstack tests, and what is Memorable's claim
|
|
|
|
gstack tests the bridge in `test/gstack-memorable.test.ts`,
|
|
`test/memorable-user-prompt-hook.test.ts` and
|
|
`test/gstack-settings-hook-schema-aware.test.ts`, against a fake vendor: every
|
|
refusal above, the receipt-before-hand-off order, the envelope and cap, the
|
|
environment allowlist, the process-group kill, the identity-based removal
|
|
after Claude Code strips the tag, the sweep exclusion, the uninstall arm, and
|
|
the exit codes. Everything past the process boundary, what Memorable stores,
|
|
where, what it sends, and what `memorable disable` and `memorable forget`
|
|
erase, is Memorable's claim and not ours.
|
|
|
|
## Turning it on (three steps, the middle one is yours)
|
|
|
|
```bash
|
|
npm i -g memorable-cli # the CLI, from npm, not from gstack
|
|
memorable login && memorable enable # the vendor's account and the vendor's consent; only you can do these
|
|
gstack-memorable enable # gstack's gate + the hook, at the stable install
|
|
```
|
|
|
|
`enable` refuses, and changes nothing, when the vendor binary is missing, when
|
|
Memorable already registered its own hook (see below), when the stable install
|
|
does not carry this bridge (run `./setup` first), or when `settings.json`
|
|
cannot be read. Claude Code picks up the new hook within a few seconds on
|
|
current versions; if it does not fire, restart the session. Verify with:
|
|
|
|
```bash
|
|
gstack-memorable status
|
|
```
|
|
|
|
## If Memorable already registered the hook
|
|
|
|
`memorable install-hooks` and `memorable start` register the same
|
|
`UserPromptSubmit` hook under Memorable's own name, outside gstack's table
|
|
(`memorable enable` does not; only those two do). `enable` refuses in that case
|
|
rather than adding a second entry: two entries run the hook twice on every
|
|
prompt, injecting twice and capturing twice against your allowance.
|
|
|
|
To hand it to gstack instead, delete that entry from `~/.claude/settings.json`
|
|
and run `enable` again. Memorable has no command that removes its own hook.
|
|
|
|
## Turning it off
|
|
|
|
```bash
|
|
gstack-memorable disable
|
|
```
|
|
|
|
The gate goes off first, so the very next prompt is off even before the entry
|
|
is gone; a prompt already past the gate completes. Then gstack's entry is
|
|
removed by identity (tag or no tag), both results are verified, and any
|
|
partial failure is reported with a non-zero exit. Memorable's own consent and
|
|
whatever it stored are untouched: `memorable disable` stops capture,
|
|
`memorable forget` denies everything, and its own docs say what each erases.
|
|
|
|
The entry also comes out with `gstack-uninstall` (named in its summary) and
|
|
survives `./setup --no-team`, which only tears down team-mode hooks.
|
|
|
|
## If you run gbrain
|
|
|
|
Memorable can keep its procedures in your own gbrain database instead of its
|
|
local store (`memorable init gbrain`, per its docs). That changes where the
|
|
vendor stores things; it does not change anything about this bridge, which
|
|
only ever hands prompts to the local `memorable` binary. gstack's `/setup-gbrain`
|
|
and `/sync-gbrain` are unrelated to it.
|
|
|
|
## Troubleshooting
|
|
|
|
- **The hook never fires.** `gstack-memorable status` should show the gate
|
|
`on` and "registered by gstack". If it shows a mismatch line, follow it.
|
|
If everything looks right, restart Claude Code once. One known race: Claude
|
|
Code rewrites `settings.json` on its own schedule, and a rewrite that lands
|
|
during `enable` can drop the entry after gstack printed `registered`; the
|
|
hook manager is convergent, not exclusive, so `enable` again (it reports
|
|
`unchanged` or `registered`) and check `status`.
|
|
- **Nothing is ever recalled.** The hand-offs are happening if
|
|
`gstack-egress list --sink memorable-recall` shows receipts with
|
|
`output-written` or `injected=no` outcomes. `injected=no` means the vendor
|
|
returned nothing: check `memorable status` and `memorable doctor` for
|
|
login, consent and stored procedures.
|
|
- **Outcomes say `timeout`.** The vendor took longer than the budget allowed
|
|
(roughly 4 seconds after gstack's own work). That is usually network.
|
|
- **`hook-errors.log` names a refusal.** `refused:redaction-high` means a
|
|
credential shape was in the prompt; `trust policy ... deny or read-only`
|
|
means the repo is protected; `receipt-unwritable` means
|
|
`~/.gstack/security` is not writable.
|
|
- **`enable` says the stable install predates this bridge.** Run `./setup`
|
|
(or `/gstack-upgrade`) so the hook registered at `~/.claude/skills/gstack`
|
|
is the code that will run.
|
|
|
|
## Under the hood, accurately
|
|
|
|
`bin/gstack-memorable` is the front door. It resolves the vendor CLI from
|
|
`GSTACK_MEMORABLE_BIN`, then `MEMORABLE_BIN`, then `~/.memorable/bin/memorable`,
|
|
then `PATH`, and refuses with a message naming those when it finds none. It
|
|
never executes the binary. It takes a lock for the duration of `enable` and
|
|
`disable`, captures the prior state first, and on a failure restores that
|
|
state rather than an assumed one.
|
|
|
|
`hosts/claude/hooks/memorable-user-prompt-hook` is the registered command: a
|
|
fail-open bash shim over `memorable-user-prompt-hook.ts`, which runs the
|
|
pipeline described above and always exits 0.
|
|
|
|
Registration goes through `gstack-settings-hook ensure-event` with a 5 s
|
|
timeout, and the hook has a row in that file's `KNOWN_HOOKS` table, so it is
|
|
identified by its command, never by a tag. Consequences:
|
|
|
|
- `gstack-settings-hook list-items --event UserPromptSubmit --owned-by
|
|
gstack-memorable` shows it whether or not the tag survived;
|
|
`list-sources` shows only tagged entries, so it may not.
|
|
- `prune-stale --repoint` (run by every `./setup`) heals a stale path.
|
|
- `./setup --no-team` excludes it from its sweep; `gstack-uninstall` removes it.
|
|
- `gstack-settings-hook rollback` is a whole-file restore of the last
|
|
mutation, not a per-hook undo.
|
|
|
|
Windows: not yet. There is no process group to contain the vendor there, so
|
|
`enable` refuses and the hook exits 0. Tracked in TODOS.md.
|
|
|
|
## Credits
|
|
|
|
The integration and its hook contract are by
|
|
[Advaiyt Sane](https://github.com/AdvaiytSane) (@AdvaiytSane) and
|
|
[Nikhil Krishnaswamy](https://github.com/NIkhil-cmd-cmd) (@NIkhil-cmd-cmd)
|
|
at Memorable (#2831). The consent, receipt, envelope and containment layers
|
|
were added in review.
|