mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-01 19:25:10 +02:00
78c207efb4
* refactor: rename qa-design-review → design-review The "qa-" prefix was confusing — this is the live-site design audit with fix loop, not a QA-only report. Rename directory and update all references across docs, tests, scripts, and skill templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: interactive /plan-design-review + CEO invokes designer Rewrite /plan-design-review from report-only grading to an interactive plan-fixer that rates each design dimension 0-10, explains what a 10 looks like, and edits the plan to get there. Parallel structure with /plan-ceo-review and /plan-eng-review — one issue = one AskUserQuestion. CEO review now detects UI scope and invokes the designer perspective when the plan has frontend/UX work, so you get design review automatically when it matters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: validation + touchfile entries for 100% coverage Add design-consultation to command/snapshot flag validation. Add 4 skills to contributor mode validation (plan-design-review, design-review, design-consultation, document-release). Add 2 templates to hardcoded branch check. Register touchfile entries for 10 new LLM-judge tests and 1 new E2E test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: LLM-judge for 10 skills + gstack-upgrade E2E Add LLM-judge quality evals for all uncovered skills using a DRY runWorkflowJudge helper with section marker guards. Add real E2E test for gstack-upgrade using mock git remote (replaces test.todo). Add plan-edit assertion to plan-design-review E2E. 14/15 skills now at full coverage. setup-browser-cookies remains deferred (needs real browser). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: add bisect commit style to CLAUDE.md All commits should be single logical changes, split before pushing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: bump version and changelog (v0.6.4.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
117 lines
3.9 KiB
TypeScript
117 lines
3.9 KiB
TypeScript
#!/usr/bin/env bun
|
|
/**
|
|
* skill:check — Health summary for all SKILL.md files.
|
|
*
|
|
* Reports:
|
|
* - Command validation (valid/invalid/snapshot errors)
|
|
* - Template coverage (which SKILL.md files have .tmpl sources)
|
|
* - Freshness check (generated files match committed files)
|
|
*/
|
|
|
|
import { validateSkill } from '../test/helpers/skill-parser';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { execSync } from 'child_process';
|
|
|
|
const ROOT = path.resolve(import.meta.dir, '..');
|
|
|
|
// Find all SKILL.md files
|
|
const SKILL_FILES = [
|
|
'SKILL.md',
|
|
'browse/SKILL.md',
|
|
'qa/SKILL.md',
|
|
'qa-only/SKILL.md',
|
|
'ship/SKILL.md',
|
|
'review/SKILL.md',
|
|
'retro/SKILL.md',
|
|
'plan-ceo-review/SKILL.md',
|
|
'plan-eng-review/SKILL.md',
|
|
'setup-browser-cookies/SKILL.md',
|
|
'plan-design-review/SKILL.md',
|
|
'design-review/SKILL.md',
|
|
'gstack-upgrade/SKILL.md',
|
|
'document-release/SKILL.md',
|
|
].filter(f => fs.existsSync(path.join(ROOT, f)));
|
|
|
|
let hasErrors = false;
|
|
|
|
// ─── Skills ─────────────────────────────────────────────────
|
|
|
|
console.log(' Skills:');
|
|
for (const file of SKILL_FILES) {
|
|
const fullPath = path.join(ROOT, file);
|
|
const result = validateSkill(fullPath);
|
|
|
|
if (result.warnings.length > 0) {
|
|
console.log(` \u26a0\ufe0f ${file.padEnd(30)} — ${result.warnings.join(', ')}`);
|
|
continue;
|
|
}
|
|
|
|
const totalValid = result.valid.length;
|
|
const totalInvalid = result.invalid.length;
|
|
const totalSnapErrors = result.snapshotFlagErrors.length;
|
|
|
|
if (totalInvalid > 0 || totalSnapErrors > 0) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${file.padEnd(30)} — ${totalValid} valid, ${totalInvalid} invalid, ${totalSnapErrors} snapshot errors`);
|
|
for (const inv of result.invalid) {
|
|
console.log(` line ${inv.line}: unknown command '${inv.command}'`);
|
|
}
|
|
for (const se of result.snapshotFlagErrors) {
|
|
console.log(` line ${se.command.line}: ${se.error}`);
|
|
}
|
|
} else {
|
|
console.log(` \u2705 ${file.padEnd(30)} — ${totalValid} commands, all valid`);
|
|
}
|
|
}
|
|
|
|
// ─── Templates ──────────────────────────────────────────────
|
|
|
|
console.log('\n Templates:');
|
|
const TEMPLATES = [
|
|
{ tmpl: 'SKILL.md.tmpl', output: 'SKILL.md' },
|
|
{ tmpl: 'browse/SKILL.md.tmpl', output: 'browse/SKILL.md' },
|
|
];
|
|
|
|
for (const { tmpl, output } of TEMPLATES) {
|
|
const tmplPath = path.join(ROOT, tmpl);
|
|
const outPath = path.join(ROOT, output);
|
|
if (!fs.existsSync(tmplPath)) {
|
|
console.log(` \u26a0\ufe0f ${output.padEnd(30)} — no template`);
|
|
continue;
|
|
}
|
|
if (!fs.existsSync(outPath)) {
|
|
hasErrors = true;
|
|
console.log(` \u274c ${output.padEnd(30)} — generated file missing! Run: bun run gen:skill-docs`);
|
|
continue;
|
|
}
|
|
console.log(` \u2705 ${tmpl.padEnd(30)} \u2192 ${output}`);
|
|
}
|
|
|
|
// Skills without templates
|
|
for (const file of SKILL_FILES) {
|
|
const tmplPath = path.join(ROOT, file + '.tmpl');
|
|
if (!fs.existsSync(tmplPath) && !TEMPLATES.some(t => t.output === file)) {
|
|
console.log(` \u26a0\ufe0f ${file.padEnd(30)} — no template (OK if no $B commands)`);
|
|
}
|
|
}
|
|
|
|
// ─── Freshness ──────────────────────────────────────────────
|
|
|
|
console.log('\n Freshness:');
|
|
try {
|
|
execSync('bun run scripts/gen-skill-docs.ts --dry-run', { cwd: ROOT, stdio: 'pipe' });
|
|
console.log(' \u2705 All generated files are fresh');
|
|
} catch (err: any) {
|
|
hasErrors = true;
|
|
const output = err.stdout?.toString() || '';
|
|
console.log(' \u274c Generated files are stale:');
|
|
for (const line of output.split('\n').filter((l: string) => l.startsWith('STALE'))) {
|
|
console.log(` ${line}`);
|
|
}
|
|
console.log(' Run: bun run gen:skill-docs');
|
|
}
|
|
|
|
console.log('');
|
|
process.exit(hasErrors ? 1 : 0);
|