mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-06 00:44:07 +01:00
ef6425036e
* fix(outside-review): a ## Recommendation heading counts as the completion marker (#3980) A completed Codex review whose model wrote its recommendation as a Markdown heading with the prose underneath was classified unavailable/missing_markers, because only an inline "Recommendation: <action> because <reason>" line passed. The fence-blanked views now fold the heading and its next prose line into the inline marker. Empty sections, no because-rationale, list or quote lines under the heading, and fenced examples still report missing. Co-authored-by: nfitzsimmons <2198211+nfitzsimmons@users.noreply.github.com> Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(outside-review): keep labels and verdicts under the heading visible to the severity parsers Review p1 (specialist + adversarial) found that folding the heading into the fence-blanked views moved a P1:, Critical: or Verdict: line under the heading off line start, so a blocking review read clean. The folded view now feeds only the completion check and the no-findings conclusion. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(outside-review): fold only a heading line that carries a because-clause Pass 2's fix-check found that a structured reply ending '## Recommendation' over 'No issues found.' read clean at base and unverified after the fold. A line with no because can never meet the completion marker, so it is left as prose. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(changelog): fragment for the Recommendation heading fix Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(troubleshooting): missing-markers entry names the Recommendation heading form Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: nfitzsimmons <2198211+nfitzsimmons@users.noreply.github.com> Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>