CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-17 22:24:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve crossing ways validation performance by reducing garbage collection

Browse Source
This commit is contained in:
Quincy Morgan
2019-02-04 15:41:22 -05:00
parent 4921a32be1
commit 01c4c46918
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/validations/crossing_ways.js
+6 -4
View File
@@ -18,17 +18,19 @@ export function validationCrossingWays() {
// any edge on way. Return the cross point if so.
function findEdgeToWayCrossCoords(n1, n2, way, graph) {
var crossCoords = [];
var nA, nB, segment1, segment2;
var nodes = graph.childNodes(way);
for (var j = 0; j < nodes.length - 1; j++) {
var nA = nodes[j],
nB = nodes[j + 1];
nA = nodes[j];
nB = nodes[j + 1];
if (nA.id === n1.id || nA.id === n2.id ||
nB.id === n1.id || nB.id === n2.id) {
// n1 or n2 is a connection node; skip
continue;
}
var point = geoLineIntersection([n1.loc, n2.loc], [nA.loc, nB.loc]);
segment1 = [n1.loc, n2.loc];
segment2 = [nA.loc, nB.loc];
var point = geoLineIntersection(segment1, segment2);
if (point) crossCoords.push(point);
}
return crossCoords;