CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-22 21:53:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Also make sure you can delete the new row in the raw tag editor

Browse Source 
(re #5840)
This commit is contained in:
Bryan Housel
2019-02-07 15:04:16 -05:00
parent 2aa409d5a9
commit 02790fcc5c
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
modules/ui/raw_tag_editor.js
View File

@@ -155,10 +155,10 @@ export function uiRawTagEditor(context) {
.order();
items
.each(function(tag) {
.each(function(d) {
var row = d3_select(this);
var key = row.select('input.key'); // propagate bound data to child
var value = row.select('input.value'); // propagate bound data to child
var key = row.select('input.key'); // propagate bound data
var value = row.select('input.value'); // propagate bound data
if (_entityID && taginfo && _state !== 'hover') {
bindTypeahead(key, value);
@@ -167,20 +167,22 @@ export function uiRawTagEditor(context) {
var isRelation = (_entityID && context.entity(_entityID).type === 'relation');
var reference;
if (isRelation && tag.key === 'type') {
reference = uiTagReference({ rtype: tag.value }, context);
if (isRelation && d.key === 'type') {
reference = uiTagReference({ rtype: d.value }, context);
} else {
reference = uiTagReference({ key: tag.key, value: tag.value }, context);
reference = uiTagReference({ key: d.key, value: d.value }, context);
}
if (_state === 'hover') {
reference.showing(false);
}
row.select('.inner-wrap')
row.select('.inner-wrap') // propagate bound data
.call(reference.button);
row.call(reference.body);
row.select('button.remove'); // propagate bound data
});
items.selectAll('input.key')
@@ -344,9 +346,15 @@ export function uiRawTagEditor(context) {
function removeTag(d) {
if (isReadOnly(d)) return;
var t = {};
t[d.key] = undefined;
dispatch.call('change', this, t);
if (d.key === '') { // removing the blank row
_showBlank = false;
content(wrap);
} else {
var t = {};
t[d.key] = undefined;
dispatch.call('change', this, t);
}
}