CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 01:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Force tests to use mouse events instead of pointer events

Browse Source 
The pointer events use a different mechanism for counting clicks that doesn't
work when the tests are run in a real browser like Chrome. This change forces
iD to always use mouse events during testing, even in a real browser.
This commit is contained in:
Bryan Housel
2021-08-18 18:55:28 -04:00
parent b2d18d1ebe
commit 08c765236f
2 changed files with 24 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
test/spec/behavior/select.js
View File

@@ -1,6 +1,15 @@
describe('iD.behaviorSelect', function() {
var a, b, context, behavior, container;
function simulateClick(el, o) {
// clicks need to appear wherever the map is
var mapNode = context.container().select('.main-map').node();
var rect = mapNode.getBoundingClientRect();
var click = { clientX: rect.left, clientY: rect.top };
happen.mousedown(el, Object.assign({}, click, o));
happen.mouseup(el, Object.assign({}, click, o));
}
beforeEach(function() {
container = d3.select('body').append('div');
context = iD.coreContext().assetPath('../dist/').init().container(container);
@@ -34,77 +43,71 @@ describe('iD.behaviorSelect', function() {
container.remove();
});
specify('refuse to enter select mode with no ids', function() {
it('refuses to enter select mode with no ids', function() {
context.enter(iD.modeSelect(context, []));
expect(context.mode().id, 'empty array').to.eql('browse');
context.enter(iD.modeSelect(context, undefined));
expect(context.mode().id, 'undefined').to.eql('browse');
});
specify('refuse to enter select mode with nonexistent ids', function() {
it('refuses to enter select mode with nonexistent ids', function() {
context.enter(iD.modeSelect(context, ['w-1']));
expect(context.mode().id).to.eql('browse');
});
specify('click on entity selects the entity', function(done) {
it('click on entity selects the entity', function(done) {
var el = context.surface().selectAll('.' + a.id).node();
happen.mousedown(el, { clientX: 100, clientY: 100 });
happen.mouseup(el, { clientX: 100, clientY: 100 });
simulateClick(el, {});
window.setTimeout(function() {
expect(context.selectedIDs()).to.eql([a.id]);
done();
}, 50);
});
specify('click on empty space clears the selection', function(done) {
it('click on empty space clears the selection', function(done) {
context.enter(iD.modeSelect(context, [a.id]));
var el = context.surface().node();
happen.mousedown(el, { clientX: 100, clientY: 100 });
happen.mouseup(el, { clientX: 100, clientY: 100 });
simulateClick(el, {});
window.setTimeout(function() {
expect(context.mode().id).to.eql('browse');
done();
}, 50);
});
specify('shift-click on unselected entity adds it to the selection', function(done) {
it('shift-click on unselected entity adds it to the selection', function(done) {
context.enter(iD.modeSelect(context, [a.id]));
var el = context.surface().selectAll('.' + b.id).node();
happen.mousedown(el, { clientX: 100, clientY: 100, shiftKey: true });
happen.mouseup(el, { clientX: 100, clientY: 100, shiftKey: true });
simulateClick(el, { shiftKey: true });
window.setTimeout(function() {
expect(context.selectedIDs()).to.eql([a.id, b.id]);
done();
}, 50);
});
specify('shift-click on selected entity removes it from the selection', function(done) {
it('shift-click on selected entity removes it from the selection', function(done) {
context.enter(iD.modeSelect(context, [a.id, b.id]));
var el = context.surface().selectAll('.' + b.id).node();
happen.mousedown(el, { clientX: 100, clientY: 100, shiftKey: true });
happen.mouseup(el, { clientX: 100, clientY: 100, shiftKey: true });
simulateClick(el, { shiftKey: true });
window.setTimeout(function() {
expect(context.selectedIDs()).to.eql([a.id]);
done();
}, 50);
});
specify('shift-click on last selected entity clears the selection', function(done) {
it('shift-click on last selected entity clears the selection', function(done) {
context.enter(iD.modeSelect(context, [a.id]));
var el = context.surface().selectAll('.' + a.id).node();
happen.mousedown(el, { clientX: 100, clientY: 100, shiftKey: true });
happen.mouseup(el, { clientX: 100, clientY: 100, shiftKey: true });
simulateClick(el, { shiftKey: true });
window.setTimeout(function() {
expect(context.mode().id).to.eql('browse');
done();
}, 50);
});
specify('shift-click on empty space leaves the selection unchanged', function(done) {
it('shift-click on empty space leaves the selection unchanged', function(done) {
context.enter(iD.modeSelect(context, [a.id]));
var el = context.surface().node();
happen.mousedown(el, { clientX: 100, clientY: 100, shiftKey: true });
happen.mouseup(el, { clientX: 100, clientY: 100, shiftKey: true });
simulateClick(el, { shiftKey: true });
window.setTimeout(function() {
expect(context.selectedIDs()).to.eql([a.id]);
done();

1
test/spec/spec_helpers.js
View File

@@ -110,6 +110,7 @@ mocha.setup({
expect = chai.expect;
window.d3 = iD.d3; // Remove this if we can avoid exporting all of d3.js
delete window.PointerEvent; // force the brower to use mouse events
// Workaround for `Array.from` polyfill in PhantomJS
// https://github.com/openstreetmap/iD/issues/6087#issuecomment-476219308