CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-15 21:48:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve multilingual name UI updates, don't use blank tag values (re: #8164)

Browse Source
This commit is contained in:
Quincy Morgan
2020-12-04 10:22:18 -05:00
parent b873d5f58e
commit 0bc2b1b6a0
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/ui/fields/localized.js
+10 -5
View File
@@ -138,8 +138,12 @@ export function uiFieldLocalized(field, context) {
}
}
_multilingual = _multilingual.filter(function(item) {
return !item.lang || !existingLangs.has(item.lang);
// Don't remove items based on deleted tags, since this makes the UI
// disappear unexpectedly when clearing values - #8164
_multilingual.forEach(function(item) {
if (item.lang && existingLangs.has(item.lang)) {
item.value = '';
}
});
}
@@ -424,7 +428,7 @@ export function uiFieldLocalized(field, context) {
function changeValue(d3_event, d) {
if (!d.lang) return;
var value = context.cleanTagValue(utilGetSetValue(d3_select(this))) || '';
var value = context.cleanTagValue(utilGetSetValue(d3_select(this))) || undefined;
// don't override multiple values with blank string
if (!value && Array.isArray(d.value)) return;
@@ -512,6 +516,9 @@ export function uiFieldLocalized(field, context) {
if (field.locked()) return;
d3_event.preventDefault();
// remove the UI item manually
_multilingual.splice(_multilingual.indexOf(d), 1);
if (d.lang) {
var langKey = key(d.lang);
if (langKey in _tags) {
@@ -519,11 +526,9 @@ export function uiFieldLocalized(field, context) {
var t = {};
t[langKey] = undefined;
dispatch.call('change', this, t);
return;
}
}
_multilingual.splice(index, 1);
renderMultilingual(selection);
})
.call(svgIcon('#iD-operation-delete'));