CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-12 16:52:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

display explicit "context" tags of deprecation rules, closes #10104

Browse Source
This commit is contained in:
Martin Raifer
2025-04-15 11:34:33 +02:00
parent d871792d94
commit 10030bb4ae
3 changed files with 41 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/spec/validations/outdated_tags.js
View File

@@ -1,3 +1,4 @@
import { select as d3_select } from 'd3-selection';
import { setTimeout } from 'node:timers/promises';
describe('iD.validations.outdated_tags', function () {
@@ -194,6 +195,20 @@ describe('iD.validations.outdated_tags', function () {
});
});
it('includes unchanged context tags of deprecation rule in tag reference', async () => {
createWay({ building: 'roof' });
const validator = iD.validationOutdatedTags(context);
await setTimeout(20);
const issues = validate(validator);
expect(issues).toHaveLength(1);
const selection = d3_select(document.createElement('div'));
issues[0].reference(selection);
const tagReference = selection.selectAll('table .tagDiff-row').data();
expect(tagReference).toHaveLength(2);
expect(tagReference.some(ref => ref.type === '+' && ref.key === 'layer')).toBeTruthy();
expect(tagReference.some(ref => ref.type === '~' && ref.key === 'building')).toBeTruthy();
});
it('generates 2 separate issues for incomplete tags and NSI suggestions', async () => {
createWay({ building: 'roof', amenity: 'fast_food', brand: 'Fish Bowl' });
const validator = iD.validationOutdatedTags(context);