CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly include certain railways for crossing validation instead of excluding some

Browse Source 
Don't flag abandoned or razed railway crossings
This commit is contained in:
Quincy Morgan
2019-02-21 15:09:13 -05:00
parent 2407c3f383
commit 10e73fc15c
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
modules/validations/crossing_ways.js
View File

@@ -66,12 +66,13 @@ export function validationCrossingWays() {
}
// only validate certain waterway features
// only validate certain waterway and railway features
var waterways = ['canal', 'ditch', 'drain', 'river', 'stream'];
// ignore certain highway and railway features
var ignoredHighways = ['rest_area', 'services', 'proposed'];
var ignoredRailways = ['train_wash', 'proposed'];
var ignoredBuildings = ['proposed'];
var railways = ['rail', 'disused', 'tram', 'subway', 'narrow_gauge', 'light_rail',
'preserved', 'miniature', 'monorail', 'funicular'];
// ignore certain highway and building features
var ignoredHighways = ['rest_area', 'services', 'proposed', 'razed'];
var ignoredBuildings = ['proposed', 'razed'];
function getFeatureTypeForTags(tags) {
@@ -81,7 +82,7 @@ export function validationCrossingWays() {
if (hasTag(tags, 'area')) return null;
if (hasTag(tags, 'highway') && ignoredHighways.indexOf(tags.highway) === -1) return 'highway';
if (hasTag(tags, 'railway') && ignoredRailways.indexOf(tags.railway) === -1) return 'railway';
if (hasTag(tags, 'railway') && railways.indexOf(tags.railway) !== -1) return 'railway';
if (hasTag(tags, 'waterway') && waterways.indexOf(tags.waterway) !== -1) return 'waterway';
return null;
@@ -252,7 +253,7 @@ export function validationCrossingWays() {
// mark this way as checked even if there are no crossings
comparedWays[way2.id] = true;
// only check crossing highway, waterway, building, and railway
way2FeatureType = getFeatureTypeForCrossingCheck(way2, graph);
if (way2FeatureType === null ||