CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-25 23:13:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't show reference until image is loaded or errored

Browse Source
This commit is contained in:
John Firebaugh
2013-03-27 10:39:08 -07:00
parent f4c03316d2
commit 1828bddd5d
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
js/id/ui/tag_reference.js
View File

@@ -35,6 +35,16 @@ iD.ui.TagReference = function(entity, tag) {
.attr('class', 'tag-reference-spinner')
.attr('src', 'img/loader-white.gif');
var referenceBody = selection.append('div')
.attr('class', 'tag-reference-wrap')
.style('opacity', 0);
function show() {
referenceBody
.transition()
.style('opacity', 1);
}
taginfo.docs(tag, function(err, docs) {
spinner
.style('position', 'absolute')
@@ -42,20 +52,14 @@ iD.ui.TagReference = function(entity, tag) {
.style('opacity', 0)
.remove();
var referenceBody = selection.append('div')
.attr('class', 'tag-reference-wrap')
.style('opacity', 0);
referenceBody
.transition()
.style('opacity', 1);
if (!err && docs) {
docs = findLocal(docs);
}
if (!docs || !docs.description) {
return referenceBody.text(t('inspector.no_documentation_key'));
referenceBody.text(t('inspector.no_documentation_key'));
show();
return;
}
if (docs.image && docs.image.thumb_url_prefix) {
@@ -63,7 +67,8 @@ iD.ui.TagReference = function(entity, tag) {
.append('img')
.attr('class', 'wiki-image')
.attr('src', docs.image.thumb_url_prefix + "100" + docs.image.thumb_url_suffix)
.on('error', function() { d3.select(this).remove(); });
.on('load', function() { show(); })
.on('error', function() { d3.select(this).remove(); show(); });
}
referenceBody